Skip to content

bgpd: Remove unused BGP_NEXTHOP_CONNECTED_CHANGED flag for nexthop #17099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ton31337
Copy link
Member

No description provided.

@frrbot frrbot bot added the bgp label Oct 15, 2024
@ton31337 ton31337 force-pushed the fix/remove_BGP_NEXTHOP_CONNECTED_CHANGED branch from faddd65 to 74c517e Compare October 15, 2024 06:45
@github-actions github-actions bot added size/S and removed size/XS labels Oct 15, 2024
Also reduce the size of change_flags, which is way enough to be 1 byte.

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337 ton31337 force-pushed the fix/remove_BGP_NEXTHOP_CONNECTED_CHANGED branch from 74c517e to a2e226b Compare October 15, 2024 09:43
Copy link
Contributor

@mjstapp mjstapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might quibble about shrinking the change_flags - but nice to cleanup...

@mjstapp mjstapp merged commit 8936108 into FRRouting:master Oct 15, 2024
11 checks passed
@ton31337 ton31337 deleted the fix/remove_BGP_NEXTHOP_CONNECTED_CHANGED branch October 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants