Skip to content

Add pyproject.toml for Custom Node Registry #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

haohaocreates
Copy link
Contributor

@haohaocreates haohaocreates commented May 22, 2024

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.

The main benefits are that authors can

  • publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
  • automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

  • Go to the registry. Login and create a publisher id. Add the publisher id into the pyproject.toml file.
  • Write a short description.
  • Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish

Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

@Extraltodeus
Copy link
Owner

Hello, I mean I'd be ok to add something if that can help you to reference it or something but I really don't feel like creating some account somewhere. To me one of the interest of open source is to not have to bother and not depend on some portal.

@Extraltodeus
Copy link
Owner

Extraltodeus commented May 22, 2024

Correct me if I'm wrong but basically you're aasking me to produce work for your platform. However if you want to reference my project there: Sure! :)

@haohaocreates
Copy link
Contributor Author

haohaocreates commented May 22, 2024

Correct me if I'm wrong but basically you're aasking me to produce work for your platform. However if you want to reference my project there: Sure! :)

hey! totally understand where you are coming from! Basically idea is that this will ideally be used as the default backend for comfyui-manager and comf-cli, it'll

  • help custom node authors publish their nodes by versions
  • authors systematically and automatically test their nodes against the main comfyUI repo to make sure nothing breaks
  • and make sure custom node names are globally unique so authors and users can reference nodes safely without having to worry about a namespace conflict

and the way we are doing that is through this registry, something that dr.lt.data and comfy author are supporting us on too!

@Extraltodeus Extraltodeus merged commit a9985f5 into Extraltodeus:main Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants