Skip to content

fix Breaking Changes for initWithStoredValues 🏴 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2021

Conversation

parasharrajat
Copy link
Member

Details

Allow trigger for the subscribers that are using initWithStoredValues:false even if the data is not changed.

Related Issues

Fixes Expensify/App#4500

Automated Tests

Linked PRs

@parasharrajat parasharrajat requested a review from a team as a code owner August 11, 2021 22:40
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MelvinBot MelvinBot requested review from joelbettner and removed request for a team August 11, 2021 22:40
@parasharrajat
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

@parasharrajat parasharrajat changed the title fix Breaking Changes for initWithStoredValues 🏴 fix Breaking Changes for initWithStoredValues 🏴 Aug 11, 2021
joelbettner
joelbettner previously approved these changes Aug 11, 2021
@joelbettner
Copy link
Contributor

LGTM

@parasharrajat
Copy link
Member Author

Fixed Linting

joelbettner
joelbettner previously approved these changes Aug 11, 2021
@joelbettner
Copy link
Contributor

Oh dang... @parasharrajat the linting again.

@parasharrajat
Copy link
Member Author

Sorry my bad. All good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hold for payment 25 august] Onyx changes break Exisiting App architecture.
2 participants