-
Notifications
You must be signed in to change notification settings - Fork 78
fix Breaking Changes for initWithStoredValues
🏴
#96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
8ff3229
to
1ba9468
Compare
I have read the CLA Document and I hereby sign the CLA |
initWithStoredValues
🏴 initWithStoredValues
🏴
joelbettner
previously approved these changes
Aug 11, 2021
LGTM |
Fixed Linting |
joelbettner
previously approved these changes
Aug 11, 2021
Oh dang... @parasharrajat the linting again. |
928d2c1
to
ac78417
Compare
Sorry my bad. All good now. |
joelbettner
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Allow trigger for the subscribers that are using
initWithStoredValues:false
even if the data is not changed.Related Issues
Fixes Expensify/App#4500
Automated Tests
Linked PRs