Change image placeholder vertical offset when image url is incorrect #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skalakid
reviewed
Jun 3, 2025
|
@Skalakid I think it's because I have this scroll bar setting on. I have this on main as well. Screen.Recording.2025-06-04.at.13.29.45.mov |
Skalakid
reviewed
Jun 4, 2025
| @@ -7,7 +7,7 @@ const spinnerDefaultStyles = { | |||
| }; | |||
| const spinnerContainerDefaultStyles = { | |||
| position: 'absolute', | |||
| bottom: '0', | |||
| bottom: '1px', | |||
There was a problem hiding this comment.
Maybe let's add a small comment with an explanation of this change :D
Skalakid
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes image placeholder vertical offset on web when img url is incorrect.
Related Issues
Closes #687.
Manual Tests
Videos
Before
Screen.Recording.2025-06-02.at.16.22.25.mov
After
Screen.Recording.2025-06-02.at.16.21.42.mov
Linked PRs