Prevent emoji being formatted #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
16 tasks
s77rt
suggested changes
May 28, 2025
src/rangeUtils.ts
Outdated
Comment on lines
14
to
15
| default: | ||
| return 1; |
There was a problem hiding this comment.
Why is the default 1? Can't we make the emoji -1 and keep the rest as is
There was a problem hiding this comment.
No strong reason, just trying to avoid using negative value. Updated.
|
Hmm, the test fails locally on me too |
|
@bernhardoj Are the tests failing on |
|
Oh my bad, the playwright isn't installed yet. It passes on me locally, both main and this PR |
From the log, the 1st test here that fails in CI isn't "checkmarked", but it still says 51 passed. 
On main, all are "checkmarked". EDIT: Oh, now all are "checkmarked" on this PR too. I think it's just a visual issue, but all the test still passes. I think we should re-run the CI. |
|
@luacmartins can you please re-trigger the tests |
|
Running again |
s77rt
approved these changes
Jun 2, 2025
luacmartins
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When emoji is wrapped with a markdown, the emoji is being formatted and we don't want that.
Related Issues
$ Expensify/App#62029
Manual Tests
_😄_Linked PRs