Implement provide-canBeMissing-in-useOnyx rule #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioh8010
commented
Mar 23, 2025
iwiznia
previously approved these changes
Mar 24, 2025
|
I think you forgot to add a HOLD to this, right? Adding it just in case |
iwiznia
changed the title
iwiznia
approved these changes
Mar 24, 2025
|
@iwiznia We can merge now if you want too, I will enable it in a E/App PR later when the Onyx changes are merged and released. |
|
Ah ok good to know |
iwiznia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new ESLint rule to enforce
useOnyxcalls to provide thecanBeMissingoption. It's intended to be used on .eslintrc.changed.js, that will only run for the changes files of a PR.This rule should only be used when the Onyx PR is merged and its release available in E/App.
Issue: Expensify/App#58499