-
Notifications
You must be signed in to change notification settings - Fork 3.2k
remove focus from disabled buttons #9093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove focus from disabled buttons #9093
Conversation
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @sketchydroide in version: 1.1.64-0 🚀
|
🚀 Deployed to production by @AndrewGable in version: 1.1.64-0 🚀
|
@Justicea83 I think this is causing a regression here cc: @sketchydroide |
Looking into it now |
@Justicea83 Any update on this? |
@Santhosh-Sellavel please do we have a separate issue for the regression? |
@Justicea83 This one #9415 |
I can see someone else assigned, you still want me to take a look? |
Since you were looking into this earlier, I asked you an update. I'm fine with anyone looking into the issue. |
Details
Fixed Issues
$#8934
Tests
Test 1
Test 2
PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Test 1
Test 2
Screenshots
Web
2022-05-19_13-11-04.mp4
Mobile Web
2022-05-19_13-42-22.mp4
Desktop
2022-05-19_13-14-19.mp4
iOS
2022-05-19_13-38-22.mp4
Android
2022-05-19_13-22-58.mp4