Skip to content

Remove unnecessary _.map in the code for video call menu items #8866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2022

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented May 3, 2022

Tests & QA

  1. Open a chat
  2. Click on the video chat icon
  3. Click the google meet option
  4. Go back to the app
  5. Verify that the video chat menu went away
  • Verify that no errors appear in the JS console

Screenshots

Web

2022-05-03_14-29-40.mp4

Mobile Web

2022-05-03_14-30-17.mp4

Desktop

2022-05-03_14-31-58.mp4

iOS

2022-05-03_14-27-42.mp4

Android

2022-05-03_14-21-01.mp4

@tgolen tgolen requested a review from Luke9389 May 3, 2022 20:32
@tgolen tgolen requested a review from a team as a code owner May 3, 2022 20:32
@tgolen tgolen self-assigned this May 3, 2022
@melvin-bot melvin-bot bot removed the request for review from a team May 3, 2022 20:32
Copy link
Contributor

@Luke9389 Luke9389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luke9389 Luke9389 merged commit 411e59c into main May 4, 2022
@Luke9389 Luke9389 deleted the tgolen-cleanup-videocall branch May 4, 2022 22:49
@OSBotify
Copy link
Contributor

OSBotify commented May 4, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented May 9, 2022

🚀 Cherry-picked to staging by @sketchydroide in version: 1.1.57-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants