-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Android-Emoji is selected only on second tap #8221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c041d81
Android-Emoji is selected only on second tap
mollfpr 135dc22
using the right compose function
mollfpr 8744040
new approaches
mollfpr ce6cc22
add early return and fix comment style
mollfpr 8f07d97
Merge branch 'main' of https://github.com/mollfpr/App into fix-8110
mollfpr f0b7109
Merge branch 'main' of https://github.com/mollfpr/App into fix-8110
mollfpr be94ef4
make comments more clear
mollfpr ba776b9
remove link from comment
mollfpr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment could be better,
cc: @tgolen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't like this change. If we had a policy of a code comment referencing the GH for each issue that was fixed in the code, then the code will be littered with thousands of them. It's easy to find the associated GH for a change using "blame" to find the PR that introduced the code.
Can you please remove the GH link from the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comment, @tgolen. I'm not sure, that's why I put up a
cc:
for you on this.@mollfpr Sorry for the back and forth, remove the link & let us know.