-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[No QA]Sign cherry pick PRs as @OSBotify #6655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we also add manual cherry-picking to the test list just to confirm that all still works?
@@ -89,7 +86,6 @@ jobs: | |||
|
|||
- name: Create branch for new pull request | |||
run: | | |||
git config user.name ${{ github.actor }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will fail if we don't specify a user name. I think we need to hardcode it to OSBotify
if we want all CP commits to be done + signed by OSBotify
:
git config user.name 'OSBotify'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Let's see if this works |
(cherry picked from commit 7068258)
Seems like it worked for a label CP:
|
Testing this with a manual CP of #6684 |
Awesome!! Thank you for testing this! |
🚀 Deployed to staging by @roryabraham in version: 1.1.19-5 🚀
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
Details
This PR should sign our cherry pick commits and make all the cherry picks created by @OSBotify. This is the last step to forcing signatures for all commits.
Fixed Issues
$ GH_LINK
Tests
staging
branch are signed and verified