Skip to content

Create Security sub-settings menu #6624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 10, 2021
Merged

Create Security sub-settings menu #6624

merged 8 commits into from
Dec 10, 2021

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Dec 7, 2021

Details

Added the security sub-menu to the settings page. This prepares for the NewDot account deletion feature.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/187743

Tests

Verify the settings sub-menu exists

  • Sign in
  • Open the LHN and tap your profile icon
  • You should see a 'Security' option in the list, tap it
  • You should see a new sub-setting menu, with a single option: 'Change Password'
  • Tap 'Change Password'
  • Tap the back icon, you should be taken back to the Security menu
  • Tap the back icon again, you should be taken to the top-level settings page

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-12-08 at 16 09 42

Mobile Web

Simulator Screen Shot - iPhone 7 - 2021-12-08 at 16 59 00

Desktop

Screenshot 2021-12-08 at 16 11 29

iOS

Simulator Screen Shot - iPhone 7 - 2021-12-08 at 16 53 19

Android

device-2021-12-08-161233

@Julesssss Julesssss self-assigned this Dec 7, 2021
};

const AboutPage = (props) => {
const menuItems = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will imminently be adding to this array. Close account will be added with this issue, and 2FA will be added with N7.

@Julesssss Julesssss marked this pull request as ready for review December 8, 2021 16:03
@Julesssss Julesssss requested a review from a team as a code owner December 8, 2021 16:03
@MelvinBot MelvinBot requested review from madmax330 and removed request for a team December 8, 2021 16:03
@Julesssss
Copy link
Contributor Author

Reassigning reviewer as Max is OOO.

@Julesssss Julesssss requested a review from a team December 10, 2021 10:33
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team December 10, 2021 10:33
Copy link
Contributor

@marcochavezf marcochavezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@marcochavezf marcochavezf merged commit 6af2076 into main Dec 10, 2021
@marcochavezf marcochavezf deleted the jules-closeAccount branch December 10, 2021 16:58
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcochavezf in version: 1.1.19-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants