Skip to content

[CP Staging] Revert "[NO QA] Console error displayed on date selection for per-diem expenses" #66131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

MonilBhavsar
Copy link
Contributor

@MonilBhavsar MonilBhavsar commented Jul 15, 2025

Reverts #65807

Fixes #66103
Fixes #66112
Fixes #66133
Fixes #66102

Copy link
Contributor

🚧 @MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #66131.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://66131.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@MonilBhavsar MonilBhavsar marked this pull request as ready for review July 15, 2025 09:00
@MonilBhavsar MonilBhavsar requested a review from a team as a code owner July 15, 2025 09:00
@melvin-bot melvin-bot bot requested a review from deetergp July 15, 2025 09:00
Copy link

melvin-bot bot commented Jul 15, 2025

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team July 15, 2025 09:00
@MonilBhavsar MonilBhavsar changed the title Revert "[NO QA] Console error displayed on date selection for per-diem expenses" [CP Staging] Revert "[NO QA] Console error displayed on date selection for per-diem expenses" Jul 15, 2025
@MonilBhavsar MonilBhavsar merged commit da74f7c into main Jul 15, 2025
19 of 23 checks passed
@MonilBhavsar MonilBhavsar deleted the revert-65807-fix/65736 branch July 15, 2025 09:05
@melvin-bot melvin-bot bot added the Emergency label Jul 15, 2025
Copy link

melvin-bot bot commented Jul 15, 2025

@MonilBhavsar looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@MonilBhavsar
Copy link
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Jul 15, 2025
[CP Staging] Revert "[NO QA] Console error displayed on date selection for per-diem expenses"

(cherry picked from commit da74f7c)

(cherry-picked to staging by Beamanator)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 15, 2025
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.1.81-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CP Staging marks PRs that have been CP'd to staging Ready To Build
Projects
None yet
3 participants