Render ChatBubbleCell only if it's needed #65570

sosek108 · 2025-07-07T15:10:55Z

Explanation of Change

This PR removes ChatBubbleCell rendering from TransactionItemRow component if the provided columns property lacks CONST.REPORT.TRANSACTION_LIST.COLUMNS.COMMENTS entry.

Fixed Issues

$ #65926
PROPOSAL: #65926

Tests

The modified component is used in two places:

on Reports page
on summary of Report that have at least two transactions

Ensure that testing account has multiple reports and at least one report with multiple transactions

Reports page validation

Open mobile version application
Go to Reports page
Ensure there is no error in JS console

Regressions

Open mobile version application
Open a report with at least of 2 transactions
Open one of transactions
Add at least one comment to that trasaction
Return to the report view
Ensure that chat bubble is presented on commented transaction

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

The modified component is used in two places:

on Reports page
on summary of Report that have at least two transactions

Ensure that testing account has multiple reports and at least one report with multiple transactions

Reports page validation

Open mobile version application
Go to Reports page
Ensure there is no error in JS console

Regressions

Open mobile version application
Open a report with at least of 2 transactions
Open one of transactions
Add at least one comment to that trasaction
Return to the report view
Ensure that chat bubble is presented on commented transaction

See iOS mWeb Safari screenshots for reference

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-07-11T12:00:59Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-07-11T12:02:25Z

@sosek108
Do you need help with a review ?
And we have eslint issues !

sosek108 · 2025-07-11T12:04:44Z

@ZhenjaHorbach Issues already resolved :) PR is ready for review

ZhenjaHorbach · 2025-07-11T12:15:21Z

src/components/TransactionItemRow/index.tsx

@@ -382,6 +382,9 @@ function TransactionItemRow({
        ],
    );
    const safeColumnWrapperStyle = columnWrapperStyles ?? [styles.p3, styles.expenseWidgetRadius];
+    const shouldRenderChatBubbleCell = useMemo(() => {
+        return columns?.includes(CONST.REPORT.TRANSACTION_LIST.COLUMNS.COMMENTS) ?? false;
+    }, [columns]);
    return (


Minor comment
But let's add an empty line before return

Damn
Now we have TS issues 😅

But it's not our issues
Let's try to update a branch to the latest version of main

ZhenjaHorbach · 2025-07-11T12:23:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2025-07-11.17.36.42.mov

Android: mWeb Chrome

2025-07-11.17.36.42.mov

iOS: HybridApp

2025-07-11.17.22.29.mov

iOS: mWeb Safari

2025-07-11.17.27.17.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

ZhenjaHorbach · 2025-07-11T15:53:23Z

LGTM !

OSBotify · 2025-07-14T11:59:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-15T03:22:05Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Render ChatBubbleCell only if it's needed

a387c1e

sosek108 marked this pull request as ready for review July 11, 2025 12:00

sosek108 requested a review from a team as a code owner July 11, 2025 12:00

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team July 11, 2025 12:00

Merge branch 'main' into perf/optimize-chat-bubble-cell-rendering

18066f3

Eslint fixes

3d084de

sosek108 mentioned this pull request Jul 11, 2025

Do not render ChatBubbleCell when not displayed #65926

Open

ZhenjaHorbach reviewed Jul 11, 2025

View reviewed changes

Small code cleanup

7dc54b3

mountiny assigned sosek108 Jul 11, 2025

Merge branch 'main' into perf/optimize-chat-bubble-cell-rendering

a67eb54

ZhenjaHorbach approved these changes Jul 11, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny July 11, 2025 15:53

mountiny approved these changes Jul 14, 2025

View reviewed changes

mountiny merged commit c23f62e into Expensify:main Jul 14, 2025
18 checks passed

github-actions bot mentioned this pull request Jul 15, 2025

Deploy Checklist: New Expensify 2025-07-15 #66099

Open

91 tasks

BlameGPT mentioned this pull request Jul 15, 2025

Chat - Unable to open context menu by right clicking on the message/expense preview #66102

Closed

8 tasks

fabioh8010 mentioned this pull request Jul 15, 2025

Investigate open report slowness in ios for Jasons account #64828

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Render ChatBubbleCell only if it's needed #65570

Render ChatBubbleCell only if it's needed #65570

Uh oh!

sosek108 commented Jul 7, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Jul 11, 2025

Uh oh!

ZhenjaHorbach commented Jul 11, 2025 •

edited

Loading

Uh oh!

sosek108 commented Jul 11, 2025

Uh oh!

ZhenjaHorbach Jul 11, 2025

Uh oh!

sosek108 Jul 11, 2025

Uh oh!

ZhenjaHorbach Jul 11, 2025 •

edited

Loading

Uh oh!

ZhenjaHorbach Jul 11, 2025 •

edited

Loading

Uh oh!

ZhenjaHorbach commented Jul 11, 2025 •

edited

Loading

Uh oh!

ZhenjaHorbach commented Jul 11, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 14, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

Uh oh!

Render ChatBubbleCell only if it's needed #65570

Render ChatBubbleCell only if it's needed #65570

Uh oh!

Conversation

sosek108 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Reports page validation

Regressions

Offline tests

QA Steps

Reports page validation

Regressions

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 11, 2025

Uh oh!

ZhenjaHorbach commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sosek108 commented Jul 11, 2025

Uh oh!

ZhenjaHorbach Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

sosek108 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jul 11, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 14, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

Uh oh!

sosek108 commented Jul 7, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 11, 2025 •

edited

Loading

ZhenjaHorbach Jul 11, 2025 •

edited

Loading

ZhenjaHorbach Jul 11, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 11, 2025 •

edited

Loading