-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Multi-Scan] Delete the draft transaction when deleting a receipt while creating expenses in bulk with Multi-Scan #65565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cristipaval
merged 2 commits into
Expensify:main
from
callstack-internal:VickyStash/bugfix/65252-fix-receipt-delete
Jul 9, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: After deleting the first WS, category + description aren't cleared Screen.Recording.2025-07-08.at.10.51.43.mov |
Fixed! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-07-08.at.18.11.40.movAndroid: mWeb ChromeScreen.Recording.2025-07-08.at.18.00.16.moviOS: HybridAppiOS: mWeb SafariScreenRecording_07-08-2025.18-07-44_1.MP4MacOS: Chrome / SafariScreen.Recording.2025-07-08.at.17.57.02.movMacOS: DesktopScreen.Recording.2025-07-08.at.18.14.26.mov |
dukenv0307
approved these changes
Jul 8, 2025
^^ @cristipaval please take a look at this one 🙂 |
cristipaval
approved these changes
Jul 9, 2025
77 tasks
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.1.79-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.79-11 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
[Multi-Scan] Delete the draft transaction when deleting a receipt while creating expenses in bulk with Multi-Scan
Fixed Issues
$ #65252
PROPOSAL: N/A
Tests
Before testing, make sure you have
newDotMultiScan
beta turned on.Mobile/mWeb:
Offline tests
Same, as in the Tests section
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same, as in the Tests section
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectioncanBeMissing
param foruseOnyx
toggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android_web.mp4