Update should show condition for some violations #65239

nkdengineer · 2025-07-01T09:56:34Z

Explanation of Change

update should show condition for some violations

Fixed Issues

Tests

Precondition: Create a workspace and invite an employee. As an employee, open WS chat and create some expenses

Onyx.update([
    {
        onyxMethod: 'merge',
        key: `transactionViolations_1830582842003588487`,
        value: [
            {
                name: 'autoReportedRejectedExpense',
                data: {
                    rejectedBy: 'John Doe',
                    rejectReason: 'Expense rejected',
                },
                type: 'violation',
            },
            {
                name: 'overAutoApprovalLimit',
                data: {
                    formattedLimit: '$100',
                },
                type: 'violation',
            },
            {
                name: 'rter',
                data: {
                    rterType: 'brokenCardConnection',
                },
                type: 'violation',
            },
            {
                name: 'receiptNotSmartScanned',
                data: {},
                type: 'violation',
            },
        ]
    }
])

autoReportedRejectedExpense violation: should be shown if he user is the report submitter

[Employee]: Open the expense report, open the console, and run this script (replace transactionID with the current ID of the transaction). Verify that the autoReportedRejectedExpense error appears.
[Employee]: Open the Reports page/Search money request and run the script again. Verify that the autoReportedRejectedExpense error also appears.
[Admin]: Do the same step with the employee. Verify that the autoReportedRejectedExpense doesn't appear since it only appears for the submitter

overAutoApprovalLimit: should be shown if the user is an admin of the workspace the report is on. This violation isn't shown to the report submitter since they can't do anything about it

[Employee]: Open the expense report, open the console, and run this script (replace transactionID with the current ID of the transaction). Verify that the overAutoApprovalLimit error doesn't appear.
[Employee]: Open the Reports page/Search money request report and run the script again. Verify that the overAutoApprovalLimit error doesn't appear.
[Admin]: Do the same step with the employee. Verify that the overAutoApprovalLimit appears

rter: should be shown if the user is the submitter, or the workspace is not on instant submit

[Employee]: Open the expense report, open the console, and run this script (replace transactionID with the current ID of the transaction). Verify that the rter error appears.
[Employee]: Open the Reports page/Search money request and run the script again. Verify that the rter error also appears.
[Admin]: Do the same step with the employee. Verify that the rter appears if the workspace isn't instant submit

receiptNotSmartScanned: should be shown if all the following are true: The user has access to the workspace. The user is not the submitter. The user is not a workspace admin or the report isn't open

[Employee]: Submit the expense
[Employee]: Open the expense report, open the console, and run this script (replace transactionID with the current ID of the transaction). Verify that the receiptNotSmartScanned error doesn't appear.
[Employee]: Open the Reports page/Search money request and run the script again. Verify that the receiptNotSmartScanned error also appears.
[Admin]: Do the same step with the employee. Verify that the receiptNotSmartScanned appears

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-07-01.at.16.47.07.mov

Screen.Recording.2025-07-01.at.16.52.52.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-07-01.at.16.47.38.mov

Screen.Recording.2025-07-01.at.16.50.24.mov

iOS: mWeb Safari

Screen.Recording.2025-07-01.at.16.35.24.mov

Screen.Recording.2025-07-01.at.16.37.44.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-01.at.16.30.23.mov

Screen.Recording.2025-07-01.at.16.33.04.mov

MacOS: Desktop

Screen.Recording.2025-07-01.at.16.48.14.mov

Screen.Recording.2025-07-01.at.16.49.10.mov

nkdengineer · 2025-07-01T10:13:15Z

@mananjadhav

I checked all places that we use useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, all places aren't used the violation to display the message so we don't need to change any thing
Other components are using the hook useTransactionViolations to get the violation for special transaction then the change in this hook is enough.
The Android/IOS App crashes when I open the expense report then I only record the result on search page on Android/IOS.

melvin-bot · 2025-07-01T10:13:24Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2025-07-06T18:49:18Z

@nkdengineer The code changes seem fine but in which scenario do we get. The reason I asked is I am working on #52049 (comment) and I am clarifying if such rejection which at the moment is passed in the transaction?.comment itself should be added to the violation.

 {
                name: 'autoReportedRejectedExpense',
                data: {
                    rejectedBy: 'John Doe',
                    rejectReason: 'Expense rejected',
                },
                type: 'violation',
            },

mananjadhav · 2025-07-06T20:44:10Z

The Android/IOS App crashes when I open the expense report then

Is it crashing for you on main as well?

mananjadhav · 2025-07-07T12:08:22Z

Quick bump @nkdengineer

nkdengineer · 2025-07-07T12:11:24Z

) and I am clarifying if such rejection which at the moment is passed in the transaction?.comment itself should be added to the violation.

What do you mean here?

nkdengineer · 2025-07-07T12:11:42Z

Is it crashing for you on main as well?

Yes.

mananjadhav · 2025-07-07T14:22:51Z

) and I am clarifying if such rejection which at the moment is passed in the transaction?.comment itself should be added to the violation.

What do you mean here?

Ignore this one. I've got it answered on the linked issue.

Is it crashing for you on main as well?

Yes.

Can you sync with the latest main and see if it works for you

nkdengineer · 2025-07-07T14:28:55Z

Can you sync with the latest main and see if it works for you

Still crashing.

mananjadhav · 2025-07-09T17:27:20Z

@nkdengineer Are you aware if rejectedBy is sending display name? I am wondering if we need to fix something there in case it sends login email, etc.

Can you please resolve the conflicts?

nkdengineer · 2025-07-10T03:43:47Z

@nkdengineer Are you aware if rejectedBy is sending display name? I am wondering if we need to fix something there in case it sends login email, etc.

@mananjadhav I think it's not a big deal since it's just the mock data for testing.

Can you please resolve the conflicts?

I updated.

mananjadhav · 2025-07-13T08:33:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Valforte

LGTM

OSBotify · 2025-07-14T13:09:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-15T03:21:26Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.1.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

nlemma · 2025-07-15T19:10:06Z

@nkdengineer This PR is failing with this issue.

github-actions · 2025-07-16T19:53:08Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

nkdengineer added 2 commits July 1, 2025 15:58

update should show condition for some violations

c527957

fix canbeMissing

09e9990

nkdengineer marked this pull request as ready for review July 1, 2025 10:13

nkdengineer requested a review from a team as a code owner July 1, 2025 10:13

melvin-bot bot requested review from mananjadhav and removed request for a team July 1, 2025 10:13

Merge branch 'main' into fix/63894

5de9d50

merge main

35aa665

cead22 changed the title ~~update should show condition for some violations~~ Update should show condition for some violations Jul 10, 2025

mananjadhav approved these changes Jul 13, 2025

View reviewed changes

melvin-bot bot requested a review from Valforte July 13, 2025 09:47

Valforte assigned nkdengineer Jul 14, 2025

Valforte approved these changes Jul 14, 2025

View reviewed changes

Valforte merged commit 4668539 into Expensify:main Jul 14, 2025
22 of 23 checks passed

github-actions bot mentioned this pull request Jul 15, 2025

Deploy Checklist: New Expensify 2025-07-15 #66099

Closed

95 tasks

nlemma mentioned this pull request Jul 15, 2025

Reports - Violation errors don't appear on the report page #66204

Closed

8 tasks

Update should show condition for some violations #65239

Update should show condition for some violations #65239

Uh oh!

Conversation

nkdengineer commented Jul 1, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

nkdengineer commented Jul 1, 2025

Uh oh!

melvin-bot bot commented Jul 1, 2025

Uh oh!

mananjadhav commented Jul 6, 2025

Uh oh!

mananjadhav commented Jul 6, 2025

Uh oh!

mananjadhav commented Jul 7, 2025

Uh oh!

nkdengineer commented Jul 7, 2025

Uh oh!

nkdengineer commented Jul 7, 2025

Uh oh!

mananjadhav commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Jul 7, 2025

Uh oh!

mananjadhav commented Jul 9, 2025

Uh oh!

nkdengineer commented Jul 10, 2025

Uh oh!

mananjadhav commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Valforte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 14, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

nlemma commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

Uh oh!

mananjadhav commented Jul 7, 2025 •

edited

Loading

mananjadhav commented Jul 13, 2025 •

edited

Loading