Added frequently used emojis support #6498

mananjadhav · 2021-11-26T18:19:23Z

Details

Added support for Frequently Used Emojis and Recently used emojis
Belongs to a common list and it is synced across sessions with NameValuePairs

Fixed Issues

$ #4559

Tests

Tested adding multiple emojis to recent
Tested emojis by multiple counts (frequency)
Tested by limiting the emoji count and relevant replacement logic in case of more emojis than the given limit
Tested sync across sessions for Frequent Emoji List
Tested preferred skin tone along with frequent emojis

QA Steps

Go to any chat and open EmojPicker
Select your favorite emoji and add it to Text
Open the EmojiPicker again and see it as a part of the Frequently Used Emojis
Add multiple emojis to see that the order is either based on the frequency or recently added emojis

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

…requent-used-emojis

mananjadhav · 2021-11-26T20:24:06Z

@stitesExpensify While my work is done, I've got a regression from the existing main branch, where EmojiPicker has some extra padding on the left.

mananjadhav · 2021-11-26T21:12:42Z

@stitesExpensify I've fixed the above padding issue with a small fix in Popover/index.native.js. Please review that as well.

Jag96 · 2021-11-30T17:45:19Z

@mananjadhav #6523 has fixed the padding issue so if this commit is no longer necessary please remove it

mananjadhav · 2021-11-30T18:34:40Z

@Jag96 yeah it won't be needed I'll take the latest pull of main and remove my commit.

…requent-used-emojis

mananjadhav · 2021-12-01T15:49:31Z

Commit removed and PR updated. @stitesExpensify Any updates for me on this one?

Jag96 · 2021-12-01T22:44:15Z

@stitesExpensify is OOO, assigning pullerbear to get another reviewer on this one

Jag96

Works well! A few requests, will let @stitesExpensify do a final review when he's back from OOO

Jag96 · 2021-12-02T19:24:34Z

src/libs/EmojiUtils.js

@@ -67,9 +70,97 @@ function isSingleEmoji(message) {
    return matchedUnicode === currentMessageUnicode;
 }

+/**
+ * Get the header indices based on the max emojis per row
+ * @param {Array} emojis


Can you specify the array type here? For example {Object[]} or {String[]}. Same for other usages of {Array}

Jag96 · 2021-12-02T19:26:03Z

src/ONYXKEYS.js

@@ -133,6 +133,9 @@ export default {
    // Store preferred skintone for emoji
    PREFERRED_EMOJI_SKIN_TONE: 'preferredEmojiSkinTone',

+    // Store frequently used emojis user wise


nab - Store frequently used emojis for this user

Jag96 · 2021-12-02T19:27:23Z

src/libs/EmojiUtils.js

 import CONST from '../CONST';
+import * as UserActions from './actions/User';


Update UserActions to User to keep consistency with other usages

Jag96 · 2021-12-02T19:36:16Z

src/libs/EmojiUtils.js

+}
+
+/**
+ * Get a merged array if frequently used emojis exist


of instead of if

mananjadhav · 2021-12-03T13:47:10Z

@Jag96 PR updated

Jag96

Just one missed usage, otherwise LGTM

Jag96 · 2021-12-07T00:43:14Z

src/libs/actions/User.js

@@ -317,6 +321,15 @@ function setPreferredSkinTone(skinTone) {
    return NameValuePair.set(CONST.NVP.PREFERRED_EMOJI_SKIN_TONE, skinTone, ONYXKEYS.PREFERRED_EMOJI_SKIN_TONE);
 }

+/**
+ * Sync frequentlyUsedEmojis with Onyx and Server
+ * @param {Array} frequentlyUsedEmojis


Missed an {Array} usage here

Sorry about that. Fixed and updated PR.

Jag96

Thanks @mananjadhav, this LGTM, @stitesExpensify when you get back from OOO feel free to leave a review if there are any follow-ups you'd like addressed.

OSBotify · 2021-12-07T18:46:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

stitesExpensify · 2021-12-07T19:45:29Z

🔥 I didn't review the code but I just tested it and it seems to work great! Thanks for the work @mananjadhav and thanks for taking over the review for me @Jag96 I appreciate it

OSBotify · 2021-12-08T21:09:06Z

🚀 Deployed to staging by @Jag96 in version: 1.1.18-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2021-12-20T12:10:44Z

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav added 8 commits November 21, 2021 05:13

Copied all the functions for utils

9a0efcc

All utility functions updated

477ca6d

Fixed function blocks for first load

065111b

Merge branch 'main' of https://github.com/mananjadhav/App into feat/f…

fc00205

…requent-used-emojis

Fixed imports for functions and the frequent count body

46a5a25

Fixed logic for last Updated count

12974ad

Added the frequent list to the mobile view

ff88d3f

Fixed function call with emoji object

4b853fc

Added withWindowDimensions for Popover/native.js

c27d334

mananjadhav marked this pull request as ready for review November 26, 2021 20:59

mananjadhav requested a review from a team as a code owner November 26, 2021 20:59

botify requested a review from stitesExpensify November 26, 2021 20:59

MelvinBot removed the request for review from a team November 26, 2021 20:59

mananjadhav mentioned this pull request Nov 30, 2021

Chat - Emoticons appear shifted to right and not fully visible #6522

Closed

mananjadhav added 2 commits December 1, 2021 21:01

Revert withWindowDimensions

8946bb1

Merge branch 'main' of https://github.com/mananjadhav/App into feat/f…

8c76fb4

…requent-used-emojis

Jag96 requested a review from a team December 1, 2021 22:44

MelvinBot removed the request for review from a team December 1, 2021 22:44

Jag96 self-requested a review December 1, 2021 22:51

Jag96 reviewed Dec 2, 2021

View reviewed changes

Changed jsdoc and import references

024c4d8

Jag96 suggested changes Dec 7, 2021

View reviewed changes

Changed jsdoc param type

c501a2d

Jag96 approved these changes Dec 7, 2021

View reviewed changes

Jag96 merged commit 04d28af into Expensify:main Dec 7, 2021

OSBotify mentioned this pull request Dec 8, 2021

Deploy Checklist: New Expensify 2021-12-08 #6645

Closed

25 tasks

botify mentioned this pull request Dec 20, 2021

[HOLD for payment 2021-12-27] Add support for Frequently/Recently Used Emojis #4559

Closed

sobitneupane mentioned this pull request Jul 24, 2023

[HOLD for sobit] [$1000] Able to by pass 'Admins only' functionality using :emoji in multiple lines #20827

Closed

6 tasks

		import CONST from '../CONST';
		import * as UserActions from './actions/User';

Added frequently used emojis support #6498

Added frequently used emojis support #6498

Uh oh!

Conversation

mananjadhav commented Nov 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

mananjadhav commented Nov 26, 2021

Uh oh!

mananjadhav commented Nov 26, 2021

Uh oh!

Jag96 commented Nov 30, 2021

Uh oh!

mananjadhav commented Nov 30, 2021

Uh oh!

mananjadhav commented Dec 1, 2021

Uh oh!

Jag96 commented Dec 1, 2021

Uh oh!

Jag96 left a comment

Choose a reason for hiding this comment

Uh oh!

Jag96 Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

Jag96 Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

Jag96 Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

Jag96 Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Dec 3, 2021

Uh oh!

Jag96 left a comment

Choose a reason for hiding this comment

Uh oh!

Jag96 Dec 7, 2021

Choose a reason for hiding this comment

Uh oh!

mananjadhav Dec 7, 2021

Choose a reason for hiding this comment

Uh oh!

Jag96 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Dec 7, 2021

Uh oh!

stitesExpensify commented Dec 7, 2021

Uh oh!

OSBotify commented Dec 8, 2021

Uh oh!

OSBotify commented Dec 20, 2021

Uh oh!

Uh oh!

mananjadhav commented Nov 26, 2021 •

edited

Loading