feat: 64054 Docusign powerforms #64223

MrMuzyk · 2025-06-16T10:02:12Z

Explanation of Change

Implemented an additional step (Step 7) for CAD and AUD accounts that includes upload of docusign powerform signed by user. Other currencies should still have only 6 steps. Values from Step 6 and 7 are saved in BE together.

Fixed Issues

$ #64054
PROPOSAL:

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:
Be on account that has globalReimbursementsOnND beta enabled and doesnt have a + in it's login email

Create new CAD/AUD workspace
Go to workflows and press on Connect bank account
Header should show 7 steps
Proceed to step 6
Accept all agreements and proceed to step 7
Upload a previously downloaded form and finish the flow
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mp4

Android: mWeb Chrome

android.mp4

iOS: Native

ios.native.mp4

iOS: mWeb Safari

ios.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…54-docusign-powerforms

melvin-bot · 2025-07-03T11:39:49Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MrMuzyk · 2025-07-03T11:48:41Z

Hey @hungvu193, in general this is ready for review. The only thing that needs to be sorted out are translations. Im still waiting on copy for subheader on docusign step and then I'll request approval on translations and add them here. From implementation point of view all should be sorted out for now.

hungvu193 · 2025-07-04T16:06:02Z

Sure. Thanks @MrMuzyk

src/pages/ReimbursementAccount/NonUSD/utils/requiresDocusignStep.ts

src/pages/ReimbursementAccount/NonUSD/utils/getOwnerDetailsAndOwnerFilesForBeneficialOwners.ts

MrMuzyk · 2025-07-07T09:17:32Z

I'm still waiting for the remaining texts.

…54-docusign-powerforms

MrMuzyk · 2025-07-09T10:35:55Z

Hey @hungvu193, Im waiting for confirmation of the translations and in the meantime I wanted to ask you if there is anything left here that I have to address? If you don't have any more comments then maybe we can start thinking about merging it soon (once translations are confirmed ofc) 👀

hungvu193 · 2025-07-09T10:37:11Z

Hey @hungvu193, Im waiting for confirmation of the translations and in the meantime I wanted to ask you if there is anything left here that I have to address? If you don't have any more comments then maybe we can start thinking about merging it soon (once translations are confirmed ofc) 👀

All good from my end. I'm only waiting for translation to complete the checklist here 😄

hungvu193 · 2025-07-10T03:00:05Z

@MrMuzyk One thing I noticed was that I couldn't submit successfully because of the BE error. Is this something that we are aware of?

Screen.Recording.2025-07-10.at.09.59.41.mov

MrMuzyk · 2025-07-10T06:12:27Z

Yes, Corpay doesn't accept email addresses with a + anymore. Probably this is what's happening

hungvu193 · 2025-07-10T06:22:48Z

Yes, Corpay doesn't accept email addresses with a + anymore. Probably this is what's happening

Oh I see 🤦 . Sorry I forgot it

MrMuzyk · 2025-07-10T07:05:26Z

@hungvu193 Got a confirmation on translations so PR is all yours now.

hungvu193 · 2025-07-10T07:07:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mChrome.mov

iOS: HybridApp

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Desk.mov

OSBotify · 2025-07-14T14:23:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-15T03:21:11Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.1.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-16T19:52:53Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MrMuzyk added 10 commits June 16, 2025 12:01

feat: 64054 Docusign powerforms

d9a2efc

Merge branch 'main' of https://github.com/Expensify/App into feat/640…

70bcfd7

…54-docusign-powerforms

feat: BE integration

2e295a9

feat: continuation

8b6bfcc

fix: revert permissions change

afc94c9

fix: remove percentage character from payload

5c883c7

fix: add AUD

687872a

Merge branch 'main' of https://github.com/Expensify/App into feat/640…

2d645a4

…54-docusign-powerforms

feat: AUD case

c5559df

fix: aud corrections

697bb97

MrMuzyk marked this pull request as ready for review July 3, 2025 11:39

MrMuzyk requested a review from a team as a code owner July 3, 2025 11:39

melvin-bot bot requested a review from hungvu193 July 3, 2025 11:39

melvin-bot bot removed the request for review from a team July 3, 2025 11:39

hungvu193 reviewed Jul 4, 2025

View reviewed changes

cr fixes

e11f79d

MrMuzyk added 2 commits July 9, 2025 09:26

Merge branch 'main' of https://github.com/Expensify/App into feat/640…

b43d0d5

…54-docusign-powerforms

fix: translations and linter

591b7ce

fix: spanish translation correction

32543a7

hungvu193 approved these changes Jul 10, 2025

View reviewed changes

melvin-bot bot requested a review from madmax330 July 10, 2025 07:08

madmax330 approved these changes Jul 14, 2025

View reviewed changes

madmax330 merged commit 9d4bdc0 into Expensify:main Jul 14, 2025
18 checks passed

github-actions bot mentioned this pull request Jul 15, 2025

Deploy Checklist: New Expensify 2025-07-15 #66099

Closed

95 tasks

BlameGPT mentioned this pull request Jul 15, 2025

iOS - App crashes when user connect bank account in wallet #66147

Closed

8 tasks

feat: 64054 Docusign powerforms #64223

feat: 64054 Docusign powerforms #64223

Uh oh!

Conversation

MrMuzyk commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 3, 2025

Uh oh!

MrMuzyk commented Jul 3, 2025

Uh oh!

hungvu193 commented Jul 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MrMuzyk commented Jul 7, 2025

Uh oh!

MrMuzyk commented Jul 9, 2025

Uh oh!

hungvu193 commented Jul 9, 2025

Uh oh!

hungvu193 commented Jul 10, 2025

Uh oh!

MrMuzyk commented Jul 10, 2025

Uh oh!

hungvu193 commented Jul 10, 2025

Uh oh!

MrMuzyk commented Jul 10, 2025

Uh oh!

hungvu193 commented Jul 10, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jul 14, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

Uh oh!

MrMuzyk commented Jun 16, 2025 •

edited

Loading