-
Notifications
You must be signed in to change notification settings - Fork 3.3k
refactor preventFutureActivity split phrase to use react-native-render-html #63543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor preventFutureActivity split phrase to use react-native-render-html #63543
Conversation
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@PiyushChandra17 please fix failing tests |
@roryabraham can you trigger workflows here please |
@PiyushChandra17 fix reassure test and typechecks tests |
…se/preventFutureActivity
…ity' of https://github.com/PiyushChandra17/App into PiyushChandra17/refactor/splitphrase/preventFutureActivity
@allgandalf Can we start the workflow as early as possible. Thanks |
@allgandalf Can we run the workflow as early as possible |
I've asked to get the worflows running, @PiyushChandra17 please Don't merge main again unless i review it since we need to run the workflows manually everytime |
…andra17/refactor/splitphrase/preventFutureActivity
831ec74
to
8c1d2f3
Compare
@PiyushChandra17 lets fix type errors, we now require translations in all languages , please update all the related files |
…andra17/refactor/splitphrase/preventFutureActivity
d4e741a
to
1cda72c
Compare
@allgandalf I need to check this out |
@allgandalf Yes there's an extra space after the link, will fix it |
@allgandalf Yes i matched with the staging, here's the updated one |
@allgandalf I think i have resolved extra space after the link in all languages, also verified the size matches with staging/production |
@PiyushChandra17 please update screenshots on native platforms, checklist is incomplete |
We have conflicts now here, @PiyushChandra17. Can you fix those and finish the checklist? |
@trjExpensify Sure, i'am at it |
@allgandalf I think with the latest changes in ( |
@allgandalf Also don't you think we can't make changes to subscription in the the mobile app like we cannot tap on the annual subscription part and hence we cannot navigate to preventFutureActivity part |
…se/preventFutureActivity
hmmm, yeah good point, let me take a look once |
@allgandalf Thanks |
…se/preventFutureActivity
@PiyushChandra17 please fix conflicts |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.81-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀
|
Explanation of Change
Fixed Issues
$ #62808
PROPOSAL: #62808 (comment)
Tests
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectioncanBeMissing
param foruseOnyx
toggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop