Skip to content

Update live markdown to fix emoji being formatted #63306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 11 additions & 71 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -438,7 +437,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -455,7 +453,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -474,7 +471,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -492,7 +488,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -510,7 +505,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -528,7 +522,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -546,7 +539,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -564,7 +556,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -582,7 +573,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -600,7 +590,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -618,7 +607,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -636,7 +624,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand All @@ -654,7 +641,6 @@ PODS:
- React-jsiexecutor
- React-jsinspector
- React-perflogger
- React-rendererconsistency
- React-runtimescheduler
- React-utils
- SocketRocket (= 0.7.1)
Expand Down Expand Up @@ -729,7 +715,6 @@ PODS:
- React-Fabric/componentregistry (= 0.77.1)
- React-Fabric/componentregistrynative (= 0.77.1)
- React-Fabric/components (= 0.77.1)
- React-Fabric/consistency (= 0.77.1)
- React-Fabric/core (= 0.77.1)
- React-Fabric/dom (= 0.77.1)
- React-Fabric/imagemanager (= 0.77.1)
Expand Down Expand Up @@ -921,27 +906,6 @@ PODS:
- React-utils
- ReactCommon/turbomodule/core
- Yoga
- React-Fabric/consistency (0.77.1):
- DoubleConversion
- fast_float (= 6.1.4)
- fmt (= 11.0.2)
- glog
- hermes-engine
- RCT-Folly/Fabric (= 2024.11.18.00)
- RCTRequired
- RCTTypeSafety
- React-Core
- React-cxxreact
- React-debug
- React-featureflags
- React-graphics
- React-jsi
- React-jsiexecutor
- React-logger
- React-rendererdebug
- React-runtimescheduler
- React-utils
- ReactCommon/turbomodule/core
- React-Fabric/core (0.77.1):
- DoubleConversion
- fast_float (= 6.1.4)
Expand Down Expand Up @@ -1799,7 +1763,7 @@ PODS:
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- react-native-key-command (1.0.12):
- react-native-key-command (1.0.14):
- DoubleConversion
- glog
- hermes-engine
Expand Down Expand Up @@ -2558,30 +2522,7 @@ PODS:
- RNGoogleSignin (10.0.1):
- GoogleSignIn (~> 7.0)
- React-Core
- RNLiveMarkdown (0.1.244):
- DoubleConversion
- glog
- hermes-engine
- RCT-Folly (= 2024.11.18.00)
- RCTRequired
- RCTTypeSafety
- React-Core
- React-debug
- React-Fabric
- React-featureflags
- React-graphics
- React-ImageManager
- React-NativeModulesApple
- React-RCTFabric
- React-rendererdebug
- React-utils
- ReactCodegen
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- RNLiveMarkdown/newarch (= 0.1.244)
- RNReanimated/worklets
- Yoga
- RNLiveMarkdown/newarch (0.1.244):
- RNLiveMarkdown (0.1.285):
- DoubleConversion
- glog
- hermes-engine
Expand Down Expand Up @@ -3400,8 +3341,8 @@ SPEC CHECKSUMS:
AirshipServiceExtension: 9c73369f426396d9fb9ff222d86d842fac76ba46
AppAuth: 501c04eda8a8d11f179dbe8637b7a91bb7e5d2fa
AppLogs: 3bc4e9b141dbf265b9464409caaa40416a9ee0e0
boost: d7090b1a93a9798c029277a8288114f2948f471c
DoubleConversion: f16ae600a246532c4020132d54af21d0ddb2a385
boost: 7e761d76ca2ce687f7cc98e698152abd03a18f90
DoubleConversion: cb417026b2400c8f53ae97020b2be961b59470cb
EXAV: 57ea461614a714b8b8fcc72c6fbc298b8f1ec78b
EXImageLoader: 759063a65ab016b836f73972d3bb25404888713d
expensify-react-native-background-task: f180077e77a41952128fdc2c83ce1d980994d125
Expand All @@ -3426,7 +3367,7 @@ SPEC CHECKSUMS:
ForkInputMask: 55e3fbab504b22da98483e9f9a6514b98fdd2f3c
FullStory: c8a10b2358c0d33c57be84d16e4c440b0434b33d
fullstory_react-native: 5132c9dfa5e1ea4ec42679a708af782d4c4ec4bc
glog: 08b301085f15bcbb6ff8632a8ebaf239aae04e6a
glog: eb93e2f488219332457c3c4eafd2738ddc7e80b8
GoogleAppMeasurement: 5ba1164e3c844ba84272555e916d0a6d3d977e91
GoogleDataTransport: 6c09b596d841063d76d4288cc2d2f42cc36e1e2a
GoogleSignIn: d4281ab6cf21542b1cfaff85c191f230b399d2db
Expand Down Expand Up @@ -3459,13 +3400,13 @@ SPEC CHECKSUMS:
RCTTypeSafety: 031cefa254a1df313a196f105b8fcffdab1c5ab6
React: 8edfc46c315852ec88ea4a29d5e79019af3dc667
React-callinvoker: 4450b01574dfc7a8f074f7e29e6965ac04859c8f
React-Core: 0ac3acde025b10da5ccb9970547ab60a863654ce
React-Core: 13bdd0a0125fdaecdee747b62e02d2a65b026520
React-CoreModules: ebe93fa403bbd4d0909de105ffd34eeaad355083
React-cxxreact: af8a2be3edfed0e1168279eea443f95a7285602e
React-debug: b0f7271aeacc2eb9e34f863397dcfc204ef721c0
React-defaultsnativemodule: 2ad21fff895dabfb7db60ee1c37d0a3866229430
React-domnativemodule: f788e7169988a61ac38a5fc493ac02b5fbda7d6b
React-Fabric: 012ec12475cf941575871fdc006cf934090a9840
React-Fabric: 8b404451db2bb07bcf0e3f6dfebfb26455e4d7ce
React-FabricComponents: 40cecebced128b2aa50c25a5fa6fdcd3b175286d
React-FabricImage: 81787fa643b67f1327b4aa5fa1678dc73a771e34
React-featureflags: 23d3dcdac6c9badeeb631db8a0883c7a3108d580
Expand All @@ -3491,7 +3432,7 @@ SPEC CHECKSUMS:
react-native-document-picker: ead1d62b121e66ab5edbf6fcfdbfb58e81662b55
react-native-geolocation: cd91e4fd914de585933c836fd71f6bdb3c97a410
react-native-image-picker: 9e419813377d42566b0168121ab9483614488db5
react-native-key-command: 96c9dfb09bc89ecd1d58348c0d3ed84d0255648b
react-native-key-command: 8e0e438fd6bba404cff79ab43d131e5187e45f73
react-native-keyboard-controller: 5c628f5d8301047a87039a2d7de322233a39bbda
react-native-launch-arguments: 5f41e0abf88a15e3c5309b8875d6fd5ac43df49d
react-native-netinfo: eb0dfd4450b6f825eea973c490cee45db21cf570
Expand All @@ -3503,11 +3444,10 @@ SPEC CHECKSUMS:
react-native-safe-area-context: 9b169299f9dc95f1d7fe1dd266fde53bd899cd0c
react-native-view-shot: bb169342812ded991a4a0387e7d0b17cb515e62a
react-native-wallet: 46df147c6089b2490dc5f4cbf25c58ce70b0215d
react-native-webrtc: 0f1c94069ff1eb9d8fb1618c2dc71f73542c8cfa
react-native-webview: b375842af66a9f0ab979378bdc8b26eeb5d8e3ee
React-nativeconfig: cb207ebba7cafce30657c7ad9f1587a8f32e4564
React-NativeModulesApple: 82a8bee52df9f5b378195a500f22be3a6ef0f890
React-perflogger: a8a27aa65a47f740eff65bb38b79baacb38a50d5
React-perflogger: 8152bab3f0eb4b8751f282f9af7caed2c823a9ea
React-performancetimeline: 3ef4a640b56f9c7ec5f52bd93217b9b607c37cf4
React-RCTActionSheet: 0fdf55fb8724856d63ca8c63cdb4e2325e15e8ec
React-RCTAnimation: b93f5a1675cc2599e96851fec13c909fdfb1d6bb
Expand All @@ -3521,7 +3461,7 @@ SPEC CHECKSUMS:
React-RCTSettings: 433c9f6a070bcecbe5a44d5009326b4d6f3b0667
React-RCTText: 46249950f8d8738b90a60883d19b5bef09f0a296
React-RCTVibration: 8f41e85ab6d40c7db6111ca9e8c7492c8de374fb
React-rendererconsistency: d59654ad59217708509d1bb6373358be321613a4
React-rendererconsistency: c766ce7261ab6ed6be7bc155c403e29436d4f156
React-rendererdebug: 1f619b295f346242842f3accee23e8394b995d3c
React-rncore: cafe45e14d870bbecbbf4bd89e12ef3b596e1f2d
React-RuntimeApple: 7f27fb75a37e00a8e1efaa6e8f7a5b653871fb1b
Expand All @@ -3547,7 +3487,7 @@ SPEC CHECKSUMS:
RNFS: 4ac0f0ea233904cb798630b3c077808c06931688
RNGestureHandler: 66e593addd8952725107cfaa4f5e3378e946b541
RNGoogleSignin: ccaa4a81582cf713eea562c5dd9dc1961a715fd0
RNLiveMarkdown: e3f49ff5a70a7fb5ba515a390cae767e5e999ac9
RNLiveMarkdown: 6284a4e9dd2522c17bc42175e6747b7f38c11591
RNLocalize: d4b8af4e442d4bcca54e68fc687a2129b4d71a81
rnmapbox-maps: 1d313fe5d7d18845b3015ffd6994e0c81afbffcd
RNNitroSQLite: 0243d91c6662d8a334fb4953c969b82884ac6c68
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"@dotlottie/react-player": "^1.6.3",
"@expensify/react-native-background-task": "file:./modules/background-task",
"@expensify/react-native-hybrid-app": "file:./modules/hybrid-app",
"@expensify/react-native-live-markdown": "0.1.280",
"@expensify/react-native-live-markdown": "0.1.285",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to 0.1.286

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not the version that would unblock the rn upgrade, right? If yes, then we can do that on a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally sure but it's the version I'm upgrading to in Mobile-Expensify and eventually we will update to that version anyway

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1.284 is the one that will unblock the RN upgrade but I agree with @s77rt that we would have to update to it anyway

However, it potentially could introduce some regressions so it'll be safer to update to 85
I'll let you decide because I don't have a strong opinion on that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, it potentially could introduce some regressions so it'll be safer to update to 85

This is my concern. We are already 41 versions ahead of main 😅

"@expensify/react-native-wallet": "file:modules/expensify-react-native-wallet.tgz",
"@expo/metro-runtime": "^4.0.1",
"@firebase/app": "^0.10.10",
Expand Down
Loading