Skip to content

[HOLD][CP Staging] Hide create report button #62690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[HOLD][CP Staging] Hide create report button #62690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da4a76c
hide create report button
luacmartins May 23, 2025
50c4205
fix lint
luacmartins May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 43 additions & 34 deletions src/libs/SearchUIUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type {TextStyle, ViewStyle} from 'react-native';
import Onyx from 'react-native-onyx';
import type {OnyxCollection} from 'react-native-onyx';
import type {OnyxCollection, OnyxEntry} from 'react-native-onyx';
import type {ValueOf} from 'type-fest';
import DotLottieAnimations from '@components/LottieAnimations';
import type DotLottieAnimation from '@components/LottieAnimations/types';
Expand Down Expand Up @@ -40,6 +40,7 @@ import {formatPhoneNumber} from './LocalePhoneNumber';
import {translateLocal} from './Localize';
import Navigation from './Navigation/Navigation';
import Parser from './Parser';
import Permissions from './Permissions';
import {getDisplayNameOrDefault} from './PersonalDetailsUtils';
import {getActivePolicy, getGroupPaidPoliciesWithExpenseChatEnabled, getPolicy, isPaidGroupPolicy} from './PolicyUtils';
import {getOriginalMessage, isCreatedAction, isDeletedAction, isMoneyRequestAction, isResolvedActionableWhisper, isWhisperActionTargetedToOthers} from './ReportActionsUtils';
Expand Down Expand Up @@ -98,6 +99,12 @@ Onyx.connect({
},
});

let betas: OnyxEntry<OnyxTypes.Beta[]>;
Onyx.connect({
key: ONYXKEYS.BETAS,
callback: (value) => (betas = value),
});

const emptyPersonalDetails = {
accountID: CONST.REPORT.OWNER_ACCOUNT_ID_FAKE,
avatar: '',
Expand Down Expand Up @@ -989,39 +996,41 @@ function createTypeMenuSections(session: OnyxTypes.Session | undefined, policies
headerMedia: DotLottieAnimations.Fireworks,
title: 'search.searchResults.emptySubmitResults.title',
subtitle: 'search.searchResults.emptySubmitResults.subtitle',
buttons: [
{
success: true,
buttonText: 'report.newReport.createReport',
buttonAction: () => {
interceptAnonymousUser(() => {
const activePolicy = getActivePolicy();
const groupPoliciesWithChatEnabled = getGroupPaidPoliciesWithExpenseChatEnabled();
const personalDetails = getPersonalDetailsForAccountID(session.accountID) as OnyxTypes.PersonalDetails;

let workspaceIDForReportCreation: string | undefined;

// If the user's default workspace is a paid group workspace with chat enabled, we create a report with it by default
if (activePolicy && activePolicy.isPolicyExpenseChatEnabled && isPaidGroupPolicy(activePolicy)) {
workspaceIDForReportCreation = activePolicy.id;
} else if (groupPoliciesWithChatEnabled.length === 1) {
workspaceIDForReportCreation = groupPoliciesWithChatEnabled.at(0)?.id;
}

if (workspaceIDForReportCreation && !shouldRestrictUserBillableActions(workspaceIDForReportCreation) && personalDetails) {
const createdReportID = createNewReport(personalDetails, workspaceIDForReportCreation);
Navigation.setNavigationActionToMicrotaskQueue(() => {
Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()}));
});
return;
}

// If the user's default workspace is personal and the user has more than one group workspace, which is paid and has chat enabled, or a chosen workspace is past the grace period, we need to redirect them to the workspace selection screen
Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION);
});
},
},
],
buttons: Permissions.canUseTableReportView(betas)
? [
{
success: true,
buttonText: 'report.newReport.createReport',
buttonAction: () => {
interceptAnonymousUser(() => {
const activePolicy = getActivePolicy();
const groupPoliciesWithChatEnabled = getGroupPaidPoliciesWithExpenseChatEnabled();
const personalDetails = getPersonalDetailsForAccountID(session.accountID) as OnyxTypes.PersonalDetails;

let workspaceIDForReportCreation: string | undefined;

// If the user's default workspace is a paid group workspace with chat enabled, we create a report with it by default
if (activePolicy && activePolicy.isPolicyExpenseChatEnabled && isPaidGroupPolicy(activePolicy)) {
workspaceIDForReportCreation = activePolicy.id;
} else if (groupPoliciesWithChatEnabled.length === 1) {
workspaceIDForReportCreation = groupPoliciesWithChatEnabled.at(0)?.id;
}

if (workspaceIDForReportCreation && !shouldRestrictUserBillableActions(workspaceIDForReportCreation) && personalDetails) {
const createdReportID = createNewReport(personalDetails, workspaceIDForReportCreation);
Navigation.setNavigationActionToMicrotaskQueue(() => {
Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()}));
});
return;
}

// If the user's default workspace is personal and the user has more than one group workspace, which is paid and has chat enabled, or a chosen workspace is past the grace period, we need to redirect them to the workspace selection screen
Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION);
});
},
},
]
: undefined,
},
getSearchQuery: () => {
const queryString = buildQueryStringFromFilterFormValues({
Expand Down