Skip to content

[CP Staging] Align primary/search action logic #62237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 19, 2025
Merged

[CP Staging] Align primary/search action logic #62237

merged 5 commits into from
May 19, 2025
+18 −2

Conversation

luacmartins
Copy link
Contributor

Explanation of Change

The logic in getAction for Search will eventually be replaced by getReportPreviewAction. In the meantime though, we need to align the logic in both functions so they behave similarly. This PR adds a check for manual submit being enabled

Fixed Issues

$ #62152

Tests

  1. Sign up with a new account.
  2. Complete onboarding modal selecting "Track and budget expenses" option.
  3. Once redirected to inbox, tap on FAB and select "Create Expense"
  4. Complete the creation flow and submit it to Self DM.
  5. Tap on "Share with my accountant" option below expense preview.
  6. Add an accountant.
  7. Add a merchant and category and submit expense.
  8. Note that expense preview on chat, displays a "View" button.
  9. Navigate to "Reports"
  10. Verify that the same expense, displays "View" button.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2025-05-16.at.1.06.57.PM.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@luacmartins luacmartins self-assigned this May 16, 2025
@luacmartins luacmartins marked this pull request as ready for review May 16, 2025 19:07
@luacmartins luacmartins requested a review from a team as a code owner May 16, 2025 19:07
@melvin-bot melvin-bot bot requested review from hoangzinh and removed request for a team May 16, 2025 19:07
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 16, 2025

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@hoangzinh
Copy link
Contributor

Somehow, the unit test and prettier are failing @luacmartins

@hoangzinh
Copy link
Contributor

hoangzinh commented May 17, 2025 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2025-05-20.at.00.21.55.android.mov
Android: mWeb Chrome
Screen.Recording.2025-05-20.at.00.24.53.android.chrome.mov
iOS: HybridApp
iOS: mWeb Safari
Screen.Recording.2025-05-20.at.00.32.15.ios.safari.mov
MacOS: Chrome / Safari

Screenshot 2025-05-20 at 00 15 20

MacOS: Desktop
Screen.Recording.2025-05-20.at.00.17.10.desktop.mov

@hoangzinh
Copy link
Contributor

Can you test your fix again? @luacmartins It still shows "Submit" button for me, but it's gone when I turn on Workflow and turn off it.

Screen.Recording.2025-05-17.at.16.32.10.mov

@luacmartins
Copy link
Contributor Author

I fixed tests and prettier. @hoangzinh the fix seems to be working for me

Screen.Recording.2025-05-19.at.8.31.34.AM.mov

@hoangzinh
Copy link
Contributor

Let me test again. Btw, there is a failed unit test

@hoangzinh
Copy link
Contributor

@luacmartins I still see "Submit" button in reports view. I found that my workspace is auto created with policy.harvesting.enabled: true, thus it will return "immediate" here

App/src/libs/PolicyUtils.ts

Lines 493 to 496 in e65db2e

if (policy?.harvesting?.enabled) {
// This is actually not really "immediate". It's "daily". Surprise!
return CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE;
}

Screenshot 2025-05-19 at 21 58 40

Screen.Recording.2025-05-19.at.21.57.02.mov

@hoangzinh
Copy link
Contributor

Is it related to email domain?

@hoangzinh
Copy link
Contributor

hoangzinh commented May 19, 2025 •
edited
Loading

Oh wait, is it because Search API doesn't return policy.harvesting.enabled?

Screenshot 2025-05-19 at 22 30 40

@luacmartins
Copy link
Contributor Author

luacmartins commented May 19, 2025 •
edited
Loading

@hoangzinh ah yes, sorry that is still waiting a deploy. It should be deployed today.

@luacmartins
Copy link
Contributor Author

luacmartins commented May 19, 2025 •
edited
Loading

@hoangzinh the BE changes should be deployed. Please test again

@hoangzinh
Copy link
Contributor

Was it deployed @luacmartins. I can see the "View" btn right now.

@luacmartins
Copy link
Contributor Author

Haha we just posted at the same time. Yes, the BE changes are deployed

@hoangzinh
Copy link
Contributor

@luacmartins I tested on most platforms, but I had a problem with IOS build. However, I believe it's a cross-platform fix and given it's a DB fix. Thus, I will give a green light here.

@melvin-bot melvin-bot bot requested a review from srikarparsi May 19, 2025 17:54
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 19, 2025

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@srikarparsi srikarparsi merged commit e240fd8 into main May 19, 2025
21 checks passed
@srikarparsi srikarparsi deleted the cmartins-fixReportActions branch May 19, 2025 19:13
@luacmartins luacmartins changed the title Align primary/search action logic [CP Staging] Align primary/search action logic May 19, 2025
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request May 19, 2025
@srikarparsi @OSBotify
Merge pull request #62237 from Expensify/cmartins-fixReportActions
3e154ca 
Align primary/search action logic

(cherry picked from commit e240fd8)

(cherry-picked to staging by arosiclair)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label May 19, 2025
@github-actions github-actions bot mentioned this pull request May 19, 2025
Open
87 tasks
@luacmartins luacmartins mentioned this pull request May 19, 2025
Open
51 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.1.46-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

Performance Comparison Report 📊 (1/3)

⚠️ Some tests did not pass successfully, so some results are omitted from final report: Open search router TTI, Linking, Money request

Significant Changes To Duration

Name Duration
App start time TTI 1455.272 ms → 1562.057 ms (+106.785 ms, +7.3%) 🔴
Show details
Name Duration
App start time TTI Baseline
Mean: 1455.272 ms
Stdev: 248.327 ms (17.1%)
Runs: 1101.155112999957 1130.0116759999655 1143.758218999952 1146.4610999999568 1163.3468120000325 1173.5260879998095 1184.1295940000564 1187.8475040001795 1191.44333499996 1203.2420210000128 1212.5702920001931 1218.0656510000117 1219.1495300000533 1220.0016520000063 1220.2983570001088 1220.6686809998937 1222.7313919998705 1223.9471579999663 1225.067853000015 1232.5515180001967 1233.5118490001187 1243.671035000123 1247.8260160000063 1248.0281580002047 1253.5385150001384 1260.6953619997948 1261.3933210000396 1262.5273170000874 1268.2062070001848 1268.2109500002116 1544.905499999877 1597.2886419999413 1604.0552880000323 1623.6477749999613 1637.2119120000862 1642.0873170001432 1650.8499289997853 1656.2158530000597 1656.7677710000426 1671.0479799997993 1671.452827999834 1673.679793999996 1676.3352500000037 1684.3594999997877 1685.9151389999315 1708.913984999992 1710.7135270000435 1713.675385999959 1716.7868260000832 1717.9937909999862 1719.6438560001552 1742.355911000166 1750.7707190001383 1761.2278160001151 1763.9618529998697 1771.0438359999098 1773.9236980001442 1780.7174720000476 1799.3154159998521 1821.8734519998543

Current
Mean: 1562.057 ms
Stdev: 252.939 ms (16.2%)
Runs: 1138.684315000195 1194.6354829999618 1206.86868399987 1213.125549999997 1249.3446909999475 1251.7105859997682 1253.9488880001009 1256.7851590001956 1269.0605560000986 1276.4054410001263 1281.1598890000023 1283.0394810000435 1285.2432749997824 1286.2625460000709 1286.8982080002315 1292.3127959999256 1294.90818199981 1299.5623590000905 1300.6158170001581 1307.9102380000986 1317.597850999795 1320.7293239999563 1330.0964930001646 1348.702227000147 1350.587633000221 1380.3159619998187 1632.9373300001025 1644.5387240001 1656.8800690001808 1675.4228920000605 1706.5851489999332 1709.9154130001552 1735.1809910000302 1738.2917590001598 1751.340689000208 1761.7590020000935 1769.3812939999625 1775.336749999784 1781.0438979999162 1783.4419320002198 1790.0848520002328 1792.797869999893 1793.4715419998392 1795.4771389998496 1796.4518289999105 1797.6462980001234 1800.995525999926 1801.3660969999619 1804.1457310002297 1805.6933969999664 1809.195884999819 1816.002613000106 1819.2694839998148 1828.4769520000555 1830.2543770000339 1832.352132000029 1845.8282220000401 1849.2110890001059 1851.0316519998014 1865.0956020001322

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label May 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

Performance Comparison Report 📊 (2/3)

Meaningless Changes To Duration (1/2)

Show entries
Name Duration
App start time nativeLaunch 34.966 ms → 25.966 ms (-9.000 ms, -25.7%) 🟢
App start time appCreation 64.136 ms → 73.833 ms (+9.698 ms, +15.1%) 🟡
App start time nativeLaunchEnd_To_appCreationStart 62.759 ms → 84.450 ms (+21.691 ms, +34.6%) 🟡
App start time appCreationEnd_To_contentAppeared 458.200 ms → 497.450 ms (+39.250 ms, +8.6%)
App start time contentAppeared_To_screenTTI 833.489 ms → 880.090 ms (+46.602 ms, +5.6%)
App start time runJsBundle 303.169 ms → 329.397 ms (+26.227 ms, +8.7%)
App start time regularAppStart 0.021 ms → 0.021 ms (-0.000 ms, -0.9%)
App start time (CPU) 150.650 % → 150.731 % (+0.080 %, ±0.0%)
App start time (FPS) 60.000 FPS → 60.000 FPS
App start time (RAM) 362.127 MB → 361.633 MB (-0.494 MB, ±0.0%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 28.703 % → 26.788 % (-1.915 %, -6.7%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 373.676 ms → 367.990 ms (-5.687 ms, -1.5%)
Report typing (CPU) 97.711 % → 96.588 % (-1.123 %, -1.1%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 443.481 MB → 442.127 MB (-1.354 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 20.631 % → 20.728 % (+0.097 %, ±0.0%)
Chat opening Chat TTI 854.668 ms → 754.935 ms (-99.733 ms, -11.7%)
Chat opening (CPU) 161.396 % → 162.510 % (+1.114 %, +0.7%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 382.774 MB → 383.227 MB (+0.454 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 31.717 % → 32.193 % (+0.476 %, +1.5%)
Show details
Name Duration
App start time nativeLaunch Baseline
Mean: 34.966 ms
Stdev: 5.511 ms (15.8%)
Runs: 27 28 28 28 28 28 28 28 28 29 30 30 30 30 31 31 31 31 31 32 32 32 32 32 33 33 33 34 34 34 35 35 35 35 35 35 36 36 37 37 37 38 38 38 39 39 39 40 41 41 42 42 42 43 44 45 47 48 48

Current
Mean: 25.966 ms
Stdev: 4.141 ms (15.9%)
Runs: 21 21 21 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 25 25 25 25 26 26 26 26 26 26 27 27 28 28 28 29 29 29 30 30 30 31 31 31 32 34 35 35 37 37
App start time appCreation Baseline
Mean: 64.136 ms
Stdev: 9.837 ms (15.3%)
Runs: 49 50 50 50 50 51 52 53 53 54 54 55 56 57 58 58 58 58 59 59 60 60 60 61 61 61 61 61 62 62 62 63 63 64 65 65 65 66 67 67 67 69 70 70 71 71 71 74 75 75 75 78 78 79 79 83 85 85 89

Current
Mean: 73.833 ms
Stdev: 10.197 ms (13.8%)
Runs: 51 51 60 60 61 61 62 62 62 63 64 65 67 67 67 67 67 68 68 68 68 69 69 70 70 71 71 71 72 72 72 74 74 75 75 76 76 77 78 78 79 80 80 81 82 83 83 83 84 84 84 84 84 87 87 90 92 93 95 96
App start time nativeLaunchEnd_To_appCreationStart Baseline
Mean: 62.759 ms
Stdev: 9.738 ms (15.5%)
Runs: 44 47 47 48 52 52 52 52 53 53 54 55 55 55 56 57 57 58 58 58 58 58 59 60 60 60 61 61 61 62 62 62 62 63 64 64 65 65 65 66 67 67 67 67 68 69 69 70 72 74 76 76 80 83 83 83 84 84

Current
Mean: 84.450 ms
Stdev: 12.837 ms (15.2%)
Runs: 63 63 64 66 68 68 68 68 69 70 71 71 72 73 75 76 77 78 79 79 79 79 80 80 81 81 82 82 83 83 83 83 83 84 85 87 89 89 90 90 91 91 92 92 93 93 95 95 95 96 96 96 97 98 100 103 104 113 117 119
App start time appCreationEnd_To_contentAppeared Baseline
Mean: 458.200 ms
Stdev: 46.019 ms (10.0%)
Runs: 335 378 382 383 402 405 405 407 408 411 413 414 414 418 420 420 422 422 422 427 428 431 437 438 444 446 462 464 465 466 471 471 472 473 474 474 478 478 478 478 479 483 484 489 493 495 501 501 501 502 505 506 513 514 515 515 530 542 542 546

Current
Mean: 497.450 ms
Stdev: 50.465 ms (10.1%)
Runs: 380 403 410 414 420 423 438 443 444 449 454 454 456 456 457 459 462 463 466 467 470 471 474 477 481 482 485 487 488 493 497 504 510 512 512 516 518 519 523 526 529 530 531 534 534 538 543 543 547 550 561 561 563 564 567 570 576 577 580 586
App start time contentAppeared_To_screenTTI Baseline
Mean: 833.489 ms
Stdev: 250.156 ms (30.0%)
Runs: 493.7582189999521 514.4433349999599 519.9471579999663 530.067853000015 537.0016520000063 537.5260879998095 538.2420210000128 550.8475040001795 551.3933210000396 555.5118490001187 562.1495300000533 577.155112999957 586.0116759999655 590.5273170000874 591.0281580002047 594.7313919998705 598.6686809998937 600.5702920001931 607.5385150001384 608.4610999999568 614.3468120000325 618.2983570001088 619.2062070001848 631.5515180001967 634.0656510000117 638.6953619997948 647.1295940000564 669.6710350001231 676.8260160000063 679.2109500002116 983.8499289997853 1001.2119120000862 1009.0873170001432 1015.9054999998771 1016.0552880000323 1029.7677710000426 1038.452827999834 1039.2886419999413 1039.6477749999613 1040.7135270000435 1048.6438560001552 1050.3594999997877 1052.9937909999862 1056.355911000166 1056.9151389999315 1059.2158530000597 1067.913984999992 1072.2278160001151 1087.0479799997993 1092.3352500000037 1095.679793999996 1100.9618529998697 1103.7707190001383 1133.7868260000832 1144.9236980001442 1154.675385999959 1168.0438359999098 1177.7174720000476 1193.3154159998521 1203.8734519998543

Current
Mean: 880.090 ms
Stdev: 245.661 ms (27.9%)
Runs: 541.9488880001009 542.3446909999475 545.7105859997682 548.684315000195 551.0394810000435 553.7851590001956 558.6354829999618 564.125549999997 567.1598890000023 578.4054410001263 585.5623590000905 592.5876330002211 603.7022270001471 612.0605560000986 614.3127959999256 615.9102380000986 622.6158170001581 625.2625460000709 630.8982080002315 632.2432749997824 634.86868399987 659.90818199981 666.7293239999563 674.5978509997949 677.0964930001646 715.3159619998187 971.9154130001552 1026.1809910000302 1042.8800690001808 1044.4771389998496 1044.5387240001 1048.5851489999332 1049.9373300001025 1051.995525999926 1054.4769520000555 1057.2543770000339 1065.002613000106 1065.0848520002328 1068.4518289999105 1071.797869999893 1075.3660969999619 1077.4228920000605 1079.3812939999625 1081.340689000208 1084.6933969999664 1086.2917590001598 1101.8282220000401 1105.0956020001322 1106.352132000029 1119.7590020000935 1122.4419320002198 1132.336749999784 1136.0438979999162 1141.2110890001059 1147.6462980001234 1156.195884999819 1159.0316519998014 1161.4715419998392 1175.2694839998148 1178.1457310002297
App start time runJsBundle Baseline
Mean: 303.169 ms
Stdev: 19.097 ms (6.3%)
Runs: 266 266 271 271 274 274 276 276 276 276 279 279 280 280 280 280 280 280 280 280 284 284 285 285 287 287 289 289 290 290 290 290 291 291 292 292 292 292 293 293 293 293 294 294 295 295 296 296 296 296 297 297 300 300 300 300 303 303 305 305 305 305 305 305 305 305 305 305 306 306 306 306 307 307 310 310 311 311 312 312 312 312 313 313 315 315 316 316 316 316 317 317 317 317 318 318 321 321 322 322 326 326 328 328 331 331 332 332 334 334 336 336 337 337 340 340 350 350

Current
Mean: 329.397 ms
Stdev: 18.884 ms (5.7%)
Runs: 287 287 291 291 298 298 303 303 306 306 306 306 307 307 308 308 308 308 309 309 310 310 313 313 314 314 316 316 317 317 318 318 320 320 320 320 321 321 322 322 322 322 323 323 323 323 323 323 324 324 324 324 324 324 327 327 327 327 327 327 328 328 330 330 332 332 333 333 335 335 335 335 337 337 338 338 338 338 338 338 340 340 341 341 341 341 342 342 343 343 343 343 344 344 345 345 348 348 350 350 351 351 351 351 353 353 361 361 362 362 365 365 370 370 373 373
App start time regularAppStart Baseline
Mean: 0.021 ms
Stdev: 0.002 ms (11.9%)
Runs: 0.017212000209838152 0.017456000205129385 0.017496000044047832 0.017496999818831682 0.01761800004169345 0.017659999895840883 0.017985000275075436 0.017985000275075436 0.018066999968141317 0.0183100001886487 0.018350999802350998 0.018514000345021486 0.018553999718278646 0.01859499979764223 0.018636000342667103 0.018637000117450953 0.018757999874651432 0.019003000110387802 0.019084000028669834 0.01912500010803342 0.019613000098615885 0.019815999548882246 0.019857000093907118 0.01993800001218915 0.020060000009834766 0.020142000168561935 0.02022299962118268 0.02030499977990985 0.020305000245571136 0.020955999847501516 0.02103699976578355 0.02111799968406558 0.021118000149726868 0.021240000147372484 0.021361999679356813 0.0213620001450181 0.0213620001450181 0.02148399967700243 0.021484000142663717 0.021606000140309334 0.02164700021967292 0.021687999833375216 0.02217599982395768 0.022299000062048435 0.022338999900966883 0.022338999900966883 0.02254200028255582 0.022665000054985285 0.02343699987977743 0.023804000113159418 0.023845000192523003 0.024292000103741884 0.024781000334769487 0.024820999708026648 0.025960000231862068 0.027059000451117754 0.027791999746114016

Current
Mean: 0.021 ms
Stdev: 0.002 ms (7.5%)
Runs: 0.017537999898195267 0.01769999973475933 0.0179449999704957 0.018187999725341797 0.01839200034737587 0.018553999718278646 0.018554999958723783 0.018757999874651432 0.018798999954015017 0.01887999987229705 0.019084000028669834 0.019164999946951866 0.019286999944597483 0.019328000023961067 0.019532000180333853 0.0197350000962615 0.01977499993517995 0.019816000014543533 0.01985599985346198 0.01985599985346198 0.019896999932825565 0.019897999707609415 0.019979000091552734 0.019979000091552734 0.02001999970525503 0.020060000009834766 0.020142000168561935 0.020223000086843967 0.020262999925762415 0.02038599969819188 0.02066999999806285 0.020711000077426434 0.02083300007507205 0.02103699976578355 0.021077000070363283 0.021118000149726868 0.021484000142663717 0.021484000142663717 0.021484999917447567 0.021566000301390886 0.021566000301390886 0.02164700021967292 0.021688000299036503 0.021809999831020832 0.021809999831020832 0.021809999831020832 0.022216999903321266 0.022216999903321266 0.022257000207901 0.022297999821603298 0.022338000126183033 0.02254199981689453 0.0226239999756217 0.022785999812185764 0.0233559999614954 0.0233559999614954 0.024211000185459852
App start time (CPU) Baseline
Mean: 150.650 %
Stdev: 7.428 % (4.9%)
Runs: 134.01574803149603 135.08955088664038 135.86614742027834 139.05970311796253 140.76463065295601 141.2884941480594 141.73121905186036 142.0938767146874 144.51577859432288 145.0304726912198 145.88601152020846 145.97974362739075 146.01229639092938 146.12193505632882 146.31604289934688 146.82100002357436 146.8832798772835 146.8897903989182 146.95162359178266 147.30225799239884 147.41035856573703 147.96327130823406 148.51579459438682 148.7976834633858 149.00457454938328 149.33050987264664 149.74028933575366 149.83442059162263 149.8719478247037 150.68703901447705 150.80389695774315 150.88553018663427 151.02260409041645 151.4545846297224 151.46178231771748 151.6531813241406 152.05068863605442 152.20538919793265 152.73321449792033 153 153.86006591073348 153.92538064176165 153.946544780262 154.4018482283882 154.72598110864894 156.33785507099952 156.91724121478163 157.16935575701544 157.7750137065489 157.80981067125649 158.71314741035863 159.86322367645323 161.28915662650604 161.93328635189104 163.3138083349338 165.5526838966203 166.91550431540372 170.22127589492638

Current
Mean: 150.731 %
Stdev: 7.638 % (5.1%)
Runs: 132.449493941402 138.4768906413409 139.78373726861312 139.85045953236812 139.9047222630824 141.11455723885643 142.44254135558486 142.4618055555555 142.4833997343957 142.7447340008048 143.15457907554145 143.69958902675214 143.83753723722296 144.64612326043752 144.74103585657377 144.8306766562127 145.01163197661253 145.48513504717647 146.10784971441953 146.5912135402106 146.78375663873987 146.9666610968292 147.11466633466128 147.85378667626293 148.21963834522742 148.8662674650699 149.45731886183634 149.6256947369889 149.97131243585704 150.43527922436422 150.5005525243091 150.66641218945827 151.0753056885708 151.29859328961123 151.78988158973334 152.27192482432812 152.9292430201809 153 154.4895848366768 155.27261200338125 155.53391017085482 155.68607404727067 155.74501992031875 155.90543637074947 157.14038589487686 157.43183121428427 157.72509960159368 157.73781502055678 158.55525308715036 159.75055122372854 159.87584470228225 160.09856157698528 160.3674320166753 161.71906437128735 161.77806463951043 162.57340850364108 163.24110671936762 164.4300351041519 169.41380782830203
App start time (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
App start time (RAM) Baseline
Mean: 362.127 MB
Stdev: 6.920 MB (1.9%)
Runs: 348.294921875 349.919921875 350.572265625 351.328125 352.625 353.423828125 354.083984375 354.177734375 354.55859375 354.630859375 355.216796875 355.376953125 355.4921875 356.43359375 356.828125 357.2734375 357.388671875 357.556640625 358.283203125 358.70703125 358.98046875 359.1458333333333 359.3958333333333 359.779296875 359.97265625 360.888671875 361.033203125 361.0481770833333 361.33203125 361.4895833333333 361.7682291666667 361.84375 361.9296875 362.390625 362.669921875 362.94921875 363.3294270833333 363.9088541666667 364.4908854166667 364.53515625 364.7578125 366.0234375 366.4010416666667 366.8424479166667 366.9388020833333 366.9713541666667 367.0846354166667 367.9192708333333 368.3294270833333 369.611328125 370.2760416666667 370.646484375 371.1236979166667 371.7955729166667 372.9036458333333 374.05078125 374.28515625 374.5833333333333 374.8684895833333 377.1783854166667

Current
Mean: 361.633 MB
Stdev: 8.215 MB (2.3%)
Runs: 341.7421875 342.50390625 345.65234375 347.3203125 349.662109375 351.2890625 351.900390625 352.1015625 352.98046875 353.146484375 353.224609375 354.013671875 355.337890625 355.646484375 355.98828125 356.291015625 356.583984375 356.953125 357.3268229166667 358.091796875 358.28125 359.203125 360.0286458333333 360.8489583333333 360.9856770833333 360.99609375 361.892578125 361.9674479166667 362.1796875 362.5651041666667 362.5768229166667 362.6966145833333 362.73046875 363.0221354166667 363.48046875 364.0234375 364.49609375 364.7682291666667 365.87109375 366.3776041666667 366.5065104166667 366.5455729166667 366.7578125 366.83984375 366.9609375 367.29296875 369.52734375 369.5846354166667 369.6471354166667 369.9453125 370.17578125 370.609375 370.7317708333333 371.046875 371.7552083333333 373.12890625 376.50390625 377.76953125 378.2747395833333
App start time (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
App start time (CPU/UI) Baseline
Mean: 28.703 %
Stdev: 2.741 % (9.5%)
Runs: 24.1 24.6 24.6 25.3 25.3 25.3 25.4 25.4 25.4 25.5 25.9 26 26.1 26.6 26.7 26.8 27 27.1 27.3 27.3 27.5 27.8 27.8 27.9 27.9 28 28 28 28 28.1 28.1 28.2 28.5 28.8 29.2 29.4 29.6 29.8 29.8 29.8 29.9 29.9 29.9 30 30 30.1 30.9 31 31.2 31.2 31.9 31.9 32 33 33.9 34 34.4 34.6 35.8

Current
Mean: 26.788 %
Stdev: 2.219 % (8.3%)
Runs: 22 22.7 23.4 23.9 24 24 24.1 24.3 24.6 24.6 24.6 24.8 24.8 25 25.2 25.3 25.4 25.4 25.4 25.8 25.9 26 26 26 26 26 26.1 26.2 26.6 26.6 26.7 26.7 26.9 26.9 27 27 27.3 27.3 27.3 27.5 27.7 27.8 28.1 28.6 28.6 28.6 28.6 29 29 29 29.1 29.8 29.9 30.1 30.2 31 31.2 31.3 31.6

@github-actions GitHub Actions
Copy link
Contributor

Performance Comparison Report 📊 (3/3)

Meaningless Changes To Duration (2/2)

Show entries
Name Duration
App start time nativeLaunch 34.966 ms → 25.966 ms (-9.000 ms, -25.7%) 🟢
App start time appCreation 64.136 ms → 73.833 ms (+9.698 ms, +15.1%) 🟡
App start time nativeLaunchEnd_To_appCreationStart 62.759 ms → 84.450 ms (+21.691 ms, +34.6%) 🟡
App start time appCreationEnd_To_contentAppeared 458.200 ms → 497.450 ms (+39.250 ms, +8.6%)
App start time contentAppeared_To_screenTTI 833.489 ms → 880.090 ms (+46.602 ms, +5.6%)
App start time runJsBundle 303.169 ms → 329.397 ms (+26.227 ms, +8.7%)
App start time regularAppStart 0.021 ms → 0.021 ms (-0.000 ms, -0.9%)
App start time (CPU) 150.650 % → 150.731 % (+0.080 %, ±0.0%)
App start time (FPS) 60.000 FPS → 60.000 FPS
App start time (RAM) 362.127 MB → 361.633 MB (-0.494 MB, ±0.0%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 28.703 % → 26.788 % (-1.915 %, -6.7%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 373.676 ms → 367.990 ms (-5.687 ms, -1.5%)
Report typing (CPU) 97.711 % → 96.588 % (-1.123 %, -1.1%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 443.481 MB → 442.127 MB (-1.354 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 20.631 % → 20.728 % (+0.097 %, ±0.0%)
Chat opening Chat TTI 854.668 ms → 754.935 ms (-99.733 ms, -11.7%)
Chat opening (CPU) 161.396 % → 162.510 % (+1.114 %, +0.7%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 382.774 MB → 383.227 MB (+0.454 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 31.717 % → 32.193 % (+0.476 %, +1.5%)
Show details
Name Duration
Report typing Composer typing rerender count Baseline
Mean: 1.000 renders
Stdev: 0.000 renders (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1.000 renders
Stdev: 0.000 renders (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Report typing Message sent Baseline
Mean: 373.676 ms
Stdev: 52.389 ms (14.0%)
Runs: 302.5010979999788 302.8200679998845 303.2629810003564 306.1781009999104 307.99837299995124 308.1808680007234 308.65120400022715 309.8404950001277 310.15608800016344 311.0696200001985 311.8668219996616 314.68631999986246 315.1582440007478 315.65364599972963 317.4995120000094 319.58256000000983 320.7963870000094 322.8565679998137 323.0531409997493 324.2351890001446 324.63741100020707 327.678181999363 328.80521700019017 329.0625820001587 331.4866940006614 337.6911220001057 338.13899799995124 397.15934300003573 397.9629310001619 402.84163499996066 402.9858809998259 403.1890459996648 405.25651099998504 408.466512999963 409.48396900016814 410.07629400026053 411.7039799997583 412.25736499996856 412.75394700001925 413.1966149993241 413.6181640001014 415.73783400002867 415.87906899955124 416.19494599988684 416.44600400002673 417.50976599985734 420.2271729996428 420.97473200038075 421.6885989997536 424.38134800083935 424.5729990005493 427.91943399980664 428.0163569999859 429.7669679997489 434.1204429999925 437.8294270001352 442.62679099990055 442.78649999946356 444.96960500022396 464.4311939999461

Current
Mean: 367.990 ms
Stdev: 51.896 ms (14.1%)
Runs: 298.28031500056386 303.0582679999061 303.23217800073326 303.7585450001061 304.0873210001737 306.0173749998212 308.07185899978504 308.4473470002413 309.03772000037134 309.3454999998212 309.89314799942076 310.37239599972963 311.2554930001497 311.7648930000141 314.8798010000028 315.12219300027937 315.34155299980193 315.65527400001884 315.8662109998986 317.1393230003305 318.93196600023657 319.4223629999906 319.990559999831 322.11002700030804 324.1027429997921 325.9599609998986 332.2430420005694 340.4149989997968 393.12805199995637 395.8146160002798 401.0625809999183 402.12361699994653 402.27832099981606 402.82307900022715 403.87255899980664 404.3919270001352 405.10990400006995 405.28556300047785 405.88985199993476 406.808918999508 407.39497899916023 408.6267090002075 410.2285560001619 410.42614800017327 410.8898520004004 414.261880999431 415.15653500007465 416.61828600009903 417.2244059997611 418.5493979998864 422.33463599998504 424.8653560001403 425.37198900058866 426.172201000154 427.9946289998479 429.6863609999418 430.8633630000986 433.94840499944985 452.2596040000208 454.1121419998817
Report typing (CPU) Baseline
Mean: 97.711 %
Stdev: 7.763 % (7.9%)
Runs: 85.0079315302125 85.74594117152716 85.7763109785041 85.9713579199389 85.99562357330717 86.31066466700165 86.87598651240195 87.1176284992207 88.74316462488983 89.00842957471073 89.29079772712946 89.99944978448873 90.26150401297615 90.73386829377651 90.84303540843578 92.5648348076531 93.8517746926569 93.9571683155888 94.04180834043888 94.3530734052798 94.44186696053883 94.70289591319991 94.86467281511344 94.9354754491091 95.77555030615409 95.96525926048953 96.84013853307408 97.05280048291034 97.21436907456355 97.32696123148631 97.80313875092509 98.0408942149426 98.32597270300553 98.74230536333742 98.77666659637543 99.37890637891866 99.87080684697717 99.89350411693746 99.90667040269912 100.30675085602674 100.99899748821771 101.00662304906592 101.09137369626654 101.90997404781268 103.08185125067759 103.82441282441755 105.77031540014542 106.1545859918239 106.3831710367763 107.09946911923788 107.20579030994728 107.3843114802257 107.71297472011233 107.88626052029348 109.04084269575709 110.08524801324812 112.1223369349968 112.53137960058487 117.03087201075772

Current
Mean: 96.588 %
Stdev: 6.435 % (6.7%)
Runs: 86.29001030593521 87.07282075677675 87.5251192099538 88.03911986777824 88.1822368896145 88.19662544490926 88.50643795445339 88.99398976029741 89.34879494290182 90.34054655802962 90.55148600090753 90.73342594021123 91.4536491150382 91.59391137327489 91.62499518313476 91.64983985134165 92.10645918703244 92.30534628543127 92.34349828372686 92.57843777436241 92.63021439878304 92.77367563345683 94.90951360381382 94.93671653930728 95.02651470576772 95.43208883405319 95.50042156790623 95.89319970003602 95.97164440560371 96.48036734087158 96.4846728984764 96.68463471858551 96.82264472550831 97.21689870359445 97.37390795239969 97.3993565942587 97.57923830545133 98.01948408656887 98.18838315518425 98.8595491535434 98.94422552151795 98.98414848661818 99.32802095954031 100.09227565795446 100.18516550021425 100.33580936665528 101.09499831820516 101.24185064126803 101.45153646083145 101.55360710631301 101.68330359166494 102.95570329741821 106.35834038151711 106.50690274691222 108.85424281493536 110.00624584898758 110.63954901925479 111.98935126586987 112.85441251925748
Report typing (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
Report typing (RAM) Baseline
Mean: 443.481 MB
Stdev: 8.740 MB (2.0%)
Runs: 419.20659722222223 429.34171195652175 430.5863095238095 431.21786221590907 432.36985085227275 433.2626953125 433.4833984375 433.66879111842104 434.0137648809524 434.4979538690476 434.671484375 435.1044921875 435.35625 436.2008167613636 437.61533717105266 437.78984375 438.3344983552632 438.73757102272725 438.8177649456522 439.536328125 439.7521158854167 439.89506392045456 440.96463815789474 441.2884114583333 441.5376233552632 441.6122532894737 442.5014391447368 442.69449013157896 443.0709292763158 443.3822265625 443.8052734375 443.8240411931818 444.1345703125 445.0931640625 445.39140625 447.11985085227275 449.4240234375 449.54971590909093 449.8955592105263 450.64921875 451.073828125 451.4740953947368 451.54575892857144 451.77659970238096 452.48881392045456 452.6683407738095 452.7150390625 453.30394345238096 453.87872023809524 454.4038318452381 454.4321546052632 454.5896484375 455.80941611842104 455.9292763157895 456.6819490131579 462.7536057692308

Current
Mean: 442.127 MB
Stdev: 7.780 MB (1.8%)
Runs: 426.4263980263158 428.7372622282609 429.359375 429.94016335227275 429.942578125 431.2431640625 431.70454545454544 432.873046875 433.0777138157895 433.2994791666667 433.5793138586956 434.38600852272725 434.8110119047619 435.0458470394737 435.1448863636364 437.059375 437.2893629807692 437.5176711309524 438.1373046875 438.57279829545456 438.58470394736844 438.6102241847826 439.50185032894734 439.58675986842104 439.7333984375 440.06044407894734 440.3349095394737 440.703125 441.0255859375 441.4506578947368 441.68441611842104 442.39382102272725 442.46803977272725 443.0326891447368 443.11328125 443.97904829545456 444.0953125 444.17950148809524 444.4395461309524 445.1177455357143 446.996484375 447.03359375 447.507421875 448.1111328125 448.4775390625 449.1751953125 449.763671875 451.4619654605263 451.628125 451.62890625 451.6576891447368 451.8431919642857 451.8564967105263 452.5474330357143 452.82997532894734 454.1111328125 454.26615767045456 454.3656994047619 454.7825520833333 455.3089488636364
Report typing (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
Report typing (CPU/UI) Baseline
Mean: 20.631 %
Stdev: 1.090 % (5.3%)
Runs: 18.1 18.1 18.8 18.8 19 19.1 19.2 19.2 19.3 19.4 19.5 19.5 19.7 19.9 20 20.1 20.1 20.1 20.1 20.1 20.2 20.3 20.4 20.4 20.5 20.5 20.6 20.6 20.7 20.8 21 21 21 21 21.1 21.1 21.1 21.2 21.2 21.2 21.3 21.3 21.4 21.4 21.4 21.4 21.5 21.7 21.7 21.8 21.8 21.8 21.9 22.1 22.3 22.5 22.5 22.8

Current
Mean: 20.728 %
Stdev: 1.048 % (5.1%)
Runs: 18.3 18.4 18.6 18.7 19 19.2 19.3 19.6 19.6 19.8 19.8 19.8 19.8 19.9 20.2 20.2 20.2 20.2 20.3 20.3 20.3 20.3 20.5 20.6 20.7 20.7 20.8 20.8 20.9 20.9 20.9 21 21.1 21.1 21.1 21.1 21.2 21.2 21.3 21.3 21.3 21.3 21.4 21.5 21.5 21.5 21.6 21.7 21.7 21.7 21.9 22 22.1 22.1 22.1 22.2 22.6 23
Chat opening Chat TTI Baseline
Mean: 854.668 ms
Stdev: 193.773 ms (22.7%)
Runs: 549.1141360001639 661.9978030007333 665.8830560008064 668.7155760005116 671.0713709993288 672.8196620000526 680.1907959999517 685.911987000145 703.9648439995944 710.8547360002995 714.3344330005348 715.5136719997972 720.0357670001686 720.76977599971 724.1341959992424 726.0300709996372 729.1084390003234 737.7406419999897 739.4994310000911 743.683796999976 746.3993330001831 747.6651609996334 748.0293780006468 749.5970869995654 750.5286870002747 751.2629800001159 753.8088389998302 755.597779000178 762.1609709998593 763.2448330000043 770.4988199993968 770.7670910004526 776.1660970002413 777.2617999995127 789.2007240001112 797.5445149997249 801.8330889996141 807.9700939999893 811.7807219997048 814.3861899999902 819.1394859999418 822.4465739997104 830.8979489998892 833.4843349996954 1012.5932209994644 1051.9265550002456 1132.0337330000475 1135.275717000477 1142.3648689994588 1152.720703999512 1163.3023690003902 1169.0923270005733 1178.3074550004676 1185.0735280001536 1186.3712980002165 1186.8329680003226 1188.266072999686 1200.2985849995166 1201.9060470005497 1300.6736249998212

Current
Mean: 754.935 ms
Stdev: 51.152 ms (6.8%)
Runs: 667.8863120004535 670.0294190002605 672.750936999917 674.5194900007918 678.8862709999084 689.1863200003281 689.7577719995752 693.0135500002652 698.3555910000578 705.2985840002075 710.8010669993237 717.2894289996475 717.5322270002216 717.6049399999902 727.5113119995221 729.019369000569 729.5751949995756 733.5607500001788 734.5399989997968 734.7463380005211 735.6779789999127 737.1392020005733 740.7023519994691 757.365681999363 767.5771490000188 773.0169680006802 774.900391000323 775.4831950003281 778.0636400002986 778.3733320003375 778.4525149995461 781.8915200000629 786.3040370000526 788.8190509993583 792.2027599997818 795.3099370002747 798.4197589997202 799.9729829998687 821.6210130006075 822.1508799996227 822.541464000009 828.0909839998931 830.109659999609 830.5079760001972 831.0936690000817 831.2628180002794 833.0250249998644
Chat opening (CPU) Baseline
Mean: 161.396 %
Stdev: 5.272 % (3.3%)
Runs: 151.21801451826053 152.23730395660917 152.371598941908 153.56757169637777 153.67266857934226 154.60860286478095 154.80340705295845 154.9604322704485 155.62245140286544 155.62758729197856 155.64700439356992 156.1192522882665 156.14909857630576 157.04552845583274 157.7441514312564 157.75847520089886 157.84957415874163 158.47933133975593 158.72556364751534 158.95225386145913 159.37925474916258 159.4008530691863 159.5085327570464 159.54835032278794 159.7896171024205 160.34166350437377 160.63138925333905 160.68303036743396 160.99956608453766 161.4424742162328 161.9897781409312 162.3771227333347 162.43807206304527 162.460127781553 162.53315996388417 162.5932135728543 162.70339558507018 163.05177420065561 163.06873539410813 163.31529818195102 163.75688354172524 164.74638186736 164.77977221432707 164.79653148235582 164.8356598774837 164.90933798228113 164.96729224692865 165.59548271250333 166.4305573952597 166.52812676363777 166.8090129960043 167.76783826015466 168.96649976909535 169.05003174991302 169.23029406316326 170.1551646059976 170.8560915805581 172.58248609102338 174.15766892270892

Current
Mean: 162.510 %
Stdev: 5.104 % (3.1%)
Runs: 152.3452618634986 153.28841008926054 154.5211991245755 154.92410743579003 155.63323186894328 156.14015320554293 156.41148758325505 156.43283606195175 156.48452434707323 156.91957973095313 157.05074158802867 157.48101300839824 158.7225309087581 158.90681267028725 158.98361261927542 159.10114001604185 159.64549551494025 159.81323221171542 160.00894811819214 160.13479047656128 160.37459098332138 160.385635486545 160.54545321997864 161.1111667819954 161.12370627773313 161.21593696389746 161.38086545339598 161.73047298110484 161.7748839653219 162.1192761845058 162.1812535388266 162.60209046398398 162.68912643479567 162.96749717731828 163.18035016345578 163.35600882997593 163.43338389954678 163.95660190515946 164.20409439610484 164.30853903137285 164.37277273169337 165.09367830269971 165.51340926676068 165.5976397106384 165.6099814159744 165.89557998097905 166.1716109646708 166.9674353537215 167.21784697495713 167.772765030154 168.27499913897407 168.82053683274466 169.87203942474892 170.72502210581789 171.37553021459456 171.522395802117 173.0927025945364 173.26493817080382 173.33870751750845
Chat opening (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
Chat opening (RAM) Baseline
Mean: 382.774 MB
Stdev: 7.988 MB (2.1%)
Runs: 367.7890625 369.771484375 369.802734375 370.931640625 371.3388671875 371.404296875 371.7646484375 372.787109375 372.955078125 373.001953125 373.11640625 373.12109375 373.4580078125 374.3876953125 375.7900390625 376.69140625 376.8291015625 377.4270833333333 377.6689453125 378.41484375 378.4625 378.74765625 379.10390625 379.175 380.51953125 381.2278645833333 381.9322916666667 382.06875 382.25390625 382.31484375 383.1634114583333 384.30859375 385.5240885416667 385.662109375 386.178125 386.240234375 386.423828125 386.42890625 387.021484375 387.52734375 387.5859375 387.8193359375 388.89453125 389.494140625 389.7649739583333 389.9984375 390.225 390.325 390.440625 390.46875 390.6923828125 391.388671875 392.275 392.45200892857144 393.72433035714283 394.2057291666667 394.45390625 396.314453125 396.396875 396.7546875

Current
Mean: 383.227 MB
Stdev: 7.098 MB (1.9%)
Runs: 369.18359375 370.05078125 371.171875 372.6201171875 374.078125 374.5439453125 374.8916015625 375.0751953125 376.0439453125 376.0810546875 376.38671875 376.4359375 376.6318359375 376.80078125 376.821875 377.18828125 377.4326171875 377.4462890625 377.83515625 378.30546875 379.4345703125 379.5 379.5029296875 380.10078125 380.447265625 380.81953125 381.3890625 381.7724609375 382.921875 383.56484375 383.7109375 384.2421875 384.2671875 384.62890625 385.3391927083333 385.6765625 385.8015625 386.190625 386.5671875 386.8369140625 387.17734375 387.3427734375 387.6243489583333 387.7037760416667 387.908203125 388.8111979166667 389.42109375 389.61796875 390.5240885416667 391.02120535714283 391.078125 391.87734375 392.6100260416667 393.0462239583333 393.36875 393.70625 393.7734375 394.03671875 397.11160714285717 398.14375
Chat opening (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
Chat opening (CPU/UI) Baseline
Mean: 31.717 %
Stdev: 1.729 % (5.5%)
Runs: 27.7 28.3 28.7 28.8 29.3 29.4 29.8 29.8 30 30.2 30.2 30.4 30.4 30.4 30.5 30.5 30.6 30.8 31 31.1 31.2 31.2 31.2 31.3 31.3 31.3 31.4 31.4 31.4 31.4 31.4 31.5 31.6 31.7 31.9 32.1 32.1 32.1 32.3 32.4 32.4 32.6 32.8 33 33.1 33.2 33.4 33.4 33.5 33.6 33.6 34 34.3 34.4 34.4 34.5 34.9 35 35.1

Current
Mean: 32.193 %
Stdev: 1.552 % (4.8%)
Runs: 28.7 29.2 29.4 29.8 30.4 30.4 30.7 30.8 30.8 30.8 30.9 31 31 31.1 31.1 31.1 31.1 31.2 31.3 31.4 31.6 31.8 31.8 31.8 31.9 31.9 32.1 32.2 32.2 32.2 32.2 32.2 32.3 32.3 32.4 32.5 32.5 32.5 32.7 32.8 32.9 33 33 33.1 33.1 33.5 33.5 33.8 33.9 33.9 34 34.7 34.8 34.8 35 35.9 36

@github-actions GitHub Actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@mvtglobally
Copy link

@luacmartins @hoangzinh @srikarparsi Original issue is not reproducible anymore, but now, the "View" button that is visible on expense preview on chat, is not seen on "Reports". No button at all, can be seen on preview of the expense on "Reports". Is this expected fix?

Button.mp4

@luacmartins
Copy link
Contributor Author

@mvtglobally yes, that's expected. We don't show the View button on mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangzinh hoangzinh hoangzinh approved these changes

@srikarparsi srikarparsi srikarparsi approved these changes

Assignees

@luacmartins luacmartins

Labels
CP Staging marks PRs that have been CP'd to staging DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luacmartins @hoangzinh @OSBotify @mvtglobally @srikarparsi