Skip to content

Revert "Merge pull request #60267 from thelullabyy/fix/59566-chat-preview-display-wrong-when-paying" #62171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
+0 −4
Merged

Revert "Merge pull request #60267 from thelullabyy/fix/59566-chat-preview-display-wrong-when-paying" #62171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2384,7 +2384,7 @@
* Checks whether the card transaction support deleting based on liability type
*/
function canDeleteCardTransactionByLiabilityType(iouTransactionID?: string): boolean {
const transaction = getTransaction(iouTransactionID ?? CONST.DEFAULT_NUMBER_ID);

Check failure on line 2387 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

'getTransaction' is deprecated. Get the data straight from Onyx
const isCardTransaction = isCardTransactionTransactionUtils(transaction);
if (!isCardTransaction) {
return true;
Expand Down Expand Up @@ -4268,10 +4268,6 @@
let actualPayerName = report.managerID === currentUserAccountID ? '' : getDisplayNameForParticipant({accountID: report.managerID, shouldUseShortForm: true});
actualPayerName = actualPayerName && isForListPreview && !isPreviewMessageForParentChatReport ? `${actualPayerName}:` : actualPayerName;
const payerDisplayName = isPreviewMessageForParentChatReport ? payerName : actualPayerName;
if (isForListPreview && report?.parentReportID != null) {
const payerText = isDM(parentReport) && translatePhraseKey === 'iou.payerPaidAmount' ? '' : payerDisplayName;
return translateLocal(translatePhraseKey, {amount: formattedReimbursableAmount, payer: payerText});
}

return translateLocal(translatePhraseKey, {amount: formattedReimbursableAmount, payer: payerDisplayName ?? ''});
}
Expand Down
Loading