-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[No QA] Refactor artifacts workflow to enable valid usage of concurrency #62101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Refactor artifacts workflow to enable valid usage of concurrency #62101
Conversation
I might not be able to fully test the workflow after these changes today, so I'll continue tomorrow. 👍 |
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@roryabraham I'm assuming this doesn't need C+ review ? |
@ikevin127, correct, thank you |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊 (1/11)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (10/11)Meaningless Changes To Duration (9/10)Show entries
Show details
|
Performance Comparison Report 📊 (11/11)Meaningless Changes To Duration (10/10)Show entries
Show details
|
Performance Comparison Report 📊 (2/11)Meaningless Changes To Duration (1/10)Show entries
Show details
|
Performance Comparison Report 📊 (3/11)Meaningless Changes To Duration (2/10)Show entries
Show details
|
Performance Comparison Report 📊 (4/11)Meaningless Changes To Duration (3/10)Show entries
Show details
|
Performance Comparison Report 📊 (5/11)Meaningless Changes To Duration (4/10)Show entries
Show details
|
Performance Comparison Report 📊 (6/11)Meaningless Changes To Duration (5/10)Show entries
Show details
|
Performance Comparison Report 📊 (7/11)Meaningless Changes To Duration (6/10)Show entries
Show details
|
Performance Comparison Report 📊 (8/11)Meaningless Changes To Duration (7/10)Show entries
Show details
|
Performance Comparison Report 📊 (9/11)Meaningless Changes To Duration (8/10)Show entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
This did not affect app runtime at all, so this is for sure a false positive |
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.47-0 🚀
|
Explanation of Change
Previously, the workflow used a single job with a matrix strategy to handle two tasks:
This setup had a limitation when using concurrency. If a pull request requiring new artifacts for both Standalone NewDot and HybridApp was merged, it would trigger a workflow with a matrix including both apps. If another pull request was merged shortly after and only required HybridApp artifacts, it would also trigger a new matrix job that still includes both apps.
However, the verification step inside the NewDot matrix job would detect that NewDot doesn't need to be rebuilt in the second workflow and skip that part. At the same time, due to concurrency, this second workflow would cancel the first one even though the first workflow was still building the necessary NewDot artifacts. As a result, those artifacts would never be published.
This pull request resolves the issue by splitting the workflow into two separate jobs:
Fixed Issues
$ #57120
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectioncanBeMissing
param foruseOnyx
toggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop