Skip to content

Fix adding unreported expense when expense is created in offline mode #62097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2025
+1 −1
Merged

Fix adding unreported expense when expense is created in offline mode #62097

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c6f800
fix condition
sumo-slonik May 15, 2025
0254024
fix working adding of offline created expense
sumo-slonik May 15, 2025
8cd20c0
Merge branch 'main' into bugfix/kuba_nowakowski/offline-mode-expense-…
sumo-slonik May 15, 2025
e31e605
solution simply as it can be
sumo-slonik May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/actions/IOU.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3630,7 +3630,7 @@
transactionParams: {
amount: isExpenseReport(iouReport) ? -amount : amount,
currency,
reportID: shouldUseMoneyReport && iouReport ? iouReport.reportID : undefined,
reportID: shouldUseMoneyReport && iouReport ? iouReport.reportID : CONST.REPORT.UNREPORTED_REPORT_ID,
comment,
created,
merchant,
Expand Down Expand Up @@ -8205,7 +8205,7 @@

Object.values(iouReportActions).forEach((action) => {
const transactionID = isMoneyRequestAction(action) ? getOriginalMessage(action)?.IOUTransactionID : undefined;
const transaction = getTransaction(transactionID);

Check failure on line 8208 in src/libs/actions/IOU.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

'getTransaction' is deprecated. Get the data straight from Onyx

if (transaction?.comment?.hold) {
holdReportActions.push(action as OnyxTypes.ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.IOU>);
Expand Down
Loading