Skip to content

[No QA] Paginate commit diff when creating checklist #62061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025
Merged

[No QA] Paginate commit diff when creating checklist #62061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4fc4234
Use compareCommitsWithBasehead
roryabraham May 14, 2025
3ab6fa5
Add pagination to compareCommits
roryabraham May 14, 2025
2ad6162
fix tests
roryabraham May 14, 2025
55e73e0
Fix mocks in GithubUtilsTest
roryabraham May 14, 2025
e12f771
fix types and mocks in tests
roryabraham May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/actions/javascript/authorChecklist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16038,11 +16038,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -16054,7 +16053,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/awaitStagingDeploys/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12831,11 +12831,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -12847,7 +12846,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/checkAndroidStatus/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737526,11 +737526,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -737542,7 +737541,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/checkDeployBlockers/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12114,11 +12114,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -12130,7 +12129,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/createOrUpdateStagingDeploy/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12351,11 +12351,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -12367,7 +12366,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/getArtifactInfo/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12075,11 +12075,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -12091,7 +12090,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/getDeployPullRequestList/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12364,11 +12364,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -12380,7 +12379,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/getPreviousVersion/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12219,11 +12219,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -12235,7 +12234,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/getPullRequestDetails/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12178,11 +12178,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -12194,7 +12193,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/isStagingDeployLocked/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12075,11 +12075,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -12091,7 +12090,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/markPullRequestsAsDeployed/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13472,11 +13472,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -13488,7 +13487,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/postTestBuildComment/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12187,11 +12187,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -12203,7 +12202,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
7 changes: 3 additions & 4 deletions .github/actions/javascript/proposalPoliceComment/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18658,11 +18658,10 @@ class GithubUtils {
static async getCommitHistoryBetweenTags(fromTag, toTag) {
console.log('Getting pull requests merged between the following tags:', fromTag, toTag);
try {
const { data: comparison } = await this.octokit.repos.compareCommits({
const comparison = await this.paginate(this.octokit.repos.compareCommitsWithBasehead, {
owner: CONST_1.default.GITHUB_OWNER,
repo: CONST_1.default.APP_REPO,
base: fromTag,
head: toTag,
basehead: `${fromTag}...${toTag}`,
});
// Map API response to our CommitType format
return comparison.commits.map((commit) => ({
Expand All @@ -18674,7 +18673,7 @@ class GithubUtils {
}
catch (error) {
if (error instanceof request_error_1.RequestError && error.status === 404) {
console.error(`❓❓ Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡💡`);
console.error(`❓Failed to compare commits with the GitHub API. The base tag ('${fromTag}') or head tag ('${toTag}') likely doesn't exist on the remote repository. If this is the case, create or push them. 💡`);
}
// Re-throw the error after logging
throw error;
Expand Down
Loading
Loading