fix Lottie Animation Scaling and container width in Trips Empty State Illustration #61996

nabi-ebrahimi · 2025-05-14T07:26:24Z

Explanation of Change

Fixed Issues

$ #60963
PROPOSAL: #60963 (commnet)

Tests

Login with a new account
Click Reports > Trips
Observe the empty state illustration
Trips empty state illustration is not large

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-05-15.at.11.52.27.AM.mov

Android: mWeb Chrome

android-web-1.mov

iOS: Native

ios-native-1.mov

iOS: mWeb Safari

Screen.Recording.2025-05-15.at.11.46.17.AM.mov

MacOS: Chrome / Safari

desktop-web-record.mov

MacOS: Desktop

macos-desktop.mov

…nd visual balance

melvin-bot · 2025-05-14T07:26:53Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…cross screen sizes on native and web

Gonals · 2025-05-14T11:51:19Z

Not sure why you didn't get autoassigned here, @jayeshmangwani

jayeshmangwani · 2025-05-14T11:56:30Z

Not sure why you didn't get autoassigned here

It’s possible the contributor made a mistake in the checklist while adding the issue link.

jayeshmangwani · 2025-05-14T11:57:44Z

@nabi-ebrahimi Not a big deal, but we should've added the Android screenshot/video to the checklist.

nabi-ebrahimi · 2025-05-14T12:01:01Z

should've

@jayeshmangwani I'll do it soon—my previous setup seems to be broken, and I’m currently unable to run the app on Android. I'm working on fixing it and will get it done as soon as possible.

shawnborton · 2025-05-14T14:09:16Z

Videos look good to me so far 👍

shawnborton · 2025-05-14T14:09:59Z

Can we also double check that the animation looks good when you access Book Travel through the global create button? Thanks!

… '100%' on larger screens

nabi-ebrahimi · 2025-05-14T20:56:01Z

Can we also double check that the animation looks good when you access Book Travel through the global create button? Thanks!

book-a-travel.mov

nabi-ebrahimi · 2025-05-14T20:56:46Z

@nabi-ebrahimi Not a big deal, but we should've added the Android screenshot/video to the checklist.

@jayeshmangwani PR is ready for review. thanks.

…onent

src/pages/Search/EmptySearchView.tsx

…atforms

shawnborton · 2025-05-15T07:41:46Z

Looking good, thanks for confirming!

src/pages/Search/EmptySearchView.tsx

jayeshmangwani · 2025-05-15T16:24:48Z

src/pages/Search/EmptySearchView.tsx

@@ -272,7 +272,7 @@ function EmptySearchView({type, hasResults}: EmptySearchViewProps) {
                    titleStyles={content.titleStyles}
                    subtitle={content.subtitle}
                    buttons={content.buttons}
-                    headerContentStyles={[styles.h100, styles.w100, ...content.headerContentStyles]}
+                    headerContentStyles={[styles.h100, styles.w100, ...content.headerContentStyles] as Array<ViewStyle & ImageStyle>}


Please revert this change , I don't think it's needed here.

I need to either update the type of the headerContentStyles prop or leave it as is, since removing it leads to a type error.

Currently, its type is ViewStyle & ImageStyle in the EmptyStateComponent, so we’d also need to update the types in EmptyStateComponent accordingly.

src/pages/Search/EmptySearchView.tsx

fix: resize Trips empty state illustration to maintain aspect ratio a…

93de73f

…nd visual balance

nabi-ebrahimi requested a review from a team as a code owner May 14, 2025 07:26

melvin-bot bot requested review from Gonals and removed request for a team May 14, 2025 07:26

Set Lottie container width and height to 100% for consistent sizing a…

361cf0d

…cross screen sizes on native and web

nabi-ebrahimi requested a review from a team as a code owner May 14, 2025 11:28

Gonals removed their request for review May 14, 2025 11:50

Gonals assigned nabi-ebrahimi May 14, 2025

Gonals requested a review from jayeshmangwani May 14, 2025 11:51

Use fixed width and height for Lottie container on small screens, and…

9d3c650

… '100%' on larger screens

Add isSmallScreen to useMemo dependency array in EmptySearchView comp…

1235fcf

…onent

jayeshmangwani reviewed May 15, 2025

View reviewed changes

src/pages/Search/EmptySearchView.tsx Outdated Show resolved Hide resolved

Set min-width to container as well to keep border-radius on native pl…

a2e5472

…atforms

nabi-ebrahimi requested a review from jayeshmangwani May 15, 2025 07:36

jayeshmangwani reviewed May 15, 2025

View reviewed changes

src/pages/Search/EmptySearchView.tsx Outdated Show resolved Hide resolved

Set fixed width and height to lottie view and '100%' to container

80b8d5b

nabi-ebrahimi requested a review from jayeshmangwani May 15, 2025 14:33

jayeshmangwani reviewed May 15, 2025

View reviewed changes

src/pages/Search/EmptySearchView.tsx Outdated Show resolved Hide resolved

moved styles into styles file

cbfa944

updated useMemo dependencies

dc70591

nabi-ebrahimi requested a review from jayeshmangwani May 15, 2025 18:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix Lottie Animation Scaling and container width in Trips Empty State Illustration #61996

fix Lottie Animation Scaling and container width in Trips Empty State Illustration #61996

nabi-ebrahimi commented May 14, 2025 •

edited

Loading

melvin-bot bot commented May 14, 2025

Gonals commented May 14, 2025

jayeshmangwani commented May 14, 2025

jayeshmangwani commented May 14, 2025

nabi-ebrahimi commented May 14, 2025

shawnborton commented May 14, 2025

shawnborton commented May 14, 2025

nabi-ebrahimi commented May 14, 2025

nabi-ebrahimi commented May 14, 2025

shawnborton commented May 15, 2025

jayeshmangwani May 15, 2025

nabi-ebrahimi May 15, 2025 •

edited

Loading

fix Lottie Animation Scaling and container width in Trips Empty State Illustration #61996

Are you sure you want to change the base?

fix Lottie Animation Scaling and container width in Trips Empty State Illustration #61996

Conversation

nabi-ebrahimi commented May 14, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 14, 2025

Gonals commented May 14, 2025

jayeshmangwani commented May 14, 2025

jayeshmangwani commented May 14, 2025

nabi-ebrahimi commented May 14, 2025

shawnborton commented May 14, 2025

shawnborton commented May 14, 2025

nabi-ebrahimi commented May 14, 2025

nabi-ebrahimi commented May 14, 2025

shawnborton commented May 15, 2025

jayeshmangwani May 15, 2025

Choose a reason for hiding this comment

nabi-ebrahimi May 15, 2025 • edited Loading

Choose a reason for hiding this comment

nabi-ebrahimi commented May 14, 2025 •

edited

Loading

nabi-ebrahimi May 15, 2025 •

edited

Loading