[InternalQA] Add drop zone to the reports page #61916

koko57 · 2025-05-13T17:09:50Z

Explanation of Change

Fixed Issues

$ #59440
PROPOSAL:

Tests

Go to Reports tab
Drag a receipt over the list of the reports
Verify that the drop zone is displayed
Drop the file
Verify that the IOU flow starts from the participants page
Go through the flow, verify that you can create the expense correctly
Repeat the steps on the other Search page tab - like Chats or Tasks
Verify that the page after creating the request changes to Expense

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-05-13.at.19.35.29.mp4

Screen.Recording.2025-05-13.at.19.35.05.mp4

MacOS: Desktop

Screen.Recording.2025-05-13.at.19.23.24.mp4

Screen.Recording.2025-05-13.at.19.19.48.mp4

…ound

melvin-bot · 2025-05-13T17:37:52Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

lakchote · 2025-05-14T08:10:58Z

@getusha can you review it today please?

getusha · 2025-05-14T08:33:27Z

@getusha can you review it today please?

Yes, i am on it.

getusha · 2025-05-14T09:14:46Z

@koko57 based on this i assume we should be changing the tab after creating the expense

Screen.Recording.2025-05-14.at.12.13.19.in.the.afternoon.mov

koko57 · 2025-05-14T09:16:07Z

@getusha yep, still working on it

github-actions · 2025-05-14T09:43:53Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

koko57 · 2025-05-14T09:45:06Z

@getusha done! you can continue - I've updated the test steps. Can you also check this: #61523 (comment) ?

getusha · 2025-05-14T11:59:26Z

src/libs/actions/IOU.ts

@@ -808,8 +808,15 @@ Onyx.connect({
 * It is a helper function used only in this file.
 */
 function dismissModalAndOpenReportInInboxTab(reportID?: string) {
-    if (isSearchTopmostFullScreenRoute() || !reportID) {
+    const isSearchPageTopmostFullScreenRoute = isSearchTopmostFullScreenRoute();
+    if (isSearchPageTopmostFullScreenRoute || !reportID) {


I think we should prevent this navigation on mobile. it would also affect the global create flow on search page, i wonder if we want that change.

For the Global Create - I think having two behaviors for Global Create and Create Expense after drop would be strange, especially since this Create Expense flow should work like it was opened from the Global Create (like it was mentioned in the docs) - but could you please LMK what do you think about it? @lakchote @dannymcclain @shawnborton @dubielzyk-expensify

For the Global Create - I think having two behaviors for Global Create and Create Expense after drop would be strange, especially since this Create Expense flow should work like it was opened from the Global Create

I do agree that we should have a consistent behavior. Let's see what everyone thinks!

@getusha for the mobile - looks like it doesn't cause any problem

Screen.Recording.2025-05-14.at.15.56.52.mp4

the only thing I've noticed that the query phrase looks strange when changing a tab (but it's from changing the tab)

Screen.Recording.2025-05-14.at.15.45.01.mp4

the only thing I've noticed that the query phrase looks strange when changing a tab (but it's from changing the tab)

This can always be addressed in a follow-up PR as it's not related to this PR.

cc @luacmartins is this format of the search query expected or not?

No, it's not. I think we have a bug reported for it somewhere. I can't find the link though 🤔

ah here it is #61940

getusha · 2025-05-14T12:49:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-14.at.10.13.03.at.night.mov

Android: mWeb Chrome

Screen.Recording.2025-05-14.at.10.17.42.at.night.mov

iOS: HybridApp

Screen.Recording.2025-05-14.at.10.18.59.at.night.mov

iOS: mWeb Safari

Screen.Recording.2025-05-14.at.10.21.46.at.night.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-14.at.3.37.12.in.the.afternoon.mov

MacOS: Desktop

Screen.Recording.2025-05-14.at.3.46.17.in.the.afternoon.mov

getusha · 2025-05-14T19:21:03Z

src/pages/Search/SearchPage.tsx

+                setIsLoadingReceipt(true);
+            }
+            resizeImageIfNeeded(originalFile).then((resizedFile) => {
+                // setIsLoadingReceipt(false);


this intentional?

getusha · 2025-05-14T19:28:07Z

Confirmed #61523 (comment) is fixed

Screen.Recording.2025-05-14.at.10.25.02.at.night.mov

getusha

LGTM, thanks!

koko57 added 11 commits May 8, 2025 09:42

feat; add dropzone to the reports page

5522ba1

chore: move navigateToParticipantsPage function to IOU ations

a9466ec

fix: prettier

2dd1dbe

feat: wip - add file validation

5493ce1

fix: add loader, move navigateToParticipantsPage to utils

7116b0c

Merge branch 'main' into feat/59440-add-dropzone-to-reports-page

465ece5

feat: save receipt and navigate to participants page

0c49fcf

feat: enable dropzone on the other tabs, change the tab in the backgr…

2b2e593

…ound

fix: resolve conflicts

ce9342a

fix: prettier

21b8ced

fix: lint

bef1264

koko57 marked this pull request as ready for review May 13, 2025 17:37

koko57 requested a review from a team as a code owner May 13, 2025 17:37

melvin-bot bot requested review from getusha and removed request for a team May 13, 2025 17:37

lakchote self-requested a review May 13, 2025 17:39

koko57 added 5 commits May 14, 2025 09:24

fix: enable the feature only for beta

c62ffc2

fix: show replace receipt icon and text when editing

ef11d9c

fix: remove console.log

c33b3e1

fix: minor fix

5e50914

fix: minor fix

74c9441

lakchote mentioned this pull request May 14, 2025

[Internal QA] Stage 1: Restyle drop zones #61523

Merged

50 tasks

fix: change tab after creating the expense

3544ab9

koko57 added 2 commits May 14, 2025 11:46

fix: revert podfile change

b312aca

fix: minor fix

b687360

getusha reviewed May 14, 2025

View reviewed changes

getusha approved these changes May 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[InternalQA] Add drop zone to the reports page #61916

[InternalQA] Add drop zone to the reports page #61916

koko57 commented May 13, 2025 •

edited

Loading

melvin-bot bot commented May 13, 2025

lakchote commented May 14, 2025

getusha commented May 14, 2025

getusha commented May 14, 2025

koko57 commented May 14, 2025

github-actions bot commented May 14, 2025

koko57 commented May 14, 2025

getusha May 14, 2025

koko57 May 14, 2025 •

edited

Loading

lakchote May 14, 2025

koko57 May 14, 2025

lakchote May 14, 2025

luacmartins May 14, 2025

luacmartins May 14, 2025

getusha commented May 14, 2025 •

edited

Loading

getusha May 14, 2025

getusha commented May 14, 2025

getusha left a comment

[InternalQA] Add drop zone to the reports page #61916

Are you sure you want to change the base?

[InternalQA] Add drop zone to the reports page #61916

Conversation

koko57 commented May 13, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 13, 2025

lakchote commented May 14, 2025

getusha commented May 14, 2025

getusha commented May 14, 2025

koko57 commented May 14, 2025

github-actions bot commented May 14, 2025

koko57 commented May 14, 2025

getusha May 14, 2025

Choose a reason for hiding this comment

koko57 May 14, 2025 • edited Loading

Choose a reason for hiding this comment

lakchote May 14, 2025

Choose a reason for hiding this comment

koko57 May 14, 2025

Choose a reason for hiding this comment

lakchote May 14, 2025

Choose a reason for hiding this comment

luacmartins May 14, 2025

Choose a reason for hiding this comment

luacmartins May 14, 2025

Choose a reason for hiding this comment

getusha commented May 14, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

getusha May 14, 2025

Choose a reason for hiding this comment

getusha commented May 14, 2025

getusha left a comment

Choose a reason for hiding this comment

koko57 commented May 13, 2025 •

edited

Loading

koko57 May 14, 2025 •

edited

Loading

getusha commented May 14, 2025 •

edited

Loading