Fix: Misaligned Arrow Icons in Trip Summary

[twilight2294]

Explanation of Change

Fixed Issues

$ #61740
PROPOSAL: #61740 (comment)

Tests

Same as QA step

• Verify that no errors appear in the JS console

Offline tests

Same as QA step

QA Steps

1. Open the policy expense chat with the trip summary.
2. Locate the arrows next to sections.
3. Observe the preview

Verify that Arrows should be vertically and horizontally aligned and at the center of the preview

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[twilight2294]

@shawnborton @dannymcclain @dubielzyk-expensify , can you please approve this preview :

Flight:

Train:

If you want to test more maybe you can test on adhoc build ? let me know if any changes are required

[shawnborton]

Hmm I think the idea is that the max-width of each column is 50%... for short columns, I think we want everything to feel more inline like it previously did, like so:

[dannymcclain]

Hmm I think the idea is that the max-width of each column is 50%... for short columns, I think we want everything to feel more inline like it previously did, like so:

I like this idea, but how will we keep it nice looking when one name is short and the other is long?

For example:

PDX -> Longer Name of Destination
Longer Name of Destination -> Yet Another Place

Just trying to figure out how we keep the arrows aligned when the content doesn't super match in length 🤔

[shawnborton]

Yeah, fair point. My thinking is that we should just have a max-width of 50% so that if we do need to truncate, we get even spacing. But I am definitely open to other ideas, as this is a tricky one.

[twilight2294]

Let me know which decision we land on, will update the code accordingly, should i update to max-width 50% and let you guys test it?

[shawnborton]

I'd be down with that, yeah. And then don't force the width though so we get the inline style we currently have.

[dubielzyk-expensify]

Yeah, fair point. My thinking is that we should just have a max-width of 50% so that if we do need to truncate, we get even spacing. But I am definitely open to other ideas, as this is a tricky one.

I'd be keen to see how this looks tbh. It's definitely a tricky one, but I think whats showing above when the location string is short looks a bit off.

[twilight2294]

@shawnborton @dannymcclain @dubielzyk-expensify Is it okay now?:

Maximum width of startName:

Medium width of startName:

Small startName but long endName:

Flight:

[twilight2294]

I think it would be better if you can trigger ad-hoc build and test this one as it is a little tricky one

[shawnborton]

I think what you have above looks better... again, recognizing that this one is tricky and we don't have a great solution for now. I think in the future, we might re-style these trip preview cards to be more akin to a report preview, but I think this works for now.

In the meantime, I will run a new test build for us.

[github-actions]

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/61901-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/61901-hybrid/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/61901/NewExpensify.dmg	https://61901.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[twilight2294]

@shawnborton @dannymcclain @dubielzyk-expensify can any of you test it with real data and confirm this one please