Fix: Misaligned Arrow Icons in Trip Summary #61901

twilight2294 · 2025-05-13T10:45:01Z

Explanation of Change

Fixed Issues

$ #61740
PROPOSAL: #61740 (comment)

Tests

Same as QA step

Verify that no errors appear in the JS console

Offline tests

Same as QA step

QA Steps

Open the policy expense chat with the trip summary.
Locate the arrows next to sections.
Observe the preview

Verify that Arrows should be vertically and horizontally aligned and at the center of the preview if the text is large

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-05-13T10:47:44Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

twilight2294 · 2025-05-13T11:09:40Z

@shawnborton @dannymcclain @dubielzyk-expensify , can you please approve this preview :

Flight:

Train:

If you want to test more maybe you can test on adhoc build ? let me know if any changes are required

shawnborton · 2025-05-13T12:59:15Z

Hmm I think the idea is that the max-width of each column is 50%... for short columns, I think we want everything to feel more inline like it previously did, like so:

dannymcclain · 2025-05-13T13:03:38Z

Hmm I think the idea is that the max-width of each column is 50%... for short columns, I think we want everything to feel more inline like it previously did, like so:

I like this idea, but how will we keep it nice looking when one name is short and the other is long?

For example:

PDX -> Longer Name of Destination
Longer Name of Destination -> Yet Another Place

Just trying to figure out how we keep the arrows aligned when the content doesn't super match in length 🤔

shawnborton · 2025-05-13T13:08:17Z

Yeah, fair point. My thinking is that we should just have a max-width of 50% so that if we do need to truncate, we get even spacing. But I am definitely open to other ideas, as this is a tricky one.

twilight2294 · 2025-05-13T13:11:02Z

Let me know which decision we land on, will update the code accordingly, should i update to max-width 50% and let you guys test it?

shawnborton · 2025-05-13T13:12:50Z

I'd be down with that, yeah. And then don't force the width though so we get the inline style we currently have.

dubielzyk-expensify · 2025-05-14T00:38:42Z

Yeah, fair point. My thinking is that we should just have a max-width of 50% so that if we do need to truncate, we get even spacing. But I am definitely open to other ideas, as this is a tricky one.

I'd be keen to see how this looks tbh. It's definitely a tricky one, but I think whats showing above when the location string is short looks a bit off.

twilight2294 · 2025-05-14T05:31:12Z

@shawnborton @dannymcclain @dubielzyk-expensify Is it okay now?:

Maximum width of startName:

Medium width of startName:

Small startName but long endName:

Flight:

twilight2294 · 2025-05-14T05:31:40Z

I think it would be better if you can trigger ad-hoc build and test this one as it is a little tricky one

shawnborton · 2025-05-14T09:33:02Z

I think what you have above looks better... again, recognizing that this one is tricky and we don't have a great solution for now. I think in the future, we might re-style these trip preview cards to be more akin to a report preview, but I think this works for now.

In the meantime, I will run a new test build for us.

github-actions · 2025-05-14T09:33:30Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-05-14T10:15:50Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/61901-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/61901-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/61901/NewExpensify.dmg	https://61901.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

twilight2294 · 2025-05-14T19:54:53Z

@shawnborton @dannymcclain @dubielzyk-expensify can any of you test it with real data and confirm this one please

dubielzyk-expensify · 2025-05-15T03:32:28Z

My trip views have become buggy so I can't test. I'll leave this one to @dannymcclain and @shawnborton

shawnborton · 2025-05-15T08:18:08Z

I checked and I don't really have any good trips in my account to test with either.

shawnborton · 2025-05-15T08:19:21Z

Works fine for simple airport codes though:

Ollyws · 2025-05-15T10:02:13Z

Here's a few more examples if it's any help.

twilight2294 · 2025-05-15T10:44:33Z

@Ollyws I think we can proceed with the checklist now

dannymcclain · 2025-05-15T12:46:45Z

My account doesn't have any trip rooms/summaries 🙁 but that screenshot is looking how I would expect it to.

shawnborton · 2025-05-15T13:14:03Z

Yeah that checks out to me too 👍

Ollyws · 2025-05-15T16:20:37Z

src/styles/index.ts

@@ -1623,6 +1623,12 @@ const styles = (theme: ThemeColors) =>
            alignItems: 'center',
        },

+        travelArrowCenter: {


We can get rid of this if we're not using it anymore.

src/styles/index.ts

twilight2294 · 2025-05-15T16:48:15Z

@Ollyws done!

Ollyws · 2025-05-15T17:08:48Z

@twilight2294 For me the arrow is overlapping on iOS:

twilight2294 · 2025-05-22T21:32:14Z

Looking

Ollyws · 2025-05-28T08:42:46Z

any progress @twilight2294 ?

shawnborton · 2025-06-02T08:10:07Z

What's the latest here? Let's get this over the finish line please!

twilight2294 · 2025-06-02T18:27:51Z

fixing the issue for small devices !, will update with latest results tomorrow

stitesExpensify · 2025-06-09T21:19:19Z

@twilight2294 any update?

twilight2294 · 2025-06-10T10:04:06Z

@Ollyws can you retest please

Ollyws · 2025-06-10T11:21:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Ollyws

LGTM.

rafecolton

The arrow is overlapping the text in the Android HybridApp screenshot

Ollyws · 2025-06-10T17:17:55Z

@rafecolton Woops that was an old screenshot, updated.

rafecolton

Much better! 😄

OSBotify · 2025-06-10T18:18:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-10T23:06:02Z

🚀 Deployed to staging by https://github.com/rafecolton in version: 9.1.64-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-11T21:59:55Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.64-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

twilight2294 added 2 commits May 13, 2025 16:14

update style of preview

fccc405

include new style for travel preview

87784d4

twilight2294 marked this pull request as ready for review May 13, 2025 10:47

twilight2294 requested review from a team as code owners May 13, 2025 10:47

melvin-bot bot requested review from Ollyws and removed request for a team May 13, 2025 10:47

twilight2294 mentioned this pull request May 13, 2025

[Due for payment 2025-06-18] [$250] Misaligned Arrow Icons in Trip Summary #61740

Closed

16 tasks

twilight2294 changed the title ~~update style of preview~~ Fix: Misaligned Arrow Icons in Trip Summary May 13, 2025

twilight2294 added 2 commits May 14, 2025 11:00

use tripReservationRow

2c72d8d

update style to increase startName and arrow width to 50%

9304d89

Ollyws reviewed May 15, 2025

View reviewed changes

twilight2294 commented May 15, 2025

View reviewed changes

src/styles/index.ts Outdated Show resolved Hide resolved

Update src/styles/index.ts

2d6458a

Merge branch 'Expensify:main' into patch-37

953924b

twilight2294 added 2 commits June 10, 2025 15:31

Merge branch 'Expensify:main' into patch-37

4aaeb85

Fix mobile view for trip preview

846ebcb

remove extra styles

d02325e

Ollyws approved these changes Jun 10, 2025

View reviewed changes

melvin-bot bot requested a review from rafecolton June 10, 2025 11:23

rafecolton assigned twilight2294 Jun 10, 2025

rafecolton requested changes Jun 10, 2025

View reviewed changes

rafecolton approved these changes Jun 10, 2025

View reviewed changes

rafecolton merged commit e5201c3 into Expensify:main Jun 10, 2025
19 checks passed

github-actions bot mentioned this pull request Jun 10, 2025

Deploy Checklist: New Expensify 2025-06-10 #63891

Closed

82 tasks

Fix: Misaligned Arrow Icons in Trip Summary #61901

Fix: Misaligned Arrow Icons in Trip Summary #61901

Uh oh!

Conversation

twilight2294 commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 13, 2025

Uh oh!

twilight2294 commented May 13, 2025

Uh oh!

shawnborton commented May 13, 2025

Uh oh!

dannymcclain commented May 13, 2025

Uh oh!

shawnborton commented May 13, 2025

Uh oh!

twilight2294 commented May 13, 2025

Uh oh!

shawnborton commented May 13, 2025

Uh oh!

dubielzyk-expensify commented May 14, 2025

Uh oh!

twilight2294 commented May 14, 2025

Uh oh!

twilight2294 commented May 14, 2025

Uh oh!

shawnborton commented May 14, 2025

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

twilight2294 commented May 14, 2025

Uh oh!

dubielzyk-expensify commented May 15, 2025

Uh oh!

shawnborton commented May 15, 2025

Uh oh!

shawnborton commented May 15, 2025

Uh oh!

Ollyws commented May 15, 2025

Uh oh!

twilight2294 commented May 15, 2025

Uh oh!

dannymcclain commented May 15, 2025

Uh oh!

shawnborton commented May 15, 2025

Uh oh!

Ollyws May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

twilight2294 commented May 15, 2025

Uh oh!

Ollyws commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twilight2294 commented May 22, 2025

Uh oh!

Ollyws commented May 28, 2025

Uh oh!

shawnborton commented Jun 2, 2025

Uh oh!

twilight2294 commented Jun 2, 2025

Uh oh!

stitesExpensify commented Jun 9, 2025

Uh oh!

twilight2294 commented Jun 10, 2025

Uh oh!

Ollyws commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

twilight2294 commented May 13, 2025 •

edited

Loading

Ollyws commented May 15, 2025 •

edited

Loading

Ollyws commented Jun 10, 2025 •

edited

Loading