Skip to content

fix isssue migrated user welcome modal no response #61886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ROUTES.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1977,7 +1977,10 @@ const ROUTES = {
route: 'workspace/confirmation',
getRoute: (backTo?: string) => getUrlWithBackToParam(`workspace/confirmation`, backTo),
},
MIGRATED_USER_WELCOME_MODAL: 'onboarding/migrated-user-welcome',
MIGRATED_USER_WELCOME_MODAL: {
route: 'onboarding/migrated-user-welcome',
getRoute: (isFromRoot?: boolean) => getUrlWithBackToParam(`onboarding/migrated-user-welcome?${isFromRoot ? 'isFromRoot=true' : ''}`, undefined, false),
},

TEST_TOOLS_MODAL: 'test-tools',

Expand Down
13 changes: 10 additions & 3 deletions src/components/MigratedUserWelcomeModal.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import {useRoute} from '@react-navigation/native';
import React, {useEffect, useLayoutEffect, useState} from 'react';
import {View} from 'react-native';
import {useOnyx} from 'react-native-onyx';
Expand All @@ -9,12 +10,15 @@ import {dismissProductTraining} from '@libs/actions/Welcome';
import convertToLTR from '@libs/convertToLTR';
import {parseFSAttributes} from '@libs/Fullstory';
import Navigation from '@libs/Navigation/Navigation';
import type {PlatformStackRouteProp} from '@libs/Navigation/PlatformStackNavigation/types';
import type {WelcomeVideoModalNavigatorParamList} from '@libs/Navigation/types';
import {tryNewDotOnyxSelector} from '@libs/onboardingSelectors';
import {buildCannedSearchQuery} from '@libs/SearchQueryUtils';
import variables from '@styles/variables';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import ROUTES from '@src/ROUTES';
import type SCREENS from '@src/SCREENS';
import isLoadingOnyxValue from '@src/types/utils/isLoadingOnyxValue';
import type {FeatureListItem} from './FeatureList';
import FeatureTrainingModal from './FeatureTrainingModal';
Expand Down Expand Up @@ -44,25 +48,28 @@ function OnboardingWelcomeVideo() {
const StyleUtils = useStyleUtils();
const {shouldUseNarrowLayout} = useResponsiveLayout();
const [isModalDisabled, setIsModalDisabled] = useState(true);
const route = useRoute<PlatformStackRouteProp<WelcomeVideoModalNavigatorParamList, typeof SCREENS.WELCOME_VIDEO.ROOT>>();
const isFromRoot = route?.params?.isFromRoot === 'true';

const [tryNewDot, tryNewDotMetadata] = useOnyx(ONYXKEYS.NVP_TRY_NEW_DOT, {
selector: tryNewDotOnyxSelector,
canBeMissing: true,
});
const [dismissedProductTraining, dismissedProductTrainingMetadata] = useOnyx(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING);
const [dismissedProductTraining, dismissedProductTrainingMetadata] = useOnyx(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, {canBeMissing: true});

useEffect(() => {
if (isLoadingOnyxValue(tryNewDotMetadata, dismissedProductTrainingMetadata)) {
return;
}
const {hasBeenAddedToNudgeMigration} = tryNewDot ?? {};

if (hasBeenAddedToNudgeMigration && !dismissedProductTraining?.migratedUserWelcomeModal) {
if (!!(hasBeenAddedToNudgeMigration && !dismissedProductTraining?.migratedUserWelcomeModal) || isFromRoot) {
return;
}
setIsModalDisabled(false);
const defaultCannedQuery = buildCannedSearchQuery();
Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: defaultCannedQuery}));
}, [dismissedProductTraining?.migratedUserWelcomeModal, setIsModalDisabled, tryNewDotMetadata, dismissedProductTrainingMetadata, tryNewDot]);
}, [dismissedProductTraining?.migratedUserWelcomeModal, setIsModalDisabled, tryNewDotMetadata, dismissedProductTrainingMetadata, tryNewDot, isFromRoot]);

/**
* Extracts values from the non-scraped attribute WEB_PROP_ATTR at build time
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useOnboardingFlow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function useOnboardingFlowRouter() {
const defaultCannedQuery = buildCannedSearchQuery();
const query = defaultCannedQuery;
Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query}));
Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL);
Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute());
return;
}

Expand Down
6 changes: 5 additions & 1 deletion src/libs/Navigation/NavigationRoot.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,11 @@ function NavigationRoot({authenticated, lastVisitedPath, initialUrl, onReady}: N

const initialState = useMemo(() => {
const path = initialUrl ? getPathFromURL(initialUrl) : null;
if (path?.includes(ROUTES.MIGRATED_USER_WELCOME_MODAL) && lastVisitedPath && isOnboardingCompleted && authenticated) {
if (path?.includes(ROUTES.MIGRATED_USER_WELCOME_MODAL.route) && lastVisitedPath && isOnboardingCompleted && authenticated) {
Navigation.isNavigationReady().then(() => {
Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute(true));
});

return getAdaptedStateFromPath(lastVisitedPath, linkingConfig.config);
}

Expand Down
2 changes: 1 addition & 1 deletion src/libs/Navigation/linkingConfig/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const config: LinkingOptions<RootNavigatorParamList>['config'] = {
[NAVIGATORS.MIGRATED_USER_MODAL_NAVIGATOR]: {
screens: {
[SCREENS.MIGRATED_USER_WELCOME_MODAL.ROOT]: {
path: ROUTES.MIGRATED_USER_WELCOME_MODAL,
path: ROUTES.MIGRATED_USER_WELCOME_MODAL.route,
exact: true,
},
},
Expand Down
4 changes: 3 additions & 1 deletion src/libs/Navigation/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1797,7 +1797,9 @@ type OnboardingModalNavigatorParamList = {
};

type WelcomeVideoModalNavigatorParamList = {
[SCREENS.WELCOME_VIDEO.ROOT]: undefined;
[SCREENS.WELCOME_VIDEO.ROOT]: {
isFromRoot?: string;
};
};

type ExplanationModalNavigatorParamList = {
Expand Down