Migrate RN Gesture Handler in AttachmentCarouselPager to Gestures API #61841

JakubKorytko · 2025-05-12T08:47:01Z

Explanation of Change

Some parts of the react-native-gesture-handler used in AttachmentCarouselPager are deprecated and should be migrated to the new Gestures API. This causes ESLint checks to fail.

App/src/components/Attachments/AttachmentCarousel/Pager/index.tsx

Lines 5 to 6 in c74a7db

    
           import type {NativeViewGestureHandlerProps} from 'react-native-gesture-handler'; 
        
           import {createNativeWrapper} from 'react-native-gesture-handler';

Fixed Issues

$ N/A
PROPOSAL: N/A

Tests

Open the native version of the Expensify app.
Open the attachment carousel in any section of the app (e.g. chats, expenses or reports).
Verify that gestures works properly (you can scroll through it, tap on clickable elements etc.) and that nothing unexpected happens.
If a problem is found, verify that this didn't occur before migration to rule out the possibility of a new issue unrelated to the migration.

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-05-12T10:50:10Z

@Valforte Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-05-12T20:20:42Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

mountiny · 2025-05-12T20:20:47Z

@hungvu193 can you please test this one too?

github-actions · 2025-05-12T21:01:28Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/61841-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/61841-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/61841/NewExpensify.dmg	https://61841.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

hungvu193 · 2025-05-13T01:53:43Z

@hungvu193 can you please test this one too?

Sure

hungvu193 · 2025-05-13T02:57:02Z

@JakubKorytko Sometimes I can't swipe left or right:

PR.mov

Here's on main:

main.mov

JakubKorytko · 2025-05-13T12:47:52Z

@hungvu193 The issue has now been resolved. I tested it on all platforms and didn't encounter any problems.

hungvu193 · 2025-05-14T03:47:59Z

@JakubKorytko Can you merge main? Tests are failing

hungvu193 · 2025-05-14T06:22:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mov

Android: mWeb Chrome

mChrome.mov

iOS: HybridApp

IOS.mov

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Screen.Recording.2025-05-14.at.11.01.49.mov

hungvu193

Test well!

melvin-bot · 2025-05-14T06:22:58Z

🎯 @hungvu193, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #61992.

mountiny

Lgtm thank you

Valforte · 2025-05-14T16:09:17Z

There are conflicts to merge, @JakubKorytko can you merge main into your branch?

JakubKorytko · 2025-05-14T17:11:46Z

@Valforte @mountiny Merged, resolved.

mountiny

Thanks!

Valforte

LGTM

OSBotify · 2025-05-14T19:33:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Replace old gesture handler with new one

10547df

JakubKorytko force-pushed the korytko/migrate-attachment-carousel-pager-RNGH branch from 61bc55a to 10547df Compare May 12, 2025 10:34

JakubKorytko changed the title ~~[WIP] Migrate RN Gesture Handler in AttachmentCarouselPager to Gestures API~~ Migrate RN Gesture Handler in AttachmentCarouselPager to Gestures API May 12, 2025

JakubKorytko marked this pull request as ready for review May 12, 2025 10:49

JakubKorytko requested a review from a team as a code owner May 12, 2025 10:49

melvin-bot bot requested review from Valforte and removed request for a team May 12, 2025 10:50

JakubKorytko mentioned this pull request May 12, 2025

[$250] Attachment - Attachment not found text moves, download modal not shown for broken image #60554

Open

8 tasks

mountiny requested review from hungvu193 and mountiny May 12, 2025 20:20

mountiny assigned JakubKorytko May 12, 2025

JakubKorytko added 4 commits May 13, 2025 08:01

Merge branch 'main' into korytko/migrate-attachment-carousel-pager-RNGH

e20aef5

Merge branch 'main' into korytko/migrate-attachment-carousel-pager-RNGH

31b2557

Fix carousel panning on native

8e8e2bf

Fix ESLint error

d39d6ea

Merge branch 'main' into korytko/migrate-attachment-carousel-pager-RNGH

03b908e

hungvu193 approved these changes May 14, 2025

View reviewed changes

melvin-bot bot mentioned this pull request May 14, 2025

Payment issue for E/App PR#61841 #61992

Open

mountiny previously approved these changes May 14, 2025

View reviewed changes

Merge branch 'main' into korytko/migrate-attachment-carousel-pager-RNGH

7c38385

JakubKorytko dismissed mountiny’s stale review via 7c38385 May 14, 2025 17:10

mountiny approved these changes May 14, 2025

View reviewed changes

Valforte approved these changes May 14, 2025

View reviewed changes

Valforte merged commit 62e97cc into Expensify:main May 14, 2025
18 checks passed

francoisl mentioned this pull request May 16, 2025

Deploy Checklist: New Expensify 2025-05-15 #62161

Open

79 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate RN Gesture Handler in AttachmentCarouselPager to Gestures API #61841

Migrate RN Gesture Handler in AttachmentCarouselPager to Gestures API #61841

JakubKorytko commented May 12, 2025 •

edited

Loading

melvin-bot bot commented May 12, 2025

github-actions bot commented May 12, 2025

mountiny commented May 12, 2025

github-actions bot commented May 12, 2025

hungvu193 commented May 13, 2025 •

edited

Loading

hungvu193 commented May 13, 2025

JakubKorytko commented May 13, 2025

hungvu193 commented May 14, 2025

hungvu193 commented May 14, 2025

hungvu193 left a comment

melvin-bot bot commented May 14, 2025

mountiny left a comment

Valforte commented May 14, 2025

JakubKorytko commented May 14, 2025

mountiny left a comment

Valforte left a comment

OSBotify commented May 14, 2025

	import type {NativeViewGestureHandlerProps} from 'react-native-gesture-handler';
	import {createNativeWrapper} from 'react-native-gesture-handler';

Migrate RN Gesture Handler in AttachmentCarouselPager to Gestures API #61841

Migrate RN Gesture Handler in AttachmentCarouselPager to Gestures API #61841

Conversation

JakubKorytko commented May 12, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 12, 2025

github-actions bot commented May 12, 2025

mountiny commented May 12, 2025

github-actions bot commented May 12, 2025

hungvu193 commented May 13, 2025 • edited Loading

hungvu193 commented May 13, 2025

JakubKorytko commented May 13, 2025

hungvu193 commented May 14, 2025

hungvu193 commented May 14, 2025

Reviewer Checklist

Screenshots/Videos

hungvu193 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 14, 2025

mountiny left a comment

Choose a reason for hiding this comment

Valforte commented May 14, 2025

JakubKorytko commented May 14, 2025

mountiny left a comment

Choose a reason for hiding this comment

Valforte left a comment

Choose a reason for hiding this comment

OSBotify commented May 14, 2025

JakubKorytko commented May 12, 2025 •

edited

Loading

hungvu193 commented May 13, 2025 •

edited

Loading