-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Optimize Reports view to prevent memory leaks after long usage #61771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Reports view to prevent memory leaks after long usage #61771
Conversation
@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb Chromeandroid-web.moviOS: HybridAppios.moviOS: mWeb Safariios-web.movMacOS: Chrome / Safariweb.movMacOS: Desktopweb.mov |
And weird 2025-05-12.15.31.46.mov |
@ZhenjaHorbach does it work on |
@ZhenjaHorbach I tested this. And views worked properly on this branch before merge from main. This error comes from |
We still have this issue |
Reassure tests fails.
Cause of this test to fail is in this commit. Previously We cannot use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @vit / @techievivek do you want to do a final review before merge?
@sosek108 what do you think about the suggestion from Aldo? |
@aldo-expensify You're right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Lets try this out
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊 (1/13)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (10/13)Meaningless Changes To Duration (9/12)Show entries
Show details
|
Performance Comparison Report 📊 (11/13)Meaningless Changes To Duration (10/12)Show entries
Show details
|
Performance Comparison Report 📊 (12/13)Meaningless Changes To Duration (11/12)Show entries
Show details
|
Performance Comparison Report 📊 (13/13)Meaningless Changes To Duration (12/12)Show entries
Show details
|
Performance Comparison Report 📊 (2/13)Meaningless Changes To Duration (1/12)Show entries
Show details
|
Performance Comparison Report 📊 (3/13)Meaningless Changes To Duration (2/12)Show entries
Show details
|
Performance Comparison Report 📊 (4/13)Meaningless Changes To Duration (3/12)Show entries
Show details
|
Performance Comparison Report 📊 (5/13)Meaningless Changes To Duration (4/12)Show entries
Show details
|
Performance Comparison Report 📊 (6/13)Meaningless Changes To Duration (5/12)Show entries
Show details
|
Performance Comparison Report 📊 (7/13)Meaningless Changes To Duration (6/12)Show entries
Show details
|
Performance Comparison Report 📊 (8/13)Meaningless Changes To Duration (7/12)Show entries
Show details
|
Performance Comparison Report 📊 (9/13)Meaningless Changes To Duration (8/12)Show entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
If the performance issues are real, we could look into doing this: #61771 (comment), but disabling the lint for the specific lines because we know it is fine 🤷 |
I'm fine with that |
Yeah its hard to say now if these reported regressions are indeed correct cc @chrispader |
looking into it |
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.46-12 🚀
|
PR 61771
Explanation of Change
This PR introduces disposal functionality to
FastSearch
object. This is required to proper memory management on Reports view.Fixed Issues
$ #60889
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2025-05-12.o.10.53.19.mov
MacOS: Desktop