-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Delete & Hold are present when there are two expense previews, app crashes with Hold option #61761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete & Hold are present when there are two expense previews, app crashes with Hold option #61761
Conversation
@brunovjk I got this error unit test from main |
@thelullabyy, I'm a bit confused, but it seems to me that the delete option was removed in more places than the scope of the issue? MacOS: Chrome / Safari - Latest mainScreen.Recording.2025-05-09.at.12.47.54.movMacOS: Chrome / Safarib - This PRScreen.Recording.2025-05-09.at.14.33.04.mov |
@brunovjk Oh yeaa, I forgot to check the condition when not passing reportActions. This is fixed. Pls help to check again. |
Great! I will review it ASAP |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp61761_android_native.movAndroid: mWeb Chrome61761_android_web.moviOS: HybridApp61761_ios_native.moviOS: mWeb Safari61761_ios_web.movMacOS: Chrome / Safari61761_web_chrome.movMacOS: Desktop61761_web_desktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Before merging, @thelullabyy please update the Steps to Test this PR according to the original issue, I believe we have to add the "Precondition" to use an Expensifail or an account with beta permissions, what do you think?
@brunovjk Sure, i added it |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@thelullabyy @brunovjk @francoisl Hold and Delete are still present in More options. It is expected now, right? Screen.Recording.2025-05-16.at.7.09.47.PM.mp4 |
This should be ready to retest once 9.1.46-12 is available. |
@francoisl we are still seeing this in 9.1.46-12 Screen.Recording.2025-05-20.at.9.52.57.AM.mov |
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.46-12 🚀
|
Explanation of Change
Fixed Issues
$#61448
PROPOSAL:#61448 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectioncanBeMissing
param foruseOnyx
toggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android_native.mov
Android: mWeb Chrome
android.mov
iOS: Native
ios.mp4
iOS: mWeb Safari
ios_safari.mov
MacOS: Chrome / Safari
chorme.mp4
MacOS: Desktop
desktop.mp4