-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[HOLD] Consume prebuilt react-native artifacts #61703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[HOLD] Consume prebuilt react-native artifacts #61703
Conversation
|
patchedArtifacts.packageName=react-standalone | ||
|
||
# Change this property to false if you want to use prebuilt react-native artifacts. | ||
patchedArtifacts.forceBuildFromSource=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roryabraham I've disabled prebuilt artifacts by default.
I suggest we merge this PR first and then I can test it internally within the team. Once we're confident about the entire flow, we can create a PR to enable prebuilt artifacts by default.
To use prebuilt artifacts, devs will need to configure GitHub CLI. The plugin will display a log about misconfigured CLI and fall back to building from source (once we switch patchedArtifacts.forceBuildFromSource
to false
).
Explanation of Change
This PR is currently blocked by:
publish.gradle
patch andpublishReactNativeAndroidArtifacts.yml
#61779TO DO:
react-native
)README
hasDiff
function.Fixed Issues
$ #57120
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13563
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectioncanBeMissing
param foruseOnyx
toggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop