Skip to content

update all references of workspace chat to expense chat #61529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -621,8 +621,8 @@ Updated rules for managing members across all types of chats in New Expensify.
- **Nobody can leave or be removed from something they were automatically added to. For example:**

- DM members can't leave or be removed from their DMs
- Members can't leave or be removed from their own workspace chats
- Admins can't leave or be removed from workspace chats
- Members can't leave or be removed from their own expense chats
- Admins can't leave or be removed from expense chats
- Members can't leave or be removed from the #announce room
- Admins can't leave or be removed from #admins
- Domain members can't leave or be removed from their domain chat
Expand Down Expand Up @@ -691,18 +691,18 @@ Updated rules for managing members across all types of chats in New Expensify.
- Everyone can be removed/can leave from the room including creator
- Guests are not able to remove anyone from the room

4. #### Workspace chats
4. #### Expense chats
| | Admin | Member(default) | Member(invited) |
| :----------------: | :---: | :-------------: | :-------------: |
| **Invite** | ✅ | ✅ | ❌ |
| **Remove** | ✅ | ✅ | ❌ |
| **Leave** | ❌ | ❌ | ✅ |
| **Can be removed** | ❌ | ❌ | ✅ |

- Admins are not able to leave/be removed from the workspace chat
- Default members(automatically invited) are not able to leave/be removed from the workspace chat
- Invited members(invited by members) are not able to invite or remove from the workspace chat
- Invited members(invited by members) are able to leave the workspace chat
- Admins are not able to leave/be removed from the expense chat
- Default members(automatically invited) are not able to leave/be removed from the expense chat
- Invited members(invited by members) are not able to invite or remove from the expense chat
- Invited members(invited by members) are able to leave the expense chat
- Default members and admins are able to remove invited members

3. ### Domain chat
Expand Down
2 changes: 1 addition & 1 deletion contributingGuides/NAVIGATION_TESTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ Linked issue: https://github.com/Expensify/App/pull/49539#issuecomment-243240081

1. Launch the app.
2. Open FAB > Submit expense > Manual.
3. Submit a manual expense to any user (as long as the user is not the currently opened report and the receiver is not workspace chat).
3. Submit a manual expense to any user (as long as the user is not the currently opened report and the receiver is not expense chat).
4. Verify if the destination report is opened after submitting expense.

#### QBO - Preferred exporter/Export date tab do not auto-close after value selected
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ If unresolved, contact Concierge with details and QuickBooks screenshots.

# Export or "can't find category/class/location/account" issues

These errors usually generate a system message in Workspace Chat indicating the issue.
These errors usually generate a system message in Expense Chat indicating the issue.

## How to resolve

Expand Down Expand Up @@ -120,6 +120,6 @@ Usually caused by the Web Connector or QuickBooks company file being closed duri

![Web Connector Status](https://help.expensify.com/assets/images/quickbooks-desktop-web-connector.png){:width="100%"}

3. Check Workspace Chat in Expensify to confirm successful export.
3. Check Expense Chat in Expensify to confirm successful export.

If unresolved, contact Concierge with Expensify Report ID and Web Connector screenshot.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Occasionally, you might run into errors when exporting reports or syncing QuickB
If an error occurs during an automatic export to QuickBooks Online:

- You’ll receive an email detailing the error.
- The error will appear in the related Workspace Chat, indicated by a red dot next to the report.
- The error will appear in the related Expense Chat, indicated by a red dot next to the report.
- For auto-sync errors, a message will be posted in the related #admins room. The message contains a link to the workspace’s accounting settings where an explanation for the error appears next to the connection.

An error on a report will prevent it from automatically exporting.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ description: More to Come Soon
If an error occurs during an automatic export to Xero:

- You'll receive an email detailing the error.
- The error will appear in the related Workspace Chat, indicated by a red dot next to the report.
- The error will appear in the related Expense Chat, indicated by a red dot next to the report.
- For auto-sync errors, a message will be posted in the related #admins room. The message contains a link to the workspace's accounting settings where an explanation for the error appears next to the connection.

An error on a report will prevent it from automatically exporting.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ There are two steps to enable Expensify Card notifications. You’ll first enabl
{% include option.html value="desktop" %}
1. From your Expensify Chat inbox, click the dropdown on the logo or avatar that is in the top left corner.
2. Select the workspace you want to update the notification settings for.
3. Click the workspace chat in your inbox (it will be the chat that has your workspace’s name as the chat title).
3. Click the expense chat in your inbox (it will be the chat that has your workspace’s name as the chat title).
4. Click the header at the top of the chat.
5. Click **Settings**.
6. Click **Notify me about new messages** and select **Immediately**.
Expand All @@ -27,7 +27,7 @@ There are two steps to enable Expensify Card notifications. You’ll first enabl
{% include option.html value="mobile" %}
1. From your Expensify Chat inbox, tap the dropdown on the logo or avatar that is in the top left corner.
2. Select the workspace you want to update the notification settings for.
3. Tap the workspace chat in your inbox (it will be the chat that has your workspace’s name as the chat title).
3. Tap the expense chat in your inbox (it will be the chat that has your workspace’s name as the chat title).
4. Tap the header at the top of the chat.
5. Tap **Settings**.
6. Tap **Notify me about new messages** and select **Immediately**.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ SmartScan reads receipt details like merchant, date, total, and currency automat
4. Select your **workspace**.
5. Click **Create expense**.

You can view expenses in your Workspace chat or the **Reports** page. [Export to CSV](https://help.expensify.com/articles/new-expensify/expenses-and-payments/Search-and-Download-Expenses) for tax or accountant use.
You can view expenses in your Expense chat or the **Reports** page. [Export to CSV](https://help.expensify.com/articles/new-expensify/expenses-and-payments/Search-and-Download-Expenses) for tax or accountant use.

---

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Tracking an expense in Expensify is simple and can be done in just a few steps.

## Where to Find Tracked Expenses

Once the expense is created, it will appear in your **Workspace Chat** in the left-hand navigation. Within the workspace chat, you can take the following further actions on the expense at any time:
Once the expense is created, it will appear in your **Expense Chat** in the left-hand navigation. Within the expense chat, you can take the following further actions on the expense at any time:

- **Submit it to someone** – Send the expense for approval or processing.
- **Categorize it** – Assign the expense to a category for better organization.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ Approvers can also edit categories on the submitter’s behalf, even after appro

**Can I see an audit trail of category changes on an expense?**

Yes. When a category is manually edited, Expensify will log the change in the related workspace chat.
Yes. When a category is manually edited, Expensify will log the change in the related expense chat.

**If I change categories in my accounting system, what happens to categories in the workspace?**

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ Approvers can also edit tags on the submitter’s behalf, even after approval. I

**Can I see an audit trail of tag changes on an expense?**

Yes. When a tag is manually edited, Expensify will log the change in the related workspace chat.
Yes. When a tag is manually edited, Expensify will log the change in the related expense chat.

**If I change tags in my accounting system, what happens to tags in the workspace?**

Expand Down
2 changes: 1 addition & 1 deletion help/card.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ To receive real-time notifications for spending activity on your Expensify Card,

1. From your Expensify Chat inbox, press the dropdown on the logo or avatar in the top left corner.
2. Select the workspace you want to update the notification settings for.
3. Press the workspace chat in your inbox (the chat with your workspace’s name as the title).
3. Press the expense chat in your inbox (the chat with your workspace’s name as the title).
4. Press the header at the top of the chat.
5. Press **Settings**.
6. Press **Notify me about new messages** and select **Immediately**.
Expand Down
4 changes: 2 additions & 2 deletions help/expense.md
Original file line number Diff line number Diff line change
Expand Up @@ -642,14 +642,14 @@ To export your expense data to a CSV file:

#### [Exporting Reports to Xero] How do I export reports to Xero manually?
If an error occurs during an automatic export to Xero:
1. Check your email or the related Workspace Chat for error notifications.
1. Check your email or the related Expense Chat for error notifications.
2. Resolve the issue by opening the expense and making necessary changes.
3. Ensure the report is in the Approved, Closed, or Reimbursed state.
4. An admin must press the heading at the top of the expense, select **Export**, and then choose **Xero**.

#### [Exporting Reports to QuickBooks Online] How do I manually export reports to QuickBooks Online?
If an error occurs during an automatic export to QuickBooks Online:
1. Check your email or the related Workspace Chat for error notifications.
1. Check your email or the related Expense Chat for error notifications.
2. Open the expense and make necessary changes.
3. Ensure the report is in the Approved, Closed, or Reimbursed state.
4. An admin must press the heading at the top of the expense, select **Export**, and then choose **QuickBooks Online**.
Expand Down
2 changes: 1 addition & 1 deletion help/map.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Lost in the app? Let this map guide you!
* Chat selector
* Special chats:
* Concierge
* Workspace chat
* Expense chat
* #announce
* #admins
* Personal chat
Expand Down
4 changes: 2 additions & 2 deletions src/components/MoneyRequestConfirmationList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ type MoneyRequestConfirmationListProps = {
/** Whether we should show the amount, date, and merchant fields. */
shouldShowSmartScanFields?: boolean;

/** A flag for verifying that the current report is a sub-report of a workspace chat */
/** A flag for verifying that the current report is a sub-report of a expense chat */
isPolicyExpenseChat?: boolean;

/** Whether smart scan failed */
Expand Down Expand Up @@ -388,7 +388,7 @@ function MoneyRequestConfirmationList({
}, [isFocused, transaction, shouldDisplayFieldError, hasSmartScanFailed, didConfirmSplit]);

useEffect(() => {
// We want this effect to run only when the transaction is moving from Self DM to a workspace chat
// We want this effect to run only when the transaction is moving from Self DM to a expense chat
if (!transactionID || !isDistanceRequest || !isMovingTransactionFromTrackExpense || !isPolicyExpenseChat) {
return;
}
Expand Down
4 changes: 2 additions & 2 deletions src/components/ReportActionItem/MoneyRequestView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ function MoneyRequestView({report, shouldShowAnimatedBackground, readonly = fals
const canEditDistanceRate = canUserPerformWriteAction && canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE_RATE);
const canEditReport = canUserPerformWriteAction && canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.REPORT);

// A flag for verifying that the current report is a sub-report of a workspace chat
// if the policy of the report is either Collect or Control, then this report must be tied to workspace chat
// A flag for verifying that the current report is a sub-report of a expense chat
// if the policy of the report is either Collect or Control, then this report must be tied to expense chat
const isPolicyExpenseChat = isReportInGroupPolicy(report);

const policyTagLists = useMemo(() => getTagLists(policyTagList), [policyTagList]);
Expand Down
6 changes: 3 additions & 3 deletions src/languages/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5129,12 +5129,12 @@ const translations = {
joinedNames = `${submittersNames.slice(0, submittersNames.length - 1).join(', ')} and ${submittersNames.at(-1)}`;
}
return {
one: `removed you from ${joinedNames}'s approval workflow and workspace chat. Previously submitted reports will remain available for approval in your Inbox.`,
other: `removed you from ${joinedNames}'s approval workflows and workspace chats. Previously submitted reports will remain available for approval in your Inbox.`,
one: `removed you from ${joinedNames}'s approval workflow and expense chat. Previously submitted reports will remain available for approval in your Inbox.`,
other: `removed you from ${joinedNames}'s approval workflows and expense chats. Previously submitted reports will remain available for approval in your Inbox.`,
};
},
demotedFromWorkspace: ({policyName, oldRole}: DemotedFromWorkspaceParams) =>
`updated your role in ${policyName} from ${oldRole} to user. You have been removed from all submitter workspace chats except for you own.`,
`updated your role in ${policyName} from ${oldRole} to user. You have been removed from all submitter expense chats except for you own.`,
updatedWorkspaceCurrencyAction: ({oldCurrency, newCurrency}: UpdatedPolicyCurrencyParams) => `updated the default currency to ${newCurrency} (previously ${oldCurrency})`,
updatedWorkspaceFrequencyAction: ({oldFrequency, newFrequency}: UpdatedPolicyFrequencyParams) =>
`updated the auto-reporting frequency to "${newFrequency}" (previously "${oldFrequency}")`,
Expand Down
6 changes: 3 additions & 3 deletions src/languages/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5185,12 +5185,12 @@ const translations = {
joinedNames = `${submittersNames.slice(0, submittersNames.length - 1).join(', ')} y ${submittersNames.at(-1)}`;
}
return {
one: `te eliminó del flujo de trabajo de aprobaciones y del chat del espacio de trabajo de ${joinedNames}. Los informes enviados anteriormente seguirán estando disponibles para su aprobación en tu bandeja de entrada.`,
other: `te eliminó de los flujos de trabajo de aprobaciones y de los chats del espacio de trabajo de ${joinedNames}. Los informes enviados anteriormente seguirán estando disponibles para su aprobación en tu bandeja de entrada.`,
one: `te eliminó del flujo de trabajo de aprobaciones y del chat de gastos de ${joinedNames}. Los informes enviados anteriormente seguirán estando disponibles para su aprobación en tu bandeja de entrada.`,
other: `te eliminó de los flujos de trabajo de aprobaciones y de los chats de gastos de ${joinedNames}. Los informes enviados anteriormente seguirán estando disponibles para su aprobación en tu bandeja de entrada.`,
};
},
demotedFromWorkspace: ({policyName, oldRole}: DemotedFromWorkspaceParams) =>
`cambió tu rol en ${policyName} de ${oldRole} a miembro. Te eliminamos de todos los chats del espacio de trabajo, excepto el suyo.`,
`cambió tu rol en ${policyName} de ${oldRole} a miembro. Te eliminamos de todos los chats de gastos, excepto el suyo.`,
updatedWorkspaceCurrencyAction: ({oldCurrency, newCurrency}: UpdatedPolicyCurrencyParams) => `actualizó la moneda predeterminada a ${newCurrency} (previamente ${oldCurrency})`,
updatedWorkspaceFrequencyAction: ({oldFrequency, newFrequency}: UpdatedPolicyFrequencyParams) =>
`actualizó la frecuencia de generación automática de informes a "${newFrequency}" (previamente "${oldFrequency}")`,
Expand Down
2 changes: 1 addition & 1 deletion src/libs/OptionsListUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1495,7 +1495,7 @@ function getValidReports(reports: OptionList['reports'], config: GetValidReports
continue;
}

// When passing includeP2P false we are trying to hide features from users that are not ready for P2P and limited to workspace chats only.
// When passing includeP2P false we are trying to hide features from users that are not ready for P2P and limited to expense chats only.
if (!includeP2P && !isPolicyExpenseChat) {
continue;
}
Expand Down
Loading
Loading