-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[CP Stag] fix: unable delete expense in reports page narrow #61253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Stag] fix: unable delete expense in reports page narrow #61253
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@rayane-d PR is ready! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppSimulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-05-01.at.18.28.11.mp4Android: mWeb ChromeScreen.Recording.2025-05-01.at.6.14.20.PM.moviOS: HybridAppSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-05-01.at.18.23.03.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-05-01.at.18.26.41.mp4MacOS: Chrome / SafariScreen.Recording.2025-05-01.at.6.09.37.PM.movMacOS: DesktopScreen.Recording.2025-05-01.at.6.18.23.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well 👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…-expense-in-report-page-narrow [CP Stag] fix: unable delete expense in reports page narrow (cherry picked from commit 5e73cc5) (cherry-picked to staging by thienlnam)
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.1.38-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.38-4 🚀
|
Performance Comparison Report 📊 (1/4)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (2/4)Meaningless Changes To Duration (1/3)Show entries
Show details
|
Performance Comparison Report 📊 (3/4)Meaningless Changes To Duration (2/3)Show entries
Show details
|
Performance Comparison Report 📊 (4/4)Meaningless Changes To Duration (3/3)Show entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Explanation of Change
In the narrow search page, the selected option is currently cleared after an option is selected and the modal closes. However, for the delete action, we should retain the selection. This PR introduces a new flag to preserve the selected option in such scenarios.
Fixed Issues
$ #61141
PROPOSAL: #61141 (comment)
Tests
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectioncanBeMissing
param foruseOnyx
toggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2025-05-01.at.23.22.00.mov
Android: mWeb Chrome
Screen.Recording.2025-05-01.at.23.23.50.mov
iOS: Native
Screen.Recording.2025-05-01.at.23.20.40.mov
iOS: mWeb Safari
Screen.Recording.2025-05-01.at.23.23.08.mov
MacOS: Chrome / Safari
Screen.Recording.2025-05-01.at.23.31.13.mov
MacOS: Desktop
Screen.Recording.2025-05-01.at.23.32.35.mov