fix: show border on Search route #60539

daledah · 2025-04-19T19:32:26Z

Explanation of Change

Fixed Issues

$ #60538
PROPOSAL:

Tests

Permission: account has tableReportView betas

Submit an expense to the workspace chat.
Send a message to the workspace chat.
Go to Reports.
Go to Chats.
Note that the expense preview from Step 3 has outline.
Click on the message sent from Step 4.
Verify that: in background, outline of expense preview doesn't disappear

Verify that no errors appear in the JS console

Offline tests

QA Steps

Permission: account has tableReportView betas

Submit an expense to the workspace chat.
Send a message to the workspace chat.
Go to Reports.
Go to Chats.
Note that the expense preview from Step 3 has outline.
Click on the message sent from Step 4.
Verify that: in background, outline of expense preview doesn't disappear

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-22.at.17.40.34.mov

Android: mWeb Chrome

Screen.Recording.2025-04-22.at.17.41.07.mov

iOS: Native

Screen.Recording.2025-04-22.at.17.41.53.mov

iOS: mWeb Safari

Screen.Recording.2025-04-22.at.17.42.22.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-22.at.17.38.44.mov

MacOS: Desktop

Screen.Recording.2025-04-22.at.17.43.17.mov

melvin-bot · 2025-04-19T19:42:43Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-04-21T05:23:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-23.at.1.54.59.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-04-23.at.2.00.51.PM.mov

iOS: Native

Screen.Recording.2025-04-23.at.2.02.47.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-04-23.at.2.05.07.PM.mov

MacOS: Chrome / Safari

MacOS: Desktop

Screen.Recording.2025-04-23.at.1.52.30.PM.mov

allgandalf · 2025-04-21T07:47:59Z

c.c. @shawnborton can you check this one from design perspective

shawnborton · 2025-04-21T07:52:44Z

This is incorrect, we don't want to add a border to the expense report preview when it is viewed from a chat context. We only show it when it's shown from the Reports > Chats filter. Let's please close this PR.

daledah · 2025-04-21T09:07:23Z

I updated, @shawnborton please help check again if the updates here are correct:

Screen.Recording.2025-04-21.at.16.03.29.mov

shawnborton · 2025-04-21T09:10:32Z

That looks correct but why do we even need a PR here? can't we just close this out?

daledah · 2025-04-21T09:13:08Z

@shawnborton ~~This PR is to fix this issue where opening RHP makes the border disappears.~~

Oh I just saw your comment on the issue, if we decide it doesn't need fixing then I'll close this PR.

shawnborton · 2025-04-21T09:15:15Z

Yes, we ONLY want the border to show around the expense report preview when you view the expense report preview from Reports > Chats.

daledah · 2025-04-21T09:16:53Z

From the issue video, you can see that the border of the expense report disappears in the background when we open a RHP

Normal:

Open RHP:

This PR aims to fix that.

shawnborton · 2025-04-21T09:18:23Z

Ah got it, I misunderstood. I thought we were trying to add a border to the view of the expense report preview in the RHP.

allgandalf · 2025-04-22T04:19:21Z

@shawnborton do you approve these changes design wise?

shawnborton · 2025-04-22T10:17:07Z

The video from the OP above is incorrect though, as I still see borders in the RHP:

Can someone provide me with the most up-to-date video?

daledah · 2025-04-22T10:45:12Z

@shawnborton I just updated the screenshots. Here's the latest result on Chrome

Screen.Recording.2025-04-22.at.17.38.44.mov

shawnborton · 2025-04-22T12:39:46Z

That looks correct to me.

allgandalf · 2025-04-23T07:26:31Z

src/components/ReportActionItem/MoneyRequestReportPreview/types.ts

+
+    shouldShowBorder?: boolean;


add comment

Updated 👍

allgandalf

nitpick

src/components/ReportActionItem/MoneyRequestReportPreview/types.ts

mountiny · 2025-04-23T10:47:46Z

@daledah conflicts

daledah · 2025-04-23T11:03:12Z

@mountiny Resolved 👍

mountiny

simple solution, thanks!

OSBotify · 2025-04-23T12:32:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-23T18:46:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.32-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-28T19:53:01Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.32-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix: show border on Search route

9e24763

daledah marked this pull request as ready for review April 19, 2025 19:42

daledah requested a review from a team as a code owner April 19, 2025 19:42

melvin-bot bot requested a review from allgandalf April 19, 2025 19:42

melvin-bot bot removed the request for review from a team April 19, 2025 19:42

daledah mentioned this pull request Apr 19, 2025

Reports - Expense preview outline disappears when chat report RHP is opened #60538

Closed

8 tasks

fix: only show border for ChatListItem

8c5a1d5

Merge branch 'main' into fix/60538

e9e0f70

allgandalf suggested changes Apr 23, 2025

View reviewed changes

daledah added 2 commits April 23, 2025 14:46

Merge branch 'main' into fix/60538

6fd9352

chore: add explanation comment

c6c4c1d

allgandalf approved these changes Apr 23, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny April 23, 2025 08:37

allgandalf reviewed Apr 23, 2025

View reviewed changes

src/components/ReportActionItem/MoneyRequestReportPreview/types.ts Outdated Show resolved Hide resolved

mountiny assigned daledah Apr 23, 2025

daledah added 2 commits April 23, 2025 18:00

Merge branch 'main' into fix/60538

bce7f43

fix: lint

200a03b

fix: spelling

8581bd7

mountiny approved these changes Apr 23, 2025

View reviewed changes

mountiny merged commit 806e231 into Expensify:main Apr 23, 2025
16 checks passed

github-actions bot mentioned this pull request Apr 23, 2025

Deploy Checklist: New Expensify 2025-04-23 #60729

Closed

91 tasks

fix: show border on Search route #60539

fix: show border on Search route #60539

Uh oh!

Conversation

daledah commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 19, 2025

Uh oh!

allgandalf commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Apr 21, 2025

Uh oh!

shawnborton commented Apr 21, 2025

Uh oh!

daledah commented Apr 21, 2025

Uh oh!

shawnborton commented Apr 21, 2025

Uh oh!

daledah commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Apr 21, 2025

Uh oh!

daledah commented Apr 21, 2025

Uh oh!

shawnborton commented Apr 21, 2025

Uh oh!

allgandalf commented Apr 22, 2025

Uh oh!

shawnborton commented Apr 22, 2025

Uh oh!

daledah commented Apr 22, 2025

Uh oh!

shawnborton commented Apr 22, 2025

Uh oh!

allgandalf Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

daledah Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny commented Apr 23, 2025

Uh oh!

daledah commented Apr 23, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

Uh oh!

daledah commented Apr 19, 2025 •

edited

Loading

allgandalf commented Apr 21, 2025 •

edited

Loading

daledah commented Apr 21, 2025 •

edited

Loading