Skip to content

Start tagging production in addition to staging deploys #60363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2025
Merged

Start tagging production in addition to staging deploys #60363

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7836a14
Tag production and staging deploys
AndrewGable Apr 16, 2025
6d73af1
Add missing 0
AndrewGable Apr 16, 2025
656ff02
Adjust how we get tag
AndrewGable Apr 16, 2025
801e4ce
Adjust name of step
AndrewGable Apr 16, 2025
5a504ca
Use previous version to determine tag as it works!
AndrewGable Apr 16, 2025
d5597ae
Remove whitespace change
AndrewGable Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,19 @@ jobs:
id: getAppVersion
run: echo "VERSION=$(jq -r .version < package.json)" >> "$GITHUB_OUTPUT"

- name: Get tag name
- name: Get tag
id: getTagName
run: echo "TAG=${{ fromJSON(env.SHOULD_DEPLOY_PRODUCTION) && steps.getAppVersion.outputs.VERSION || format('{0}-staging', steps.getAppVersion.outputs.VERSION) }}" >> "$GITHUB_OUTPUT"

- name: Create and push tag
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
run: |
git tag ${{ steps.getTagName.outputs.TAG }}
git push origin --tags
cd Mobile-Expensify
git tag ${{ steps.getTagName.outputs.TAG }}
git push origin --tags

# Note: we're updating the checklist before running the deploys and assuming that it will succeed on at least one platform
# Note: we're updating the checklist before running the deploys and assuming that it will succeed on at least one platform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errant whitespace change

deployChecklist:
name: Create or update deploy checklist
uses: ./.github/workflows/createDeployChecklist.yml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/finishReleaseCycle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Prepare production deploy
name: Finish release cycle

on:
issues:
Expand Down