-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Internal QA] Update Company Cards page to potentially show domain feeds #60261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
puneetlath
merged 10 commits into
Expensify:main
from
callstack-internal:VickyStash/feature/59837-domain-company-cards
Apr 18, 2025
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8cffd51
Implement useCardFeeds hook
VickyStash c3eaf73
Merge branch 'refs/heads/main' into VickyStash/feature/59837-domain-c…
VickyStash 92df591
Update useCardFeed hook
VickyStash 9598359
Merge branch 'refs/heads/main' into VickyStash/feature/59837-domain-c…
VickyStash 31236b9
Fix ts error
VickyStash 808fe39
Merge branch 'refs/heads/main' into VickyStash/feature/59837-domain-c…
VickyStash 2b0c298
Apply reviewer feedback
VickyStash 82611fc
Merge branch 'refs/heads/main' into VickyStash/feature/59837-domain-c…
VickyStash 5f04b71
Describe useCardFeeds hook
VickyStash 2528c8c
Add canBeMissing flags to fix lint errors
VickyStash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
import {useMemo} from 'react'; | ||
import type {OnyxCollection, ResultMetadata} from 'react-native-onyx'; | ||
import ONYXKEYS from '@src/ONYXKEYS'; | ||
import type {CardFeeds, CompanyCardFeed} from '@src/types/onyx'; | ||
import useOnyx from './useOnyx'; | ||
import useWorkspaceAccountID from './useWorkspaceAccountID'; | ||
|
||
const useCardFeeds = (policyID: string | undefined): [CardFeeds | undefined, ResultMetadata<OnyxCollection<CardFeeds>>] => { | ||
const workspaceAccountID = useWorkspaceAccountID(policyID); | ||
const [allFeeds, allFeedsResult] = useOnyx(ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER); | ||
|
||
const workspaceFeeds = useMemo(() => { | ||
if (!policyID || !allFeeds) { | ||
return undefined; | ||
} | ||
|
||
const defaultFeed = allFeeds?.[`${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${workspaceAccountID}`]; | ||
const {companyCards = {}, companyCardNicknames = {}, oAuthAccountDetails = {}} = defaultFeed?.settings ?? {}; | ||
|
||
return Object.values(allFeeds).reduce<CardFeeds & {settings: Required<CardFeeds['settings']>}>( | ||
(acc, feed) => { | ||
if (!feed?.settings?.companyCards) { | ||
return acc; | ||
} | ||
|
||
Object.entries(feed.settings.companyCards).forEach(([key, feedSettings]) => { | ||
const feedName = key as CompanyCardFeed; | ||
const feedOAuthAccountDetails = feed.settings.oAuthAccountDetails?.[feedName]; | ||
const feedCompanyCardNicknames = feed.settings.companyCardNicknames?.[feedName]; | ||
|
||
if (feedSettings.preferredPolicy !== policyID || acc.settings.companyCards[feedName]) { | ||
return; | ||
} | ||
|
||
acc.settings.companyCards[feedName] = feedSettings; | ||
|
||
if (feedOAuthAccountDetails) { | ||
acc.settings.oAuthAccountDetails[feedName] = feedOAuthAccountDetails; | ||
} | ||
if (feedCompanyCardNicknames) { | ||
acc.settings.companyCardNicknames[feedName] = feedCompanyCardNicknames; | ||
} | ||
}); | ||
|
||
return acc; | ||
}, | ||
{settings: {companyCards, companyCardNicknames, oAuthAccountDetails}}, | ||
); | ||
}, [allFeeds, policyID, workspaceAccountID]); | ||
|
||
return [workspaceFeeds, allFeedsResult]; | ||
}; | ||
|
||
export default useCardFeeds; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.