-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix: Payer section goes missing from payed money request preview #60168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2025-04-16.at.02.26.33.movMacOS: DesktopScreen.Recording.2025-04-16.at.02.29.08.mov |
@nkdengineer When I log back in, the last message in LHN for user B is not the IOU: Can you check? |
![]() @dominictb i can't reproduce this bug |
@nkdengineer Steps:
Actual result: It shows the first message in the DM |
checking now |
@dominictb We don't have transaction data until we open DM report => no data to show last message in LHN Screen.Recording.2025-04-21.at.10.18.08.mov |
@nkdengineer Lint. |
Is this purely BE or is there anything we can fix in FE? |
this is purely BE |
@dominictb i fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the LHN's last message bug mentioned here reproduced by these steps. The root cause is that the BE does not return the full report
and reportActions
data for that report, it only returns the first report action. It's out of scope and should be handled separately.
PR looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.1.31-0 🚀
|
@nkdengineer did this PR cause this regression here? #60647 |
@shawnborton I'm pretty sure this come from #59806 that reverse the correct logic |
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.31-3 🚀
|
Explanation of Change
Fixed Issues
$ #59688
PROPOSAL: #59688 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov