[Test Drive][Phase 1][FE] Show the Test Drive modal during onboarding and via task #60085

pac-guerreiro · 2025-04-11T02:47:40Z

Explanation of Change

Fixed Issues

$#60041
#60042
PROPOSAL: https://docs.google.com/document/d/1PryaYgnK8MeV2Zb_1Arp0HxSvRa7TJCjxGhTWGOVQ8s/edit?tab=t.0#heading=h.ntotu1k8frrn

Tests

Create a new account
Choose Manage my team's expenses
Choose 1-10 employees
Choose None of the above
Verify that the test drive modal is shown properly, then try both scenarios below:

Scenario A

Click on Start test drive
Do the test drive and confirm that everything is working as it should
Confirm that by clicking Get started on the top bar finishes the test drive

Scenario B

Click on 'Skip'
Go to Concierge chat and click on the link on Take a test drive task
Do the test drive and confirm that everything is working as it should
Confirm that by clicking Get started on the top bar finishes the test drive

Offline tests

Same as tests.

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android.-.Native.mp4

Android: mWeb Chrome

Android.-.Chrome.mp4

iOS: Native

iOS.-.Native.mp4

iOS: mWeb Safari

iOS.-.Safari.mp4

MacOS: Chrome / Safari

MacOS.-.Chrome.mp4

MacOS: Desktop

MacOS.-.Desktop.mp4

fabioh8010

@pac-guerreiro Let's prepare the test steps and screenshots/videos in advance while the first PR is in review

tests/unit/navigateAfterOnboardingTest.ts

…guerreiro/feature/show-test-drive-modal-during-onboarding

…arding' into pac-guerreiro/feature/implement-test-drive-embedded-ui # Conflicts: # src/libs/Navigation/types.ts

… devices

…guerreiro/feature/show-test-drive-modal-during-onboarding

…arding' into pac-guerreiro/feature/implement-test-drive-embedded-ui

pac-guerreiro · 2025-04-14T22:47:09Z

Today I added testing steps, screen recordings and filled checklist.

…during-onboarding

…arding' into pac-guerreiro/feature/implement-test-drive-embedded-ui # Conflicts: # src/components/TestDriveModal.tsx

melvin-bot · 2025-04-16T23:50:10Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pac-guerreiro · 2025-04-16T23:50:59Z

@danieldoglas @rojiphil The PR is ready for review! 😄

fabioh8010 · 2025-04-17T06:25:56Z

@pac-guerreiro @danieldoglas @rojiphil I think it will be better to also put the changes of the Embedded UI PR into this one, because this feature is not behind any betas and users would see a modal that doesn't do anything unless the Embedded UI PR is merged.

@pac-guerreiro This should be fairly easy to do, and you can also just pull the test steps/screenthots from there and use it here.

What do you all think?

rojiphil

Yeah. I also think merging the embedded UI PR with this one may be better.

@pac-guerreiro I have just left a query. Please have a look. Thanks.

rojiphil · 2025-04-17T11:55:58Z

src/libs/navigateAfterOnboarding.ts

@@ -13,6 +16,13 @@ const navigateAfterOnboarding = (
 ) => {
    Navigation.dismissModal();

+    if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
+        setTimeout(() => {


Why is there a need to use setTimeout here?

We need a delay otherwise the navigation actions (dismissModal and this navigation) will conflict and cause bugs, but @pac-guerreiro we can use InteractionManager.runAfterInteractions() here instead, it's a better choice

Ah! I get it now. Thanks.
Would this utility setNavigationActionToMicrotaskQueue help here?

@fabioh8010 @rojiphil InteractionManager.runAfterInteractions() was not working on native Android and iOS, so I used this logic

@pac-guerreiro Did you check if this works?

I think we missed addressing this comment. What do you think of this?

@rojiphil I applied your suggestions but still need to test it

@rojiphil I confirm your suggestion works! But I tried using InteractionManager.runAfterInteractions() again and it also works... I guess I might've stumbled into a cache issue of my emulators 😅 I'll go with @fabioh8010 solution 😄

fabioh8010 · 2025-04-17T13:28:23Z

src/libs/navigateAfterOnboarding.ts

@@ -13,6 +16,13 @@ const navigateAfterOnboarding = (
 ) => {
    Navigation.dismissModal();

+    if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
+        setTimeout(() => {


We need a delay otherwise the navigation actions (dismissModal and this navigation) will conflict and cause bugs, but @pac-guerreiro we can use InteractionManager.runAfterInteractions() here instead, it's a better choice

src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx

danieldoglas · 2025-04-17T14:29:27Z

I think it will be better to also put the changes of the #60089 into this one, because this feature is not behind any betas and users would see a modal that doesn't do anything unless the Embedded UI PR is merged.

I'm discussing internally if we should have a beta for this. But I agree that if we don't, then we should merge them together (or merge the embedded PR first)

pac-guerreiro · 2025-04-17T16:03:53Z

I'll wait for your decision @danieldoglas 😉

… into pac-guerreiro/feature/show-test-drive-modal-during-onboarding

…during-onboarding

pac-guerreiro · 2025-04-17T16:50:31Z

@danieldoglas As decided here, I proceeded with merging the third PR with this one.

pac-guerreiro · 2025-04-23T14:58:43Z

@fabioh8010 @rojiphil I think I addressed all your feedback! Anything else you find, let me know! 😄

fabioh8010

Minor comment

tests/actions/TaskTest.ts

…al life conditions

fabioh8010

LGTM! @danieldoglas @rojiphil over to you

rojiphil · 2025-04-24T06:58:48Z

@pac-guerreiro Looks like we are marking the task as completed earlier than required. ~

@danieldoglas My thoughts were that we have to mark it as completed only when the user clicks on Get started
I have just updated the test cases to capture this.
~~Is this expected?~~

Edit:

It doesn’t matter how much they complete in the test drive, opening it checks off the task.

Sorry.. Just found this in the design doc. So, it is intended to complete the task once opened. Please ignore the above comment.

rojiphil · 2025-04-24T09:32:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

60085-web-chrome-001.mp4

MacOS: Desktop

60085-desktop-001.mp4

Android: Native

60085-android-hybrid-001.mp4

Android: mWeb Chrome

60085-mweb-chrome-001.mp4

iOS: Native

Not tested as I have build issues. I think this is fine as the focus is not on mobile versions for this phase.

iOS: mWeb Safari

60085-mweb-safari-001.mp4

rojiphil · 2025-04-24T09:59:02Z

@pac-guerreiro There are conflicts here. Can you please resolve them?

rojiphil

@danieldoglas The only issues I notice are with the story lane test drive.

There are issues with the mobile versions as mentioned here.

Curious to know if there is a plan to use swipe through carousel for mobile versions? I get this thought from the following statement in design document:

A limitation of this is that the mobile solution is not ideal as it’s not really a test drive, it’s just a swipe through carousel.

Additionally, I have also left a comment here to improve the user experience.

Outside of the story lane though, the changes in this PR LGTM.
Approving for your review. Thanks.

…during-onboarding # Conflicts: # src/CONST.ts # src/libs/ReportUtils.ts

…during-onboarding

pac-guerreiro · 2025-04-24T13:06:10Z

@rojiphil @fabioh8010 conflicts resolved! Thanks 😄

OSBotify · 2025-04-24T16:47:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

dubielzyk-expensify · 2025-04-25T02:04:27Z

This is looking pretty great to me. cc @Expensify/design

(Would be good to get the design check before merging next time 😄 My bad for not being quick enough though)

shawnborton · 2025-04-25T12:00:50Z

Same, looking good from what I can tell too 👍

github-actions · 2025-04-28T20:21:16Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.1.33-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-29T19:55:10Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.1.35-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-04-29T20:50:12Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.1.36-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-29T22:16:13Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.1.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

github-actions · 2025-04-30T00:44:16Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.37-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

pac-guerreiro added 3 commits April 11, 2025 03:45

feat(testdrive): show test drive modal after onboarding

c587096

feat(testdrive): replace self guided tour task with test drive

8604e26

feat(testdrive): implement test drive embedded ui

be7cfcb

fabioh8010 reviewed Apr 14, 2025

View reviewed changes

tests/unit/navigateAfterOnboardingTest.ts Outdated Show resolved Hide resolved

pac-guerreiro added 7 commits April 14, 2025 12:30

Merge branch 'pac-guerreiro/feature/test-drive-admin-modal' into pac-…

8c0fc1b

…guerreiro/feature/show-test-drive-modal-during-onboarding

Merge branch 'pac-guerreiro/feature/show-test-drive-modal-during-onbo…

26c9e2a

…arding' into pac-guerreiro/feature/implement-test-drive-embedded-ui # Conflicts: # src/libs/Navigation/types.ts

fix(testdrive): test drive modal not shown after onboarding on mobile…

a719d8b

… devices

chore(testdrive): update tests

941843e

Merge branch 'pac-guerreiro/feature/test-drive-admin-modal' into pac-…

caef117

…guerreiro/feature/show-test-drive-modal-during-onboarding

chore(testdrive): fix broken test

4c4328e

Merge branch 'pac-guerreiro/feature/show-test-drive-modal-during-onbo…

8ba7ae9

…arding' into pac-guerreiro/feature/implement-test-drive-embedded-ui

pac-guerreiro added 3 commits April 16, 2025 20:18

Merge branch 'main' into pac-guerreiro/feature/show-test-drive-modal-…

60af31b

…during-onboarding

Merge branch 'pac-guerreiro/feature/show-test-drive-modal-during-onbo…

fa72f5d

…arding' into pac-guerreiro/feature/implement-test-drive-embedded-ui # Conflicts: # src/components/TestDriveModal.tsx

chore: fix eslint issues

431ff3f

pac-guerreiro marked this pull request as ready for review April 16, 2025 23:50

pac-guerreiro requested a review from a team as a code owner April 16, 2025 23:50

melvin-bot bot requested review from rojiphil and removed request for a team April 16, 2025 23:50

rojiphil reviewed Apr 17, 2025

View reviewed changes

fabioh8010 reviewed Apr 17, 2025

View reviewed changes

Merge branch 'pac-guerreiro/feature/implement-test-drive-embedded-ui'…

44037e0

… into pac-guerreiro/feature/show-test-drive-modal-during-onboarding

pac-guerreiro requested a review from a team as a code owner April 17, 2025 16:44

Merge branch 'main' into pac-guerreiro/feature/show-test-drive-modal-…

75536c8

…during-onboarding

pac-guerreiro requested review from rojiphil and fabioh8010 April 23, 2025 14:57

fabioh8010 reviewed Apr 23, 2025

View reviewed changes

tests/actions/TaskTest.ts Outdated Show resolved Hide resolved

refactor(testdrive): parse task name markdown to html to replicate re…

56ea4e6

…al life conditions

pac-guerreiro requested a review from fabioh8010 April 23, 2025 17:00

fabioh8010 approved these changes Apr 23, 2025

View reviewed changes

rojiphil approved these changes Apr 24, 2025

View reviewed changes

melvin-bot bot requested a review from danieldoglas April 24, 2025 10:12

pac-guerreiro added 2 commits April 24, 2025 14:01

Merge branch 'main' into pac-guerreiro/feature/show-test-drive-modal-…

f3dd308

…during-onboarding # Conflicts: # src/CONST.ts # src/libs/ReportUtils.ts

Merge branch 'main' into pac-guerreiro/feature/show-test-drive-modal-…

ad39571

…during-onboarding

fabioh8010 approved these changes Apr 24, 2025

View reviewed changes

danieldoglas approved these changes Apr 24, 2025

View reviewed changes

danieldoglas merged commit d04ecfc into Expensify:main Apr 24, 2025
19 checks passed

github-actions bot mentioned this pull request Apr 28, 2025

Deploy Checklist: New Expensify 2025-04-28 #60971

Closed

jponikarchuk mentioned this pull request Apr 29, 2025

[Due for payment 2025-05-28] [Test Drive][HIGH] iOS-Test drive-Test drive modal is shown briefly after completing test drive #61032

Open

8 tasks

nlemma mentioned this pull request Apr 29, 2025

Test Drive modal shows an error #61083

Closed

8 tasks

danieldoglas assigned pac-guerreiro Apr 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Test Drive][Phase 1][FE] Show the Test Drive modal during onboarding and via task #60085

[Test Drive][Phase 1][FE] Show the Test Drive modal during onboarding and via task #60085

pac-guerreiro commented Apr 11, 2025 •

edited by danieldoglas

Loading

fabioh8010 left a comment

pac-guerreiro commented Apr 14, 2025

melvin-bot bot commented Apr 16, 2025

pac-guerreiro commented Apr 16, 2025

fabioh8010 commented Apr 17, 2025

rojiphil left a comment

rojiphil Apr 17, 2025

fabioh8010 Apr 17, 2025

rojiphil Apr 17, 2025

pac-guerreiro Apr 17, 2025

rojiphil Apr 18, 2025

rojiphil Apr 22, 2025

pac-guerreiro Apr 22, 2025

pac-guerreiro Apr 23, 2025

fabioh8010 Apr 17, 2025

danieldoglas commented Apr 17, 2025

pac-guerreiro commented Apr 17, 2025

pac-guerreiro commented Apr 17, 2025

pac-guerreiro commented Apr 23, 2025

fabioh8010 left a comment

fabioh8010 left a comment

rojiphil commented Apr 24, 2025 •

edited

Loading

rojiphil commented Apr 24, 2025

rojiphil commented Apr 24, 2025

rojiphil left a comment

pac-guerreiro commented Apr 24, 2025

OSBotify commented Apr 24, 2025

dubielzyk-expensify commented Apr 25, 2025

shawnborton commented Apr 25, 2025

github-actions bot commented Apr 28, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 30, 2025

[Test Drive][Phase 1][FE] Show the Test Drive modal during onboarding and via task #60085

[Test Drive][Phase 1][FE] Show the Test Drive modal during onboarding and via task #60085

Conversation

pac-guerreiro commented Apr 11, 2025 • edited by danieldoglas Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

fabioh8010 left a comment

Choose a reason for hiding this comment

pac-guerreiro commented Apr 14, 2025

melvin-bot bot commented Apr 16, 2025

pac-guerreiro commented Apr 16, 2025

fabioh8010 commented Apr 17, 2025

rojiphil left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danieldoglas commented Apr 17, 2025

pac-guerreiro commented Apr 17, 2025

pac-guerreiro commented Apr 17, 2025

pac-guerreiro commented Apr 23, 2025

fabioh8010 left a comment

Choose a reason for hiding this comment

fabioh8010 left a comment

Choose a reason for hiding this comment

rojiphil commented Apr 24, 2025 • edited Loading

rojiphil commented Apr 24, 2025

Reviewer Checklist

Screenshots/Videos

rojiphil commented Apr 24, 2025

rojiphil left a comment

Choose a reason for hiding this comment

pac-guerreiro commented Apr 24, 2025

OSBotify commented Apr 24, 2025

dubielzyk-expensify commented Apr 25, 2025

shawnborton commented Apr 25, 2025

github-actions bot commented Apr 28, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 30, 2025

pac-guerreiro commented Apr 11, 2025 •

edited by danieldoglas

Loading

rojiphil commented Apr 24, 2025 •

edited

Loading