[No QA] Create prebuilt React Native artifacts #59738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
|
|
|
|
|
@roryabraham PR in the current form should be ready, feel free to review it. I tested it on my forked I have a few things to mention/discuss:
|
mateuuszzzzz
commented
Apr 14, 2025
war-in
reviewed
Apr 14, 2025
roryabraham
requested changes
Apr 17, 2025
There was a problem hiding this comment.
Full diff of my requested changes:
full diff
diff --git a/.github/scripts/computePatchesHash.sh b/.github/scripts/computePatchesHash.sh
deleted file mode 100755
index 196f49bcf21..00000000000
--- a/.github/scripts/computePatchesHash.sh
+++ /dev/null
@@ -1,14 +0,0 @@
-#!/bin/bash
-
-if [ -z "$VERSION" ]; then
- echo "VERSION env variable is not set"
- exit 1
-fi
-
-if [ -z "$PATCHES_PATHS" ]; then
- echo "PATCHES_PATHS env variable is not set"
- exit 1
-fi
-
-IFS=' ' read -ra PATCH_DIRS <<< "$PATCHES_PATHS"
-find "${PATCH_DIRS[@]}" -type f -name "react-native+${VERSION}*.patch" -exec sha256sum {} + | sort | sha256sum | awk '{print $1}'
diff --git a/.github/scripts/getNewPatchedRNVersion.sh b/.github/scripts/getNewPatchedRNVersion.sh
index 8b84b8cd5e8..736249e5769 100755
--- a/.github/scripts/getNewPatchedRNVersion.sh
+++ b/.github/scripts/getNewPatchedRNVersion.sh
@@ -1,9 +1,6 @@
#!/bin/bash
-if [ -z "$VERSION" ]; then
- echo "VERSION env variable is not set"
- exit 1
-fi
+VERSION="$(jq -r '.dependencies["react-native"]' package.json)"
if [[ "$IS_HYBRID_BUILD" == "true" ]]; then
PACKAGE="react-hybrid"
diff --git a/.github/workflows/buildAndPublishReactNativeArtifacts.yml b/.github/workflows/buildAndPublishReactNativeArtifacts.yml
index b39aeaca0d6..5ea26af58d0 100644
--- a/.github/workflows/buildAndPublishReactNativeArtifacts.yml
+++ b/.github/workflows/buildAndPublishReactNativeArtifacts.yml
@@ -10,204 +10,112 @@ on:
- Mobile-Expensify
jobs:
- verifyNewDotPatchesAndReactNativeVersion:
- runs-on: ubuntu-latest
+ publish:
+ runs-on: ${{ github.repository_owner == 'Expensify' && 'ubuntu-latest-xl' || 'ubuntu-latest' }}
+ strategy:
+ matrix:
+ is_hybrid: [true, false]
+ env:
+ PATCHES_PATHS: ${{ matrix.is_hybrid && 'Mobile-Expensify/patches' || 'patches' }}
steps:
+ # v4
- name: Checkout
- # v4
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
-
- - name: Check if NewDot patches or react-native version have changed
- run: |
- VERSION=$(jq -r '.dependencies["react-native"]' package.json)
- HASH=$(VERSION=$VERSION ./.github/scripts/computePatchesHash.sh)
-
- git fetch origin ${{ github.event.before }}
- git checkout ${{ github.event.before }}
-
- OLD_VERSION=$(jq -r '.dependencies["react-native"]' package.json)
- # If version has changed and we want to find differences in patches, we need to consider pattern that involves previous react-native version
- OLD_HASH=$(VERSION=$OLD_VERSION ./.github/scripts/computePatchesHash.sh)
-
- if [ "$HASH" == "$OLD_HASH" ] && [ "$VERSION" == "$OLD_VERSION" ]; then
- echo "No relevant changes"
- exit 1
- fi
-
- if [ "$VERSION" != "$OLD_VERSION" ]; then
- echo "Detected react-native version bump ($OLD_VERSION -> $VERSION)"
- exit 0
- fi
-
- if [ "$HASH" != "$OLD_HASH" ]; then
- echo "Detected changes in NewDot patches:"
- git diff --name-only ${{ github.event.before }}..${{ github.event.after }} -- "patches/react-native+*.patch"
- fi
- env:
- PATCHES_PATHS: "patches"
-
- verifyHybridAppPatches:
- runs-on: ubuntu-latest
- steps:
- - name: Checkout
- # v4
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
with:
- submodules: true
- fetch-depth: 0
- - name: Get react-native version
- run: |
- echo "VERSION=$(jq -r '.dependencies["react-native"]' package.json)" >> $GITHUB_ENV
+ submodules: ${{ matrix.is_hybrid }}
+ ref: ${{ github.event.before }}
- - name: Check if HybridApp patches have changed
- run: |
- CURRENT_SUBMODULE_COMMIT=$(git rev-parse :Mobile-Expensify)
- CURRENT_PATCHES_HASH=$(./.github/scripts/computePatchesHash.sh)
-
- git fetch origin ${{ github.event.before }}
- git checkout ${{ github.event.before }}
+ - name: Get previous commit hash
+ id: getOldHash
+ run: echo "HASH=$(git rev-parse ${{ matrix.is_hybrid == 'true' && ':Mobile-Expensify' || 'HEAD' }})" >> "$GITHUB_OUTPUT"
- git submodule update
-
- PREVIOUS_SUBMODULE_COMMIT=$(git rev-parse :Mobile-Expensify)
-
- if [ "$CURRENT_SUBMODULE_COMMIT" == "$PREVIOUS_SUBMODULE_COMMIT" ]; then
- echo "Submodule commit is the same as the previous one, skipping patch check"
- exit 1
- fi
-
- PREVIOUS_PATCHES_HASH=$(./.github/scripts/computePatchesHash.sh)
-
- if [ "$CURRENT_PATCHES_HASH" == "$PREVIOUS_PATCHES_HASH" ]; then
- echo "No changes in HybridApp patches"
- exit 1
- fi
-
- echo "Detected changes in HybridApp patches:"
- git -C Mobile-Expensify diff --name-only $PREVIOUS_SUBMODULE_COMMIT..$CURRENT_SUBMODULE_COMMIT -- "patches/react-native+*.patch"
- env:
- PATCHES_PATHS: "Mobile-Expensify/patches"
- VERSION: ${{ env.VERSION }}
+ - name: Get previous react-native version
+ id: getOldVersion
+ run: echo "VERSION=$(jq -r '.dependencies["react-native"]' package.json)" >> "$GITHUB_OUTPUT"
- buildAndPublishRNArtifactsForStandaloneNewDot:
- runs-on: ubuntu-latest
- if: ${{ always() && needs.verifyNewDotPatchesAndReactNativeVersion.result == 'success'}}
- needs: verifyNewDotPatchesAndReactNativeVersion
- steps:
- - name: Checkout
- # v4
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
-
- - name: Get react-native version
+ - name: Checkout new ref
run: |
- echo "VERSION=$(jq -r '.dependencies["react-native"]' package.json)" >> $GITHUB_ENV
-
- - name: Setup Node
- uses: ./.github/actions/composite/setupNode
-
- - name: Setup Java
- # v4
- uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12
- with:
- distribution: oracle
- java-version: 17
+ git fetch origin ${{ github.event.after }} --depth=1
+ git checkout ${{ github.event.after }}
+ git submodule update
- - name: Setup Gradle
- # v4
- uses: gradle/actions/setup-gradle@06832c7b30a0129d7fb559bcc6e43d26f6374244
+ - name: Get new commit hash
+ id: getNewHash
+ run: echo "HASH=$(git rev-parse ${{ matrix.is_hybrid == 'true' && ':Mobile-Expensify' || 'HEAD' }})" >> "$GITHUB_OUTPUT"
- - name: Save patches hash
- run: |
- echo "PATCHES_HASH=$(./.github/scripts/computePatchesHash.sh)" >> $GITHUB_ENV
- env:
- VERSION: ${{ env.VERSION }}
- PATCHES_PATHS: "patches"
+ - name: Get new react-native version
+ id: getNewVersion
+ run: echo "VERSION=$(jq -r '.dependencies["react-native"]' package.json)" >> "$GITHUB_OUTPUT"
- - name: Determine new patched RN version
+ - name: Check if version changed
+ id: didVersionChange
run: |
- echo "NEW_PATCHED_VERSION=$(./.github/scripts/getNewPatchedRNVersion.sh)" >> $GITHUB_ENV
- env:
- VERSION: ${{ env.VERSION }}
- GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- IS_HYBRID_BUILD: "false"
+ readonly DID_VERSION_CHANGE=${{ steps.getOldVersion.outputs.VERSION != steps.getNewVersion.outputs.VERSION && 'true' || 'false' }}
+ echo "DID_VERSION_CHANGE=$DID_VERSION_CHANGE" >> "$GITHUB_OUTPUT"
+ if [[ "$DID_VERSION_CHANGE" == 'true' ]]; then
+ echo "::notice::Detected react-native version bump (${{ steps.getOldVersion.outputs.VERSION }} -> ${{ steps.getNewVersion.outputs.VERSION }})"
+ fi
- - name: Build and publish RN artifacts
+ - name: Check if patches changed
+ id: didPatchesChange
run: |
- cd android
- echo "Starting artifacts build for standalone NewDot"
- echo "Version: ${{ env.NEW_PATCHED_VERSION }}"
- echo "Commit hash: ${{ env.COMMIT_HASH }}"
- echo "Patches hash: ${{ env.PATCHES_HASH }}"
- export ORG_GRADLE_PROJECT_reactNativeArchitectures="armeabi-v7a,arm64-v8a,x86,x86_64"
- ./gradlew buildReactNativeArtifacts -x lint -x test -x check
- ./gradlew publishReactNativeArtifacts
- env:
- GH_PUBLISH_ACTOR: ${{ github.actor }}
- GH_PUBLISH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- IS_HYBRID_BUILD: "false"
- PATCHED_VERSION: ${{ env.NEW_PATCHED_VERSION }}
- COMMIT_HASH: ${{ github.event.after }}
- PATCHES_HASH: ${{ env.PATCHES_HASH }}
-
- buildAndPublishRNArtifactsForHybridApp:
- runs-on: ubuntu-latest
- if: ${{ always() && (needs.verifyNewDotPatchesAndReactNativeVersion.result == 'success' || needs.verifyHybridAppPatches.result == 'success')}}
- needs: [verifyNewDotPatchesAndReactNativeVersion, verifyHybridAppPatches]
- steps:
- - name: Checkout
- # v4
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
- with:
- submodules: true
+ if git ${{ matrix.is_hybrid == 'true' && '-C Mobile-Expensify' }} diff --exit-code --name-only ${{ steps.getOldHash.outputs.HASH }}..${{ steps.getNewHash.outputs.HASH }} -- patches/react-native+*.patch; then
+ echo "::notice::Detected changes in NewDot patches"
+ echo "DID_PATCHES_CHANGE=true" >> "$GITHUB_OUTPUT"
+ else
+ echo "DID_PATCHES_CHANGE=false" >> "$GITHUB_OUTPUT"
+ fi
- - name: Get react-native version
+ - name: Check if we should build and publish the package
+ id: shouldPublish
run: |
- echo "VERSION=$(jq -r '.dependencies["react-native"]' package.json)" >> $GITHUB_ENV
+ if [[ '${{ steps.didVersionChange.outputs.DID_VERSION_CHANGE }}' == 'true' || '${{ steps.didPatchesChange.outputs.DID_PATCHES_CHANGE }}' == 'true ]]; then
+ echo "SHOULD_PUBLISH=true" >> "$GITHUB_OUTPUT"
+ else
+ echo "::notice::No relevant changes, skipping publishing a new React Native build"
+ echo "SHOULD_PUBLISH=false" >> "$GITHUB_OUTPUT"
+ fi
- name: Setup Node
+ if: ${{ steps.shouldPublish.outputs.SHOULD_PUBLISH == 'true' }}
uses: ./.github/actions/composite/setupNode
with:
- IS_HYBRID_BUILD: "true"
+ IS_HYBRID_BUILD: ${{ matrix.is_hybrid }}
+ # v4
- name: Setup Java
- # v4
+ if: ${{ steps.shouldPublish.outputs.SHOULD_PUBLISH == 'true' }}
uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12
with:
distribution: oracle
java-version: 17
+ # v4
- name: Setup Gradle
- # v4
+ if: ${{ steps.shouldPublish.outputs.SHOULD_PUBLISH == 'true' }}
uses: gradle/actions/setup-gradle@06832c7b30a0129d7fb559bcc6e43d26f6374244
- - name: Save patches hash
- run: |
- echo "PATCHES_HASH=$(./.github/scripts/computePatchesHash.sh)" >> $GITHUB_ENV
- env:
- VERSION: ${{ env.VERSION }}
- PATCHES_PATHS: "patches Mobile-Expensify/patches"
-
- name: Determine new patched RN version
- run: |
- echo "NEW_PATCHED_VERSION=$(./.github/scripts/getNewPatchedRNVersion.sh)" >> $GITHUB_ENV
+ if: ${{ steps.shouldPublish.outputs.SHOULD_PUBLISH == 'true' }}
+ id: getNewPatchedVersion
+ run: echo "NEW_PATCHED_VERSION=$(./.github/scripts/getNewPatchedRNVersion.sh)" >> $GITHUB_OUTPUT
env:
- VERSION: ${{ env.VERSION }}
- GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- IS_HYBRID_BUILD: "true"
+ GITHUB_TOKEN: ${{ github.token }}
+ IS_HYBRID_BUILD: ${{ matrix.is_hybrid }}
+
- name: Build and publish RN artifacts
+ if: ${{ steps.shouldPublish.outputs.SHOULD_PUBLISH == 'true' }}
+ working-directory: ${{ matrix.is_hybrid == 'true' && 'Mobile-Expensify/Android' || 'android' }}
run: |
- cd Mobile-Expensify/Android
- echo "Starting artifacts build for HybridApp"
- echo "Version: ${{ env.NEW_PATCHED_VERSION }}"
+ echo "Starting artifacts build for ${{ matrix.is_hybrid == 'true' && 'HybridApp' || 'NewDot Standalone' }}"
+ echo "Version: ${{ env.PATCHED_VERSION }}"
echo "Commit hash: ${{ env.COMMIT_HASH }}"
- echo "Patches hash: ${{ env.PATCHES_HASH }}"
export ORG_GRADLE_PROJECT_reactNativeArchitectures="armeabi-v7a,arm64-v8a,x86,x86_64"
./gradlew buildReactNativeArtifacts -x lint -x test -x check
./gradlew publishReactNativeArtifacts
env:
GH_PUBLISH_ACTOR: ${{ github.actor }}
- GH_PUBLISH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- IS_HYBRID_BUILD: "true"
- PATCHED_VERSION: ${{ env.NEW_PATCHED_VERSION }}
+ GH_PUBLISH_TOKEN: ${{ github.token }}
+ IS_HYBRID_BUILD: ${{ matrix.is_hybrid }}
+ PATCHED_VERSION: ${{ steps.getNewPatchedVersion.outputs.NEW_PATCHED_VERSION }}
COMMIT_HASH: ${{ github.event.after }}
- PATCHES_HASH: ${{ env.PATCHES_HASH }}
diff --git a/patches/react-native+0.77.1+024+publish-gradle.patch b/patches/react-native+0.77.1+024+publish-gradle.patch
index 415b83af56e..e7e7877be6d 100644
--- a/patches/react-native+0.77.1+024+publish-gradle.patch
+++ b/patches/react-native+0.77.1+024+publish-gradle.patch
@@ -4,7 +4,7 @@ index 32287a7..68c9284 100644
+++ b/node_modules/react-native/ReactAndroid/publish.gradle
@@ -13,7 +13,11 @@ def signingKey = findProperty("SIGNING_KEY")
def signingPwd = findProperty("SIGNING_PWD")
-
+
def reactAndroidProjectDir = project(':packages:react-native:ReactAndroid').projectDir
-def mavenTempLocalUrl = "file:///tmp/maven-local"
+def mavenURL = "https://maven.pkg.github.com/Expensify/App"
@@ -12,13 +12,13 @@ index 32287a7..68c9284 100644
+def patchedVersion = System.getenv("PATCHED_VERSION")
+def isHybridBuild = System.getenv("IS_HYBRID_BUILD")?.toBoolean()
+def publishingGroupId = isHybridBuild ? "com.expensify.react-standalone" : "com.expensify.react-hybrid"
-
+
publishing {
publications {
@@ -26,12 +30,14 @@ publishing {
}
}
-
+
+ groupId = publishingGroupId
+
// We populate the publishing version using the project version,
@@ -30,14 +30,13 @@ index 32287a7..68c9284 100644
- version = this.version
+ version = patchedVersion
}
-
+
pom {
@@ -39,10 +45,15 @@ publishing {
description = "A framework for building native apps with React"
url = "https://github.com/facebook/react-native"
-
+
+ properties = [
-+ "patchesHash": System.getenv("PATCHES_HASH"),
+ "commitHash": System.getenv("COMMIT_HASH"),
+ ]
+
@@ -49,9 +48,9 @@ index 32287a7..68c9284 100644
+ name = "Expensify"
}
}
-
+
@@ -65,8 +76,11 @@ publishing {
-
+
repositories {
maven {
- name = "mavenTempLocal"
Just the workflow, because the diff is hard to read
name: Build and publish React Native artifacts
on:
push:
branches:
- main
paths:
- package.json
- patches/react-native+*.patch
- Mobile-Expensify
jobs:
publish:
runs-on: ${{ github.repository_owner == 'Expensify' && 'ubuntu-latest-xl' || 'ubuntu-latest' }}
strategy:
matrix:
is_hybrid: [true, false]
env:
PATCHES_PATHS: ${{ matrix.is_hybrid && 'Mobile-Expensify/patches' || 'patches' }}
steps:
# v4
- name: Checkout
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
with:
submodules: ${{ matrix.is_hybrid }}
ref: ${{ github.event.before }}
- name: Get previous commit hash
id: getOldHash
run: echo "HASH=$(git rev-parse ${{ matrix.is_hybrid == 'true' && ':Mobile-Expensify' || 'HEAD' }})" >> "$GITHUB_OUTPUT"
- name: Get previous react-native version
id: getOldVersion
run: echo "VERSION=$(jq -r '.dependencies["react-native"]' package.json)" >> "$GITHUB_OUTPUT"
- name: Checkout new ref
run: |
git fetch origin ${{ github.event.after }} --depth=1
git checkout ${{ github.event.after }}
git submodule update
- name: Get new commit hash
id: getNewHash
run: echo "HASH=$(git rev-parse ${{ matrix.is_hybrid == 'true' && ':Mobile-Expensify' || 'HEAD' }})" >> "$GITHUB_OUTPUT"
- name: Get new react-native version
id: getNewVersion
run: echo "VERSION=$(jq -r '.dependencies["react-native"]' package.json)" >> "$GITHUB_OUTPUT"
- name: Check if version changed
id: didVersionChange
run: |
readonly DID_VERSION_CHANGE=${{ steps.getOldVersion.outputs.VERSION != steps.getNewVersion.outputs.VERSION && 'true' || 'false' }}
echo "DID_VERSION_CHANGE=$DID_VERSION_CHANGE" >> "$GITHUB_OUTPUT"
if [[ "$DID_VERSION_CHANGE" == 'true' ]]; then
echo "::notice::Detected react-native version bump (${{ steps.getOldVersion.outputs.VERSION }} -> ${{ steps.getNewVersion.outputs.VERSION }})"
fi
- name: Check if patches changed
id: didPatchesChange
run: |
if git ${{ matrix.is_hybrid == 'true' && '-C Mobile-Expensify' }} diff --exit-code --name-only ${{ steps.getOldHash.outputs.HASH }}..${{ steps.getNewHash.outputs.HASH }} -- patches/react-native+*.patch; then
echo "::notice::Detected changes in NewDot patches"
echo "DID_PATCHES_CHANGE=true" >> "$GITHUB_OUTPUT"
else
echo "DID_PATCHES_CHANGE=false" >> "$GITHUB_OUTPUT"
fi
- name: Check if we should build and publish the package
id: shouldPublish
run: |
if [[ '${{ steps.didVersionChange.outputs.DID_VERSION_CHANGE }}' == 'true' || '${{ steps.didPatchesChange.outputs.DID_PATCHES_CHANGE }}' == 'true ]]; then
echo "SHOULD_PUBLISH=true" >> "$GITHUB_OUTPUT"
else
echo "::notice::No relevant changes, skipping publishing a new React Native build"
echo "SHOULD_PUBLISH=false" >> "$GITHUB_OUTPUT"
fi
- name: Setup Node
if: ${{ steps.shouldPublish.outputs.SHOULD_PUBLISH == 'true' }}
uses: ./.github/actions/composite/setupNode
with:
IS_HYBRID_BUILD: ${{ matrix.is_hybrid }}
# v4
- name: Setup Java
if: ${{ steps.shouldPublish.outputs.SHOULD_PUBLISH == 'true' }}
uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12
with:
distribution: oracle
java-version: 17
# v4
- name: Setup Gradle
if: ${{ steps.shouldPublish.outputs.SHOULD_PUBLISH == 'true' }}
uses: gradle/actions/setup-gradle@06832c7b30a0129d7fb559bcc6e43d26f6374244
- name: Determine new patched RN version
if: ${{ steps.shouldPublish.outputs.SHOULD_PUBLISH == 'true' }}
id: getNewPatchedVersion
run: echo "NEW_PATCHED_VERSION=$(./.github/scripts/getNewPatchedRNVersion.sh)" >> $GITHUB_OUTPUT
env:
GITHUB_TOKEN: ${{ github.token }}
IS_HYBRID_BUILD: ${{ matrix.is_hybrid }}
- name: Build and publish RN artifacts
if: ${{ steps.shouldPublish.outputs.SHOULD_PUBLISH == 'true' }}
working-directory: ${{ matrix.is_hybrid == 'true' && 'Mobile-Expensify/Android' || 'android' }}
run: |
echo "Starting artifacts build for ${{ matrix.is_hybrid == 'true' && 'HybridApp' || 'NewDot Standalone' }}"
echo "Version: ${{ env.PATCHED_VERSION }}"
echo "Commit hash: ${{ env.COMMIT_HASH }}"
export ORG_GRADLE_PROJECT_reactNativeArchitectures="armeabi-v7a,arm64-v8a,x86,x86_64"
./gradlew buildReactNativeArtifacts -x lint -x test -x check
./gradlew publishReactNativeArtifacts
env:
GH_PUBLISH_ACTOR: ${{ github.actor }}
GH_PUBLISH_TOKEN: ${{ github.token }}
IS_HYBRID_BUILD: ${{ matrix.is_hybrid }}
PATCHED_VERSION: ${{ steps.getNewPatchedVersion.outputs.NEW_PATCHED_VERSION }}
COMMIT_HASH: ${{ github.event.after }}
I'm not sure what you mean by this.
Looks like So we should be good with the standard token rather than another bot token |
Sorry, I meant that this PR only added mechanism that builds I thought it would be nice to implement this second part in another PR as it gives us better control and minimizes the risk of breaking local or CI builds if something goes wrong. |
|
Cool, that makes sense to me - create the artifacts in one PR and consume them in another |
|
Pasting a part of suggested refactored workflow to discuss it: When In general, HybridApp artifacts should be created in this 3 scenarios:
|
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mateuuszzzzz
changed the title
|
actionslint is still failing - you can check it with |
|
diff to fix it: diff --git a/.github/workflows/publishReactNativeAndroidArtifacts.yml b/.github/workflows/publishReactNativeAndroidArtifacts.yml
index 8b91bc5a175..30c2f05ecd6 100644
--- a/.github/workflows/publishReactNativeAndroidArtifacts.yml
+++ b/.github/workflows/publishReactNativeAndroidArtifacts.yml
@@ -31,7 +31,7 @@ jobs:
- name: Get previous Mobile-Expensify commit hash
if: ${{ matrix.is_hybrid == 'true' }}
id: getOldMobileExpensifyHash
- run: echo "HASH=$(git rev-parse :Mobile-Expensify) >> "$GITHUB_OUTPUT"
+ run: echo "HASH=$(git rev-parse :Mobile-Expensify)" >> "$GITHUB_OUTPUT"
- name: Get previous react-native version
id: getOldVersion
@@ -87,7 +87,7 @@ jobs:
- name: Check if we should build and publish the package
id: shouldPublish
run: |
- if [[ '${{ steps.didVersionChange.outputs.DID_VERSION_CHANGE }}' == 'true' || '${{ steps.didPatchesChange.outputs.DID_PATCHES_CHANGE }}' == 'true ]]; then
+ if [[ '${{ steps.didVersionChange.outputs.DID_VERSION_CHANGE }}' == 'true' || '${{ steps.didPatchesChange.outputs.DID_PATCHES_CHANGE }}' == 'true' ]]; then
echo "SHOULD_PUBLISH=true" >> "$GITHUB_OUTPUT"
else
echo "::notice::No relevant changes, skipping publishing a new React Native build"
@@ -116,7 +116,7 @@ jobs:
- name: Determine new patched RN version
if: ${{ steps.shouldPublish.outputs.SHOULD_PUBLISH == 'true' }}
id: getNewPatchedVersion
- run: echo "NEW_PATCHED_VERSION=$(./.github/scripts/getNewPatchedRNVersion.sh)" >> $GITHUB_OUTPUT
+ run: echo "NEW_PATCHED_VERSION=$(./.github/scripts/getNewPatchedRNVersion.sh)" >> "$GITHUB_OUTPUT"
env:
GITHUB_TOKEN: ${{ github.token }}
IS_HYBRID_BUILD: ${{ matrix.is_hybrid }}
|
roryabraham
approved these changes
Apr 24, 2025
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
50 tasks
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
This didn't work as written - we needed to use the |
|
Second test run after fast-follower: https://github.com/Expensify/App/actions/runs/14652470386/job/41121256064 |
|
looks like that worked 🎉 |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊 (1/6)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (2/6)Meaningless Changes To Duration (1/5)Show entries
Show details
|
Performance Comparison Report 📊 (3/6)Meaningless Changes To Duration (2/5)Show entries
Show details
|
Performance Comparison Report 📊 (4/6)Meaningless Changes To Duration (3/5)Show entries
Show details
|
Performance Comparison Report 📊 (5/6)Meaningless Changes To Duration (4/5)Show entries
Show details
|
Performance Comparison Report 📊 (6/6)Meaningless Changes To Duration (5/5)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.33-0 🚀
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.35-1 🚀
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.36-3 🚀
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.37-1 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.37-3 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
PR adds workflow that builds and publishes patched react-native artifacts.
NOTE:⚠️ This PR has its
Mobile-Expensifypart. We need to merge it first: https://github.com/Expensify/Mobile-Expensify/pull/13545Fixed Issues
$ #57120
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13545
Tests
react-standaloneandreact-hybridOffline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop