Skip to content

[Better Expense Report View] Fix TransactionPreview merchant overflowing on mobile devices and Export button display in MoneyRequestReportPreview #59718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2025
Merged

[Better Expense Report View] Fix TransactionPreview merchant overflowing on mobile devices and Export button display in MoneyRequestReportPreview #59718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b182bec
Add flexShrink to merchant in TransactionPreview
JakubKorytko Apr 7, 2025
805b45f
Add gap between merchant and amount
JakubKorytko Apr 7, 2025
6a54d76
Add negation to RBR conditional in export button
JakubKorytko Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...omponents/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ function MoneyRequestReportPreviewContent({
isLoading={!isOffline && !canAllowSettlement}
/>
)}
{!!shouldShowExportIntegrationButton && !shouldShowSettlementButton && shouldShowRBR && (
{!!shouldShowExportIntegrationButton && !shouldShowSettlementButton && !shouldShowRBR && (
<ExportWithDropdownMenu
policy={policy}
report={iouReport}
Expand Down
3 changes: 2 additions & 1 deletion src/components/ReportActionItem/TransactionPreview/TransactionPreviewContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,13 @@ function TransactionPreviewContent({
styles.flexRow,
styles.alignItemsCenter,
isBillSplit && !shouldShowMerchantOrDescription ? styles.justifyContentEnd : styles.justifyContentBetween,
styles.gap2,
]}
>
{shouldShowMerchantOrDescription && (
<Text
fontSize={variables.fontSizeNormal}
style={[isDeleted && styles.lineThrough]}
style={[isDeleted && styles.lineThrough, styles.flexShrink1]}
numberOfLines={1}
>
{merchantOrDescription}
Expand Down