Set testing receipt as scan complete and hardcode known data #59573

aldo-expensify · 2025-04-03T01:46:15Z

Explanation of Change

Added a key isTestReceipt: true in the type Receipt. I chose true instead of boolean because I'm not planning on adding the key when this is not a test receipt.

When the test receipt is added from tutorial tootip, the receipt is created with isTestReceipt, which should be more reliable than checking for the filename.

I'm setting the known amount/currency/merchant/scanstate = complete as soon as the user presses the "Create expense". If I set it early, the text of the button changes and it includes the amount. I assumed we didn't want the button showing the amount because this is simulating a "smartscan":

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/473128
PROPOSAL:

Tests

Check that the flow with the testing receipt works:

Create an account
Click the big green plus button and select "Create Expense"
The panel to create a Scan expense should open with a tooltip:
Click "Try it out"
Click "Create expense"
Verify the expense in the chat with manager_mctest looks correct and paid, also check the LHN:

Check that the flow with a custom user uploaded works:

Create an account
Click the big green plus button and select "Create Expense"
The panel to create a Scan expense should open with a tooltip:
DON'T click "Try it out", instead upload a custom receipt and send it to [email protected]
Click "Create expense"
Verify the expense in the chat with manager_mctest is waiting to be scanned

Verify that no errors appear in the JS console

Offline tests

QA Steps

Check that the flow with the testing receipt works:

Create an account
Click the big green plus button and select "Create Expense"
The panel to create a Scan expense should open with a tooltip:
Click "Try it out"
Click "Create expense"
Verify the expense in the chat with manager_mctest looks correct and paid, also check the LHN:

Check that the flow with a custom user uploaded works:

Create an account
Click the big green plus button and select "Create Expense"
The panel to create a Scan expense should open with a tooltip:
DON'T click "Try it out", instead upload a custom receipt and send it to [email protected]
Click "Create expense"
Verify the expense in the chat with manager_mctest is waiting to be scanned

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-04-02.at.6.48.27.PM.mov

MacOS: Desktop

melvin-bot · 2025-04-03T01:46:19Z

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2025-04-03T06:34:23Z

@grgia there is a small bug because the server doesn't seem to be sending the iouReport referenced by the transaction preview using the test receipt in OpenApp. This is visible if you log out and log back in.

Before logging out:

After logging back in:

I can work on this tomorrow

grgia

Thank you for working on this, looking great 🏎️

grgia · 2025-04-03T13:32:18Z

there is a small bug because the server doesn't seem to be sending the iouReport referenced by the transaction preview using the test receipt in OpenApp. This is visible if you log out and log back in.

@aldo-expensify nice catch- do you have an issue for this already?

grgia · 2025-04-03T13:32:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

grgia · 2025-04-03T13:33:16Z

Btw, the QA steps you wrote are really thorough, nice job on those!

github-actions · 2025-04-03T13:34:17Z

🚧 @grgia has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-03T14:15:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59573-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59573-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59573/NewExpensify.dmg	https://59573.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

aldo-expensify · 2025-04-03T17:04:50Z

@aldo-expensify nice catch- do you have an issue for this already?

No, I think I can just use the original issue: https://github.com/Expensify/Expensify/issues/473128

I want to check first if this is also happening for manual transactions that get paid. Maybe it is by design that we are not sending the liked report if it is already paid.

OSBotify · 2025-04-03T17:14:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-07T23:09:43Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

izarutskaya · 2025-04-08T12:16:57Z

@aldo-expensify Team found issue #59778

github-actions · 2025-04-09T02:14:59Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:33:20Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

aldo-expensify added 2 commits April 2, 2025 18:39

Complete test receipt data instantly

9623736

Prettier

4ee8646

aldo-expensify requested a review from grgia April 3, 2025 01:46

aldo-expensify self-assigned this Apr 3, 2025

aldo-expensify requested a review from a team as a code owner April 3, 2025 01:46

melvin-bot bot removed the request for review from a team April 3, 2025 01:46

Add isTestReceipt

be5a6d3

aldo-expensify changed the title ~~Aldo fix optimistic data test receipt~~ Fix optimistic data test receipt Apr 3, 2025

aldo-expensify changed the title ~~Fix optimistic data test receipt~~ Set testing receipt as scan complete and hardcode known data Apr 3, 2025

grgia approved these changes Apr 3, 2025

View reviewed changes

aldo-expensify merged commit de33a98 into main Apr 3, 2025
18 checks passed

aldo-expensify deleted the aldo_fix-optimistic-data-test-receipt branch April 3, 2025 17:06

github-actions bot mentioned this pull request Apr 7, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

mitarachim mentioned this pull request Apr 8, 2025

[Due for payment 2025-04-30] [$250] Web-LHN preview shows "You: Manager:" instead of "Manager:" #59778

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Set testing receipt as scan complete and hardcode known data #59573

Set testing receipt as scan complete and hardcode known data #59573

Uh oh!

aldo-expensify commented Apr 3, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Apr 3, 2025

Uh oh!

aldo-expensify commented Apr 3, 2025

Uh oh!

grgia left a comment

Uh oh!

grgia commented Apr 3, 2025

Uh oh!

grgia commented Apr 3, 2025 •

edited

Loading

Uh oh!

grgia commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

aldo-expensify commented Apr 3, 2025

Uh oh!

Uh oh!

OSBotify commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

izarutskaya commented Apr 8, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

Uh oh!

Set testing receipt as scan complete and hardcode known data #59573

Set testing receipt as scan complete and hardcode known data #59573

Uh oh!

Conversation

aldo-expensify commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 3, 2025

Uh oh!

aldo-expensify commented Apr 3, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented Apr 3, 2025

Uh oh!

grgia commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

grgia commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

aldo-expensify commented Apr 3, 2025

Uh oh!

Uh oh!

OSBotify commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

izarutskaya commented Apr 8, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

Uh oh!

aldo-expensify commented Apr 3, 2025 •

edited

Loading

grgia commented Apr 3, 2025 •

edited

Loading