[Pre RN 0.79] Migrate documents picker

[war-in]

Explanation of Change

I'm working on RN 0.78 support #58914 and I found out that the @react-native-document-picker has to be bumped because it supports React Native 0.78 since 10.x.x

Fixed Issues

$ #57511
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13510

Tests

1. Open app and verify it runs correctly

2. Go to chat and send attachment

3. Verify that the flow is correct

4. In ios native, select Create Expense

5. Scan and choose image taken on the iphone in gallery (so its the ios heic format)

6. Note you have to choose the image from gallery, taking the picture in the app works fine

7. Create this expense

8. Verify it works

Offline tests

QA Steps

1. Open app and verify it runs correctly

2. Go to chat and send attachment

3. Verify that the flow is correct

4. In ios native, select Create Expense

5. Scan and choose image taken on the iphone in gallery (so its the ios heic format)

6. Note you have to choose the image from gallery, taking the picture in the app works fine

7. Create this expense

8. Verify it works

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.Apr.11.2025.from.Marcin.Warchol.mp4

Android: mWeb Chrome

iOS: Native

O.Rany.Messenger.Video.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[melvin-bot]

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

[shubham1206agra]

@mountiny This can't be tested on Hybrid iOS App on simulator.

[shubham1206agra]

@war-in When picking the PDF file, this error appears.

[war-in]

@shubham1206agra I tested on my iOS device and there is no error on this PR but asked Vit for a retest
Feel free to re-review or approve 🙏

[mountiny]

Will test later thanks

[github-actions]

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59363-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59363-hybrid/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59363/NewExpensify.dmg	https://59363.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[roryabraham]

Retesting the issue in question: https://expensify.slack.com/archives/C049HHMV9SM/p1744647887778349

[roryabraham]

yeah, so on the latest staging TestFlight version, I can upload an heic and view it just fine. But on this AdHoc build I could upload it fine but then not view it afterwards. So I think this PR would cause a regression unless that's fixed

[mountiny]

It worked

[mountiny]

I mean uploading heic photo from the gallery on iPhone

[roryabraham]

Well I was able to upload the photo (and even view it on other devices), but on the AdHoc build I couldn't view it on the device in which it was uploaded. The preview showed, but after upload it was not rendering at all.

Not sure if that will be reproducible for others as well

[war-in]

@roryabraham yeah, facing the same issue, but!
I check on another ad-hoc build and it also has the same issue (doesn't touch AttachmentPicker)

The bug might be caused by the new reports project, which is currently behind beta (and we all have access to it). I logged into my regular gmail account and the flow works fine so the problem seems unrelated :)

[Kicu]

If its related to canUseTableReport BETA then the clicking on preview can be tracked in this issue: #57509

[mountiny]

@war-in Cna you please update the test/ QA steps to include the ios flow scanning a receipt for expense and choosing an heic image from gallery?

@shubham1206agra Can you please complete the review/ approve if all works well for you? thanks!

[war-in]

@mountiny steps updated

[mountiny]

@shubham1206agra were you able to reproduce the issue Rory mentioned?

[shubham1206agra]

@allgandalf tested this here https://expensify.slack.com/archives/C02NK2DQWUX/p1744895681338739?thread_ts=1744893413.115159&cid=C02NK2DQWUX and he did not encountered this issue.

[mountiny]

I have tested again on the adhoc build and both creating expense and adding attachment worked fine for me also I could see the images just fine on the build and on staging web after ✅

[mountiny]

I think we are ready to go and test this out so going to merge this and the OldApp PR

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.31-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.31-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[rayane-d]

Upgrading @react-native-documents/picker to 10.1.1 caused this bug: #60600