Skip to content

fix: no preview message after switching priorities #59252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mustafapsd
Copy link
Contributor

@mustafapsd mustafapsd commented Mar 27, 2025

Explanation of Change

The current solution tries to get the full report, but we can simplify it by just formatting the message from the lastReportAction object directly if there is no report. I need to get actorDetails because there is a user email instead of their name in the last message. Here's how we can modify the code:

lastMessageTextFromReport = formatReportLastMessageText(reportPreviewMessage);

if (!lastMessageTextFromReport) {
    const lastReportActionMessage = getReportActionMessageText(lastReportAction);
    lastMessageTextFromReport = lastReportActionMessage;

    // Get the actor's display name instead of using email
    const actorAccountID = lastReportAction?.actorAccountID;
    const actorDetails = actorAccountID ? allPersonalDetails?.[actorAccountID] : null;

    if (actorDetails) {
        const actorDisplayName = getLastActorDisplayName(actorDetails);
        const actorLastName = getLastActorLastName(actorDetails);

        const actorName = actorLastName ? `${actorDisplayName} ${actorLastName}` : actorDisplayName;

        // Format the message with the display name if available
        if (actorDisplayName && actorDetails.login) {
            lastMessageTextFromReport = lastMessageTextFromReport.replace(actorDetails.login, actorName);
        }
    }
}

This solution uses two helper functions:

  1. getLastActorDisplayName - Gets the first name or display name of the actor (Exists)
  2. getLastActorLastName - Gets the last name of the actor (I added):
function getLastActorLastName(lastActorDetails: Partial<PersonalDetails> | null) {
    if (!lastActorDetails) {
        return '';
    }

    return lastActorDetails.accountID !== currentUserAccountID
        ? // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
          lastActorDetails.lastName || ''
        : '';
}

Together, these functions ensure that when there's no formatted report preview message, we still get a properly formatted message with full names instead of email addresses.

Fixed Issues

$ #58879
PROPOSAL: $ #58879 (comment)

Tests

  1. Open the Expensify app.
  2. Tap on FAB and select "Create Chat"
  3. Start an individual chat with another user.
  4. Create an expense in it.
  5. Repeat steps 2 to 5 with one or more chats.
  6. Note that the preview on the individual chats, display the sent expense information.
  7. Navigate to settings and select "Preferences"
  8. Change the priority mode to "Focus"
  9. Change it again to "Most Recent"
  10. Return to inbox.
  11. Check the message displayed on preview of individual chats after this last action.
  • Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
2025-04-05_21-23-33.mp4
Android: mWeb Chrome
2025-04-05_21-23-33.mp4
iOS: Native
2025-04-05_18-06-26.mp4
iOS: mWeb Safari
2025-04-05_18-10-36.mp4
MacOS: Chrome / Safari
2025-04-04_13-11-10.mp4
MacOS: Desktop
2025-04-05_18-29-39.mp4

@mustafapsd mustafapsd requested a review from a team as a code owner March 27, 2025 19:45
@melvin-bot melvin-bot bot requested review from eh2077 and removed request for a team March 27, 2025 19:45
Copy link

melvin-bot bot commented Mar 27, 2025

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

github-actions bot commented Mar 27, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@mustafapsd
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA


// If lastMessageTextFromReport is empty, try to extract the message from the lastReportAction instead
if (!lastMessageTextFromReport) {
const lastReportActionMessage = getReportActionMessageText(lastReportAction);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After taking a look into method getReportPreviewMessage, I don't think it's a good method because there're quite different. I know the below code will fix the effect but I don't think that's what we prefer.

Is lastReportAction same as lastIOUMoneyReportAction? If so, can we pass lastReportAction to method getReportPreviewMessage

Copy link
Contributor Author

@mustafapsd mustafapsd Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is lastReportAction same as lastIOUMoneyReportAction? If so, can we pass lastReportAction to method getReportPreviewMessage

Good point, I tried it and it works, but we still need to format the message, because it shows the mail address of the user instead of their full name. The code will look like this. What do you think?

@eh2077

Screenshot 2025-03-31 at 20 10 55
            const lastIOUMoneyReportAction = iouReport?.reportID
            ? allSortedReportActions[iouReport.reportID]?.find(
                  (reportAction, key): reportAction is ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.IOU> =>
                      shouldReportActionBeVisible(reportAction, key, canUserPerformWriteAction(report)) &&
                      reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
                      isMoneyRequestAction(reportAction),
              )
            : undefined;
        const reportPreviewMessage = getReportPreviewMessage(
            !isEmptyObject(iouReport) ? iouReport : null,
            lastIOUMoneyReportAction ?? lastReportAction,
            true,
            reportUtilsIsChatReport(report),
            null,
            true,
            lastReportAction,
        );

        lastMessageTextFromReport = formatReportLastMessageText(reportPreviewMessage);

        // If lastIOUMoneyReportAction is empty, format the message with the actor's display name
        if (!lastIOUMoneyReportAction) {
            // Get the actor's display name instead of using email
            const actorAccountID = lastReportAction?.actorAccountID;
            const actorDetails = actorAccountID ? allPersonalDetails?.[actorAccountID] : null;

            if (actorDetails) {
                const actorDisplayName = getLastActorDisplayName(actorDetails);
                const actorLastName = getLastActorLastName(actorDetails);

                const actorName = actorLastName ? `${actorDisplayName} ${actorLastName}` : actorDisplayName;

                // Format the message with the display name if available
                if (actorDisplayName && actorDetails.login) {
                    lastMessageTextFromReport = lastMessageTextFromReport.replace(actorDetails.login, actorName);
                }
            }
        }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we still need to format the message, because it shows the mail address of the user instead of their full name.

@mustafapsd Can you look into method getReportPreviewMessage please? I think we should understand what causes the gap.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this line in the getReportPreviewMessage method, report is undefined, so it returns the message directly without formatting.

image

If the report is not null, the function finishes with this return:

return translateLocal('iou.payerOwesAmount', {payer: payerName ?? '', amount: formattedAmount, comment});

So maybe we can use the same translation key. What do you think?

Thank you for your detailed review @eh2077

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustafapsd I don't agree the difference is just the end return. I saw a lot of IOU report use cases are handled differently in the method. So, I have concern about the solution your solution.

I think we dig a bit more to check if IOU report is available by some way.

Or maybe we can just use the msg return method getReportPreviewMessage according to this comment

App/src/libs/ReportUtils.ts

Lines 4033 to 4037 in 6bac38c

if (isEmptyObject(report) || !report?.reportID) {
// The iouReport is not found locally after SignIn because the OpenApp API won't return iouReports if they're settled
// As a temporary solution until we know how to solve this the best, we just use the message that returned from BE
return reportActionMessage;
}

Copy link
Contributor Author

@mustafapsd mustafapsd Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, there is a logical mistake. If the report is an empty object, the case will be line 4019, because if it is undefined or an empty object, it will not have a reportID. So those statements are basically the same. Based on the comment, we shouldn't format the message. So, should I remove the formatting lines?

@eh2077

App/src/libs/ReportUtils.ts

Lines 4025 to 4037 in 6bac38c

if (!report?.reportID) {
return reportActionMessage;
}
const allReportTransactions = getReportTransactions(report.reportID);
const transactionsWithReceipts = allReportTransactions.filter(hasReceiptTransactionUtils);
const numberOfScanningReceipts = transactionsWithReceipts.filter(isReceiptBeingScanned).length;
if (isEmptyObject(report) || !report?.reportID) {
// The iouReport is not found locally after SignIn because the OpenApp API won't return iouReports if they're settled
// As a temporary solution until we know how to solve this the best, we just use the message that returned from BE
return reportActionMessage;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustafapsd It's not easy to follow your idea when you mentioned about source code. Just a suggestion, can you just use permanent link to a code snippet method to link source code? Like what I did, so, you don't need to copy the code in your comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean combining the two return cases? If yes, then I agree with you.

App/src/libs/ReportUtils.ts

Lines 4025 to 4038 in 6bac38c

if (!report?.reportID) {
return reportActionMessage;
}
const allReportTransactions = getReportTransactions(report.reportID);
const transactionsWithReceipts = allReportTransactions.filter(hasReceiptTransactionUtils);
const numberOfScanningReceipts = transactionsWithReceipts.filter(isReceiptBeingScanned).length;
if (isEmptyObject(report) || !report?.reportID) {
// The iouReport is not found locally after SignIn because the OpenApp API won't return iouReports if they're settled
// As a temporary solution until we know how to solve this the best, we just use the message that returned from BE
return reportActionMessage;
}

Copy link
Contributor Author

@mustafapsd mustafapsd Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used a perma link, but it doesn't show up somehow. I'm sorry. Yes, these lines are what I mean. In line 4025, if the condition fits line 4033, it also fits the 4025. The program never reaches there, but it returns the same result. So, should we follow the comment? Thank you again @eh2077

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustafapsd

I used a perma link, but it doesn't show up somehow.

It should work right? My input is like

image

In line 4025, if the condition fits line 4033, it also fits the 4025. The program never reaches there, but it returns the same result. So, should we follow the comment?

Yes, I think we can follow the comment. Would you mind improving these lines? Like replace

App/src/libs/ReportUtils.ts

Lines 4025 to 4027 in 6bac38c

if (!report?.reportID) {
return reportActionMessage;
}

with

App/src/libs/ReportUtils.ts

Lines 4033 to 4037 in 6bac38c

if (isEmptyObject(report) || !report?.reportID) {
// The iouReport is not found locally after SignIn because the OpenApp API won't return iouReports if they're settled
// As a temporary solution until we know how to solve this the best, we just use the message that returned from BE
return reportActionMessage;
}

Comment on lines 4018 to 4019
// The iouReport is not found locally after SignIn because the OpenApp API won't return iouReports if they're settled
// As a temporary solution until we know how to solve this the best, we just use the message that returned from BE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustafapsd Can you improve the comments? Since, in this case, I think the iou report is available in local storage but hasn't been loaded into the app.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// The iouReport is not found locally after SignIn because the OpenApp API won't return iouReports if they're settled
// As a temporary solution until we know how to solve this the best, we just use the message that returned from BE
// The IOU report associated with this action might not be loaded into the 'allReports'
// Alternatively, settled IOU reports might not be returned by the backend's OpenApp command.
// In either case, we lack the full report details needed for rich formatting,
// As a temporary solution until we know how to solve this the best, we just use the message that returned from BE

Will this work?

@mustafapsd mustafapsd requested a review from eh2077 April 4, 2025 17:31
@eh2077
Copy link
Contributor

eh2077 commented Apr 5, 2025

@mustafapsd Please use the original PR template to include recordings for all platforms. You can take a look at other PRs.

@mustafapsd
Copy link
Contributor Author

Updated! @eh2077

@eh2077
Copy link
Contributor

eh2077 commented Apr 7, 2025

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Screen.Recording.2025-04-07.at.9.41.41.PM.mov
Android: mWeb Chrome
Screen.Recording.2025-04-07.at.9.38.31.PM.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2025-04-07.at.9.37.52.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2025-04-07.at.9.32.12.PM.mov
MacOS: Desktop
Screen.Recording.2025-04-07.at.9.52.33.PM.mov

@eh2077
Copy link
Contributor

eh2077 commented Apr 7, 2025

@mustafapsd Some of your recordings can't be previewed. Can you please upload them using the default template

### Screenshots/Videos
<details>
<summary>Android: Native</summary>

<!-- add screenshots or videos here -->

</details>

<details>
<summary>Android: mWeb Chrome</summary>

<!-- add screenshots or videos here -->

</details>

<details>
<summary>iOS: Native</summary>

<!-- add screenshots or videos here -->

</details>

<details>
<summary>iOS: mWeb Safari</summary>

<!-- add screenshots or videos here -->

</details>

<details>
<summary>MacOS: Chrome / Safari</summary>

<!-- add screenshots or videos here -->

</details>

<details>
<summary>MacOS: Desktop</summary>

<!-- add screenshots or videos here -->

</details>

@mustafapsd
Copy link
Contributor Author

Could you check again? Thanks @eh2077

@eh2077
Copy link
Contributor

eh2077 commented Apr 7, 2025

Cool! Thanks for your patience!

Btw, my iOS App build is failing but I saw you tested it well, so I believe it works

@melvin-bot melvin-bot bot requested a review from justinpersaud April 7, 2025 14:07
@eh2077
Copy link
Contributor

eh2077 commented Apr 7, 2025

@justinpersaud This PR needs your help to manually trigger the workflow because this is the first PR from @mustafapsd , thank you

@justinpersaud
Copy link
Contributor

approved them

@justinpersaud
Copy link
Contributor

@mustafapsd none of your commits are signed. Can you please follow this and update your commits?

You also have some linting errors.

…neyReportAction

Ensure the report preview message is correctly formatted by using lastReportAction as a fallback when lastIOUMoneyReportAction is null. This prevents empty message texts and improves the display of actor details.

Signed-off-by: Mustafa Daglioglu <[email protected]>
Signed-off-by: Mustafa Daglioglu <[email protected]>
@mustafapsd mustafapsd force-pushed the fix-switch-priority-last-message-preview branch from f350078 to 10c3dfb Compare April 7, 2025 15:09
@mustafapsd
Copy link
Contributor Author

The linting errors come from the files I didn't work on. I can update them too if you want. I signed the commits now @justinpersaud

@justinpersaud
Copy link
Contributor

Ah ok thanks!

@justinpersaud justinpersaud merged commit c70bc0c into Expensify:main Apr 7, 2025
16 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Apr 7, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.1.24-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Copy link
Contributor

github-actions bot commented Apr 9, 2025

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

1 similar comment
Copy link
Contributor

github-actions bot commented Apr 9, 2025

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants