Skip to content

Revert "fix: use dismissModal action instead" #58840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

aldo-expensify
Copy link
Contributor

Reverts #58786

@aldo-expensify aldo-expensify requested a review from a team as a code owner March 20, 2025 18:36
@melvin-bot melvin-bot bot requested a review from jasperhuangg March 20, 2025 18:36
Copy link

melvin-bot bot commented Mar 20, 2025

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 20, 2025 18:36
@aldo-expensify aldo-expensify self-assigned this Mar 20, 2025
@luacmartins luacmartins removed the request for review from jasperhuangg March 20, 2025 18:36
@luacmartins
Copy link
Contributor

Straight revert. Merging.

@luacmartins luacmartins merged commit 4133a37 into main Mar 20, 2025
14 of 16 checks passed
@luacmartins luacmartins deleted the revert-58786-fix/58497 branch March 20, 2025 18:42
@melvin-bot melvin-bot bot added the Emergency label Mar 20, 2025
Copy link

melvin-bot bot commented Mar 20, 2025

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.17-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.17-1 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants