-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[NoQA] fix: Split up too big output files in E2E performance pipelines #58740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] fix: Split up too big output files in E2E performance pipelines #58740
Conversation
@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Performance Test Results (Part aa)Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Performance Test Results (Part ab)
| App start time nativeLaunch | Baseline |
Performance Test Results (Part ac)
| App start time regularAppStart | Baseline |
Performance Test Results (Part ad)
| App start time (RAM) | Baseline |
Performance Test Results (Part ae)
| Open search router TTI Open Search Router TTI | Baseline |
Performance Test Results (Part af)
| Open search router TTI (RAM) | Baseline |
Performance Test Results (Part ag)
| Report typing Message sent | Baseline |
Performance Test Results (Part ah)
| Report typing (RAM) | Baseline |
Performance Test Results (Part ai)
| Chat opening (CPU) | Baseline |
Performance Test Results (Part aj)
| Chat opening (CPU/JS) | Baseline |
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
lol, not sure why the deploy blocker label was added to this one since it's not even merged yet |
@mountiny Do you wanna take over as a reviewer here since you have context on the changes? |
OK |
I will finish this PR by tomorrow. I already have a good picture of what needs to be changed. |
This reverts commit 8103cee.
Kicked off a new build |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment
Co-authored-by: Vit Horacek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.22-0 🚀
|
🚀 Deployed to production by https://github.com/grgia in version: 9.1.22-10 🚀
|
@mountiny
Explanation of Change
Apparently the GitHub CLI doesn't allow posting comments (
gh pr comment
) through with more than 65536 characters. This PR adds logic for splitting up the output file into multiple files if necessary and posting as individual comments.Fixed Issues
$ #58715
$ #59002
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop