-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Feature: Implement ChangeTransactionsReport #58597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
luacmartins
merged 84 commits into
Expensify:main
from
callstack-internal:feature/57468-ChangeTransactionsReport
Apr 14, 2025
Merged
Changes from 27 commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
5d3ff13
add new tranlsations
waterim 54a1e4b
add new action type
waterim 4680cab
add new screen and route
waterim 0371346
update withWritable
waterim 7168ce6
add new report action build
waterim b97b0cd
update confirmation footer
waterim 2666643
update moneyRequestView
waterim 72c84df
create new screen
waterim 2f52373
add new UNREPORTED_TRANSACTION
waterim 48c3444
add new translations
waterim f8e4e7d
update params
waterim 2197850
add and update buildOptimisticUnreportedTransactionAction
waterim b5de70f
add new api params
waterim 697db04
ChangeTransactionsReportParams
waterim e93d40e
update pure and stepReport
waterim 73a2a3f
update original message
waterim 777f8ee
Merge remote-tracking branch 'upstream/main' into feature/57468-Chang…
waterim 56dad97
fix linter
waterim a85f5bd
Merge remote-tracking branch 'upstream/main' into feature/57468-Chang…
waterim b60caf3
fix import
waterim 7b1bea4
add new transaction function
waterim 5e528d8
update requestStep report step
waterim 9855633
Merge remote-tracking branch 'upstream/main' into feature/57468-Chang…
waterim 3884eea
update message types
waterim 5662a31
fix transaction ts
waterim 4c04878
fix requestStep
waterim 3c2d751
update param
waterim 4162fd8
update selectedParticipants check
waterim c7a4825
update reportId to parentReportID
waterim b1a93c9
update route
waterim ff77293
update translations
waterim 2a56d07
update params
waterim 0bff732
update moved/unreported transactions optimistic
waterim 32a4ef2
update buildOptimisticUnreportedTransactionAction
waterim ef2bd05
add fake policy id
waterim 868b44f
update request step
waterim c28ad5c
update params
waterim 29a7100
add selected report
waterim 0c8d6f5
update transaction
waterim 0ef8628
add hasForwardedAction
waterim 715b699
update
waterim a8ad06d
apply changes
waterim 51ee336
Merge remote-tracking branch 'upstream/main' into feature/57468-Chang…
waterim 8e39c24
update transaction
waterim 2093ee8
revert deleted
waterim 8b73cc2
update correct link
waterim 59bc33d
update translations
waterim 4a9caea
apply changes
waterim 649ae99
Merge remote-tracking branch 'upstream/main' into feature/57468-Chang…
waterim fd04917
fix linter
waterim f6fecf6
update key
waterim 214704d
fix ts
waterim c6a0505
fix ts
waterim 823e40a
fix ts
waterim 2374b45
fix ts
waterim aa71e55
provide feedback
waterim d0ecbdc
update optimistic creation
waterim 9af729d
Merge remote-tracking branch 'upstream/main' into feature/57468-Chang…
waterim ec32e10
fix merge conf
waterim 3f707d5
fix linter
waterim 0584d74
fix condition
waterim 70696b3
update condition and update selected
waterim 3807bef
fix reportName
waterim 92384ca
update with new util
waterim 69e56c8
fix lint
waterim 835b6eb
Merge remote-tracking branch 'upstream/main' into feature/57468-Chang…
waterim 8a00c88
fix selection issues
waterim 8cce592
provide feedback
waterim e38c1f9
fix policyID
waterim 54faeac
update report utils
waterim d7de72b
update reportID
waterim 32baeaf
remove unused code
waterim 4f2efa6
update to use transaction report
waterim 02e030a
Merge remote-tracking branch 'upstream/main' into feature/57468-Chang…
waterim 351c22e
prvide feedback
waterim 9b64aac
fix transactionReport
waterim efb86d1
updates
waterim 5d35c8a
fix reassure
waterim e289e34
Merge remote-tracking branch 'upstream/main' into feature/57468-Chang…
waterim 658a9ad
fix condition
waterim 3688002
update search
waterim 84e0536
add comment
waterim 17647a0
fix report passed
waterim 6ec8f3b
Update IOURequestStepConfirmation.tsx
waterim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
type ChangeTransactionsReportParams = { | ||
transactionList: string; | ||
reportID: string; | ||
reportActionIDToThreadReportIDMap: Record<string, string>; // A map linking the optimistic MOVEDTRANSACTION or UNREPORTEDTRANSACTION reportActionID to the transaction thread reportID. | ||
}; | ||
waterim marked this conversation as resolved.
Show resolved
Hide resolved
|
||
export default ChangeTransactionsReportParams; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.