Skip to content

[CP Staging] call scrollToBottom when create new expense #58469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

[CP Staging] call scrollToBottom when create new expense #58469

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5176695
call scrollToBottom when create new expense
huult Mar 14, 2025
285878a
Merge remote-tracking branch 'upstream/main' into 58455-scroll-to-bot…
huult Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/home/report/ReportActionsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,10 +461,11 @@ function ReportActionsList({
return;
}

reportScrollManager.scrollToBottom();
setIsScrollToBottomEnabled(true);
});
},
[report.reportID],
[report.reportID, reportScrollManager],
);
useEffect(() => {
// Why are we doing this, when in the cleanup of the useEffect we are already calling the unsubscribe function?
Expand Down