Fix - QBO - Push input is not cleared when the export method is changed to an export method that has no accounts available. #58370

FitseTLT · 2025-03-13T13:19:50Z

Details

Fixed Issues

Tests

Precondition:
You will test it a workspace with QBO integration which have an export destination with no account payable.

Verify that RBR is shown all the way from Settings > Workspace > the linked workspace with the qbo connection > Accounting > Export > Export out of pocket expenses as
Press Accounting > Export > Export out of pocket expenses as
Verify that choose a valid account for the export error message is displayed
Press on Export as
Choose an export destination that has no account payable linked to it
Verify that an error message is displayed and selecting it is forbidden
Now choose an export destination with account payable linked to it
Verify that it is selected and all the errors and RBR above disappear

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

a.mp4

Android: mWeb Chrome

aw.mp4

iOS: Native

i.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

2025-03-12.21-16-30.mp4

MacOS: Desktop

d.mp4

melvin-bot · 2025-03-13T13:19:55Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2025-03-17T09:26:07Z

@FitseTLT just wanna confirm, is it PR ready for review?

…etting-bug

FitseTLT · 2025-03-17T11:56:23Z

Yes @hoangzinh It might also help to tag design team cc @trjExpensify

trjExpensify · 2025-03-17T12:13:31Z

Yes @hoangzinh It might also help to tag design team cc @trjExpensify

Done. Your vid in the OP has a couple of notes that will be helpful to clarify probably, as they confused me initially as being a bit unexpected:

You had debug mode enabled. That's why we see that "extra" error in the bottom of the LHN.
You were also in offline mode, right? That's why we see the changed "Journal entry" values in 50% opacity once selected?

FitseTLT · 2025-03-17T12:15:34Z

Yes @hoangzinh It might also help to tag design team cc @trjExpensify

Done. Your vid in the OP has a couple of notes that will be helpful to clarify probably, as they confused me initially as being a bit unexpected:

You had debug mode enabled. That's why we see that "extra" error in the bottom of the LHN.

You were also in offline mode, right? That's why we see the changed "Journal entry" values in 50% opacity once selected?

Yes but on android native its online test 👍

shawnborton · 2025-03-17T14:47:33Z

@trjExpensify what are your thoughts on this one? I am very confused by the video tbh... like if you can't select anything here, than why is an option already selected?

trjExpensify · 2025-03-17T15:01:26Z

It's possible that you had vendor bill selected as the export destination and then removed the A/P account in QBO after which would cause the error. I also think vendor bill export is the default export destination on initial connection, and so if you don't have an A/P account in QBO, you have the error as well.

The whole thing is a little edge casey, but I stumbled upon it when I joined a call with Ryan and a custy the other week. Without the logs and looking at OldDot, they had no way of knowing the config mishap as we weren't surfacing any errors in the NewDot front-end for it.

shawnborton · 2025-03-17T15:21:25Z

Got it, thanks for the explanation. If you are cool with it, I think I am cool with it. I would love a clean video though that doesn't have the offline mode stuff, because that is really tripping me up when trying to evaluate the whole flow.

FitseTLT · 2025-03-17T15:22:55Z

Here it is :

a.mp4

shawnborton · 2025-03-17T17:21:41Z

Why do we see the error under Accounts payable here:

But then as soon as you choose Export as > Journal entry, it looks like we populate that row with a value:

Just checking, is that expected? Again, I am not too familiar with what is going on here so just calling that out as it felt a bit odd to me. Thoughts @trjExpensify?

trjExpensify · 2025-03-18T00:44:41Z

Yeah, it's expected. Different export destinations have different accounts that are valid for that type.

Why do we see the error under Accounts payable here:

When your export destination is Vendor bill, A/P accounts from QBO are returned in this field. The user doesn't have any A/P accounts in QBO and therefore we see the error.

But then as soon as you choose Export as > Journal entry, it looks like we populate that row with a value:

These are valid journal entry accounts for the Journal entry export destination. The user has some of these in QBO, so there's no error. IIRC, with both OldDot and NewDot, we populate the first account in the list of valid accounts returned. That part is untouched here anyhow.

shawnborton · 2025-03-18T08:34:13Z

Okay cool, appreciate the explanation as always - I rest my case :) Let's move forward with getting this merged.

src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseConfigurationPage.tsx

hoangzinh · 2025-03-18T13:47:21Z

src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseEntitySelectPage.tsx

            errorRowStyles={[styles.ph5, styles.pv3]}
-            onClose={() => clearQBOErrorField(policyID, CONST.QUICKBOOKS_CONFIG.REIMBURSABLE_EXPENSES_EXPORT_DESTINATION)}
+            onClose={() => {
+                setSelectedAccountError(null);


Do we need to clear selectedAccountError state on close here?

Otherwise the selected account error wouldn't be cancelable.

…etting-bug

hoangzinh · 2025-03-18T15:11:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-19.at.18.58.53.android.mov

Android: mWeb Chrome

Screen.Recording.2025-03-19.at.18.47.50.android.chrome.mov

iOS: Native

Screen.Recording.2025-03-19.at.19.10.42.mov

iOS: mWeb Safari

Screen.Recording.2025-03-19.at.19.01.52.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-19.at.17.58.08.web.mov

MacOS: Desktop

Screen.Recording.2025-03-19.at.18.34.45.desktop.mov

hoangzinh · 2025-03-19T10:01:28Z

If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

@FitseTLT can you complete this checklist? Thank you.

FitseTLT · 2025-03-19T20:22:18Z

Done @hoangzinh

hoangzinh

LGTM

OSBotify · 2025-03-20T00:29:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-20T15:37:06Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.1.16-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

IuliiaHerets · 2025-03-21T10:40:01Z

Hello @FitseTLT. Can you please help us, should we use some specific account or did some preconditions for checking this PR?
We don't have a "not configured" or "no account payable" at - Settings > Workspace > the linked workspace with the qbo connection > Accounting > Export > Export out of pocket expenses as using expensifail account

bandicam.2025-03-21.12-34-46-457.mp4

FitseTLT · 2025-03-21T12:31:53Z

Yeah @IuliiaHerets it looks like all the export destinations in your video have payable accounts. But for me it is easy to reproduce; In OD I integrate any workspace with QBO and I will not finish the final settings part in OD because it will not allow me a destination without A/P. Now opening ND will have no export destination selected and selecting a destination without A/P will show an error. cc @trjExpensify

2025-03-21.15-25-51.mp4

hoangzinh · 2025-03-21T12:33:23Z

@IuliiaHerets we can set it in OD. Here are steps:

Go to OD
Go to a WS that connected to QBO
Open Chrome dev tool
Type in console

p = Policy.getCurrent()
p.policy.connections.quickbooksOnline.config.reimbursableExpensesAccount = null;
p.save();

Go back to ND to continue test

(Note: Sometimes, it will make QBO integration broken and we can't update Export out-of-pocket expenses, please try to disconnect and reconnect again to auto fix)

Screen.Recording.2025-03-21.at.19.26.44.mov

IuliiaHerets · 2025-03-21T13:22:38Z

@FitseTLT @hoangzinh QA team can only complete the PR steps from 1 - 4. Number 5 triggers the mentioned issue (Note: Sometimes, it will make QBO integration broken and we can't update Export out-of-pocket expenses, please try to disconnect and reconnect again to auto fix)
We have tried disconnecting and reconnecting 7-8 times now. Reconnecting clears the RBR so the expected error in step 6 isn't appearing. If we do the console trick in OD, we are breaking the QBO connection again.

bandicam.2025-03-21.14-07-01-985.mp4

FitseTLT · 2025-03-21T13:32:33Z

In that case I think you guys need a brand new QBO connection/company that doesn't have Account Payable linked to some of the export destinations. That's exactly the target of the PR so you can't test it on QBO company which has A/P linked to all export destinations.

hoangzinh · 2025-03-21T13:43:32Z

or you can try on a new/another workspace @IuliiaHerets

IuliiaHerets · 2025-03-21T15:53:49Z

@FitseTLT @hoangzinh Tester has already tested with a new WS and a brand new Gmail account but he got the same results.
There's only one company that he can connect to when setting up the QBO connection and that one has A/P options linked. How we can connected to another company?

bandicam.2025-03-21.19-08-08-513.mp4

github-actions · 2025-03-21T22:21:08Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.16-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

hoangzinh · 2025-03-21T22:41:43Z

@IuliiaHerets just wanna confirm if you still can't update Export out-of-pocket expenses even though you tried on a brand new account or WS, can you?

IuliiaHerets · 2025-03-21T23:24:07Z

@hoangzinh yes, we can't

hoangzinh · 2025-03-22T04:04:37Z

@yuwenmemon are you available to help us in this case? @IuliiaHerets found it hard to set up a WS that has A/P as null, then I suggested a trick here, it worked fine in my end (for Contributor Plus QBO account). @IuliiaHerets tried the same but then her QBO integration got broken (her recording here). Can you take a look and suggest to @IuliiaHerets what she should do to fix it? Thank you.

yuwenmemon · 2025-03-28T06:08:01Z

Sorry - don't think we have to worry about getting them set up to test it. It's an edge case bug anyway. Let's just move on 👍

FitseTLT added 2 commits March 12, 2025 22:58

implemented qbo export config error

3e80b42

minor fix

84f96cb

FitseTLT requested a review from a team as a code owner March 13, 2025 13:19

melvin-bot bot requested review from hoangzinh and removed request for a team March 13, 2025 13:19

FitseTLT mentioned this pull request Mar 13, 2025

[$250] QBO - Push input is not cleared when the export method is changed to an export method that has no accounts available. #57548

Closed

8 tasks

FitseTLT added 4 commits March 13, 2025 17:52

fix ts error

857b84c

ts fix

ae1213b

ts fix

34c62f5

update copy

0095f38

Merge branch 'main' into fix-qbo-export-destination-account-payable-s…

d7708a2

…etting-bug

trjExpensify requested a review from a team March 17, 2025 12:01

hoangzinh reviewed Mar 18, 2025

View reviewed changes

FitseTLT added 3 commits March 18, 2025 17:10

Merge branch 'main' into fix-qbo-export-destination-account-payable-s…

80e7bd1

…etting-bug

minor fix

0423929

rename var

0d7c4e1

hoangzinh approved these changes Mar 19, 2025

View reviewed changes

melvin-bot bot requested a review from yuwenmemon March 19, 2025 23:37

yuwenmemon approved these changes Mar 20, 2025

View reviewed changes

yuwenmemon merged commit 524c4e8 into Expensify:main Mar 20, 2025
18 checks passed

github-actions bot mentioned this pull request Mar 20, 2025

Deploy Checklist: New Expensify 2025-03-20 #58801

Closed

72 tasks

hoangzinh mentioned this pull request Apr 8, 2025

Use new multi config edit command #41627

Merged

50 tasks

Fix - QBO - Push input is not cleared when the export method is changed to an export method that has no accounts available. #58370

Fix - QBO - Push input is not cleared when the export method is changed to an export method that has no accounts available. #58370

Uh oh!

Conversation

FitseTLT commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 13, 2025

Uh oh!

hoangzinh commented Mar 17, 2025

Uh oh!

FitseTLT commented Mar 17, 2025

Uh oh!

trjExpensify commented Mar 17, 2025

Uh oh!

FitseTLT commented Mar 17, 2025

Uh oh!

shawnborton commented Mar 17, 2025

Uh oh!

trjExpensify commented Mar 17, 2025

Uh oh!

shawnborton commented Mar 17, 2025

Uh oh!

FitseTLT commented Mar 17, 2025

Uh oh!

shawnborton commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify commented Mar 18, 2025

Uh oh!

shawnborton commented Mar 18, 2025

Uh oh!

Uh oh!

Uh oh!

hoangzinh Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

FitseTLT Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Mar 19, 2025

Uh oh!

FitseTLT commented Mar 19, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

IuliiaHerets commented Mar 21, 2025

Uh oh!

FitseTLT commented Mar 21, 2025

Uh oh!

hoangzinh commented Mar 21, 2025

Uh oh!

IuliiaHerets commented Mar 21, 2025

Uh oh!

FitseTLT commented Mar 21, 2025

Uh oh!

hoangzinh commented Mar 21, 2025

Uh oh!

IuliiaHerets commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 21, 2025

FitseTLT commented Mar 13, 2025 •

edited

Loading

shawnborton commented Mar 17, 2025 •

edited

Loading

hoangzinh commented Mar 18, 2025 •

edited

Loading

IuliiaHerets commented Mar 21, 2025 •

edited

Loading